From patchwork Mon Aug 7 11:23:43 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Catalin Marinas X-Patchwork-Id: 9885057 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 24D73603B4 for ; Mon, 7 Aug 2017 11:24:13 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 1742D267EC for ; Mon, 7 Aug 2017 11:24:13 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 0BFDB26CFC; Mon, 7 Aug 2017 11:24:13 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,RCVD_IN_DNSWL_NONE autolearn=ham version=3.3.1 Received: from bombadil.infradead.org (bombadil.infradead.org [65.50.211.133]) (using TLSv1.2 with cipher AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 7F1B727F92 for ; Mon, 7 Aug 2017 11:24:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=lcGLyRrtNwUAZ/niyVJTSoniz0h/xHmaZE/jJhT68Uc=; b=ljvbN+L4jXcgd2 PP8YbHzoZc/WOVpPI+/+VL/UNXSYBciIuutPtmGAhQuZbleo6cTpj8bkJmhaoGgzWFfrClkRpcexI wS1iPHkxBrbIuukhmwdvi9HwJIQUqxjR88aXM/4B50xRh+5ouDN5oCBZCWxQilVkdg5scuuOfiibQ NEpxumWfpzaW9T6P8WO8Vdi7QhVu1qXxdxGb7RDvRaqfsk2MAJ4TmOSwnoCZ116E0s7Z9YkxTiVYe F8RmZ07nOQCvH4yZB4/qPZkRIG6UQDpJB9B6oP+Jx8Hv0pW+Uyz+t5YZGOWJdmX172ec6YSW+E2wz RE0CMH/Mnrvwbevte5ng==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.87 #1 (Red Hat Linux)) id 1deg8o-0004kc-0e; Mon, 07 Aug 2017 11:24:10 +0000 Received: from foss.arm.com ([217.140.101.70]) by bombadil.infradead.org with esmtp (Exim 4.87 #1 (Red Hat Linux)) id 1deg8l-0004dy-8y for linux-arm-kernel@lists.infradead.org; Mon, 07 Aug 2017 11:24:08 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.72.51.249]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id D8C6A15B2; Mon, 7 Aug 2017 04:23:46 -0700 (PDT) Received: from armageddon.cambridge.arm.com (armageddon.cambridge.arm.com [10.1.206.84]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 1C16A3F540; Mon, 7 Aug 2017 04:23:45 -0700 (PDT) Date: Mon, 7 Aug 2017 12:23:43 +0100 From: Catalin Marinas To: Dave Martin Subject: Re: [PATCH 5/5] arm64: neon: Remove support for nested or hardirq kernel-mode NEON Message-ID: <20170807112343.inxrf3k7qxkgziaj@armageddon.cambridge.arm.com> References: <1501777403-9782-1-git-send-email-Dave.Martin@arm.com> <1501777403-9782-6-git-send-email-Dave.Martin@arm.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <1501777403-9782-6-git-send-email-Dave.Martin@arm.com> User-Agent: NeoMutt/20170113 (1.7.2) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20170807_042407_378754_C56ECC30 X-CRM114-Status: UNSURE ( 8.25 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-arm-kernel@lists.infradead.org, Ard Biesheuvel Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org X-Virus-Scanned: ClamAV using ClamSMTP On Thu, Aug 03, 2017 at 05:23:23PM +0100, Dave P Martin wrote: > diff --git a/arch/arm64/include/asm/simd.h b/arch/arm64/include/asm/simd.h > index 96959b5..5a1a927 100644 > --- a/arch/arm64/include/asm/simd.h > +++ b/arch/arm64/include/asm/simd.h > @@ -9,15 +9,46 @@ > #ifndef __ASM_SIMD_H > #define __ASM_SIMD_H > > +#include > +#include > +#include > #include > > +#ifdef CONFIG_KERNEL_MODE_NEON > + > +DECLARE_PER_CPU(bool, kernel_neon_busy); [...] > @@ -233,49 +254,69 @@ void fpsimd_flush_task_state(struct task_struct *t) > > #ifdef CONFIG_KERNEL_MODE_NEON > > -static DEFINE_PER_CPU(struct fpsimd_partial_state, hardirq_fpsimdstate); > -static DEFINE_PER_CPU(struct fpsimd_partial_state, softirq_fpsimdstate); > +DEFINE_PER_CPU(bool, kernel_neon_busy); This variable needs to be exported to modules (allmodconfig fails to build with these patches). Any preference for GPL vs non-GPL export? diff --git a/arch/arm64/kernel/fpsimd.c b/arch/arm64/kernel/fpsimd.c index 138fcfaeadc1..5dde6f5961a1 100644 --- a/arch/arm64/kernel/fpsimd.c +++ b/arch/arm64/kernel/fpsimd.c @@ -255,6 +255,7 @@ void fpsimd_flush_task_state(struct task_struct *t) #ifdef CONFIG_KERNEL_MODE_NEON DEFINE_PER_CPU(bool, kernel_neon_busy); +EXPORT_PER_CPU_SYMBOL_GPL(kernel_neon_busy); /* * Kernel-side NEON support functions