| Message ID | 20170820155312.831-1-christophe.jaillet@wanadoo.fr (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
diff --git a/drivers/soc/fsl/qe/qe_tdm.c b/drivers/soc/fsl/qe/qe_tdm.c index f744c214f680..6b9647fee512 100644 --- a/drivers/soc/fsl/qe/qe_tdm.c +++ b/drivers/soc/fsl/qe/qe_tdm.c @@ -174,7 +174,6 @@ int ucc_of_parse_tdm(struct device_node *np, struct ucc_tdm *utdm, return ret; err_miss_siram_property: - devm_iounmap(&pdev->dev, utdm->si_regs); return ret; } EXPORT_SYMBOL(ucc_of_parse_tdm);
If 'of_find_device_by_node()' fails at line 153, a NULL pointer dereference (pdev) will occur in the error handling path. Just remove the 'devm_iounmap()' call from the error handling path. The corresponding is managed, there is no need to release explicitly here. Fixes: 35ef1c20fdb2 ("fsl/qe: Add QE TDM lib") Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr> --- This patch is only a guess that sounds logical to me. I propose to remove this 'devm_iounmap' mainly because of its name (if it is managed, why should be manually handle it here ?) --- drivers/soc/fsl/qe/qe_tdm.c | 1 - 1 file changed, 1 deletion(-)