From patchwork Mon Aug 21 16:03:00 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jerome Brunet X-Patchwork-Id: 9913277 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 2EC77600C8 for ; Mon, 21 Aug 2017 16:17:49 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 210ED1FEBA for ; Mon, 21 Aug 2017 16:17:49 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 1490B27CEA; Mon, 21 Aug 2017 16:17:49 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.6 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,RCVD_IN_DNSWL_LOW autolearn=ham version=3.3.1 Received: from bombadil.infradead.org (bombadil.infradead.org [65.50.211.133]) (using TLSv1.2 with cipher AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 683D91FEBA for ; Mon, 21 Aug 2017 16:17:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:MIME-Version:Cc:List-Subscribe: List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id:References: In-Reply-To:Message-Id:Date:Subject:To:From:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Owner; bh=uBQv0Qq7h3K6F5ZLMdryj7Fafz4eviQA3AHA98EMrDI=; b=gTNGGfS+UzFPETnntWBH1ca1a/ fszrdg/725SQeNOUW/Qm/ue5JMk2+ckbL+5cgOEKqGHwoEoNmh+Stu19hm05+gY/JYDtvrkzQf7ag MkkHng+DgNwk0MjOQkOCcHWtOQQ14Ivc5B8y+PtCeMn+0FUq+8PWbFHMys3LbNPkHv1U9fgt4Bj2R N/iTvb7xnc5alAVv2mTlUmPUCAsGIK9wu2qqAyTyLE8f24j2xfsQ9uPzoTZVQ37QptAxT84or9l5Z NtM8FPcU6X8dqIya/5ZtnJMNTIPs2ISsTv8MxrFzWHNOdsqtE5KHvlF0Opd11xV8rAXY5afRuaeKO JDcoQgUw==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.87 #1 (Red Hat Linux)) id 1djpOa-00066d-Gl; Mon, 21 Aug 2017 16:17:44 +0000 Received: from casper.infradead.org ([2001:8b0:10b:1236::1]) by bombadil.infradead.org with esmtps (Exim 4.87 #1 (Red Hat Linux)) id 1djpNu-0005GU-Eh for linux-arm-kernel@bombadil.infradead.org; Mon, 21 Aug 2017 16:17:02 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=References:In-Reply-To:Message-Id:Date: Subject:Cc:To:From:Sender:Reply-To:MIME-Version:Content-Type: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=pwhGKSiatDZIKAM4wyfDOdqR/aXoik20ct+gofTiRgA=; b=GwlZaL70bdAIcWbSreWgTSHLA 14dB0sLavEschXXxmtuEcdGJdvm9TOMCXo/F5PUoWCUgCFiqJMXl1i/aVxnlkkeDBwC1cgMj8zsFU iyh1Uiw3C31VhaXTyA55LQEuUCjQ7U0iWogxgt2MAQXCLQfIPysv8bwJWvt5g0f93z9jEX/IicHUL DYHgzMYGdlFe7V6/lHqo2YXkP4Zr7Ih+1q1R62o8B9by3biDMY/u3ENNVffmZYCNCgjA1Gt7ClC4U uETprN6XZ0qpoo110xgzDXRdZB8BuviqHmLJddkGWrDSUc4Ztr3DAuhN84Dp426WI2qsgAGlGgl1E 97qGa+e0A==; Received: from mail-wr0-x236.google.com ([2a00:1450:400c:c0c::236]) by casper.infradead.org with esmtps (Exim 4.87 #1 (Red Hat Linux)) id 1djpB0-0003Hu-Tf for linux-arm-kernel@lists.infradead.org; Mon, 21 Aug 2017 16:03:45 +0000 Received: by mail-wr0-x236.google.com with SMTP id p8so39043342wrf.5 for ; Mon, 21 Aug 2017 09:03:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=pwhGKSiatDZIKAM4wyfDOdqR/aXoik20ct+gofTiRgA=; b=EsWmTVyuvmIMHotp0HOymvo8BAP5O4W1UO41uPtTcd+0mXb3/kC+7jiR3yQSBsv0Vk GZkJnd2NFjh7v/HYaTXSuBO4jJpo0SFXQN1frY1lK4Hat/gZkZlzZIue5thkSrupEUJH NNWYqOtznnRD3ILLlZwdu/1p/MiLMEIX80qecy/tEmtc/oxlQzyvZ3UPZAbVbUToWu+M mDB7Mfawl4FGX9kB0cry7M6ve338jvMvA78Zv2LzIHBWj17pPQkswZqe63v8MT4nW2Gb pyyw/0sO7oi5qPM567oxQ2tVDkh3QuI7TwMYgYaRjkEXvWoQbXmXs0cAahr3uD2I4SI1 FXrg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=pwhGKSiatDZIKAM4wyfDOdqR/aXoik20ct+gofTiRgA=; b=PhQq5C5RxjoEZEqf+Cu4cEKMma5xuj+oHoNLYuwxyhkuRgceihIAM9r/LdSpYXa3n5 SAgmmpHvvdPgVFv+4+450Tw11cv7ARn/98fb+9T+ag7cVE6bH3Rb8rK3xlIZWHDx7X9F ne5kGA9yEhd+FaSFgpqyMcYZzfE35Xc7IJxJt+tzWheZEVLZQgiQ4gwysJGa+s0/SMm6 5zXbXAbAiSrAtXughyWIsyCWe1C+sO/NdDuUu5DRa0PEOaS7X48i25hgroxRzA4Zhree imwxf1+Sah0cUDV5M038Rs7GajWNkg9Y8RTbQiFFVCCZgmkfJYatNsNTQS1WAGPT7NH2 pVFA== X-Gm-Message-State: AHYfb5h9U+os0QQrQ31g5xgEo59yBD6Bp9aaU/N1KiYos60T8P/0qtrL 6DvqWhNKZQPdlXMa X-Received: by 10.28.161.196 with SMTP id k187mr1898796wme.118.1503331401515; Mon, 21 Aug 2017 09:03:21 -0700 (PDT) Received: from localhost.localdomain ([90.63.244.31]) by smtp.googlemail.com with ESMTPSA id 63sm8120063wra.30.2017.08.21.09.03.20 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 21 Aug 2017 09:03:21 -0700 (PDT) From: Jerome Brunet To: Ulf Hansson , Kevin Hilman , Carlo Caione Subject: [PATCH v2 15/16] mmc: meson-gx: change default tx phase Date: Mon, 21 Aug 2017 18:03:00 +0200 Message-Id: <20170821160301.21899-16-jbrunet@baylibre.com> X-Mailer: git-send-email 2.9.5 In-Reply-To: <20170821160301.21899-1-jbrunet@baylibre.com> References: <20170821160301.21899-1-jbrunet@baylibre.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20170821_170343_014682_7F7468EA X-CRM114-Status: GOOD ( 12.01 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-amlogic@lists.infradead.org, linux-mmc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Jerome Brunet MIME-Version: 1.0 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org X-Virus-Scanned: ClamAV using ClamSMTP Initial default tx phase was set to 0 while the datasheet recommends 270. Some cards fails to initialize with this setting and eMMC mode DDR52 does not work. Changing this setting to 270 fixes these issues, without any regression so far Signed-off-by: Jerome Brunet Reviewed-by: Kevin Hilman --- drivers/mmc/host/meson-gx-mmc.c | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/drivers/mmc/host/meson-gx-mmc.c b/drivers/mmc/host/meson-gx-mmc.c index 3167f561e1a6..290631d46a4b 100644 --- a/drivers/mmc/host/meson-gx-mmc.c +++ b/drivers/mmc/host/meson-gx-mmc.c @@ -1158,8 +1158,14 @@ static int meson_mmc_probe(struct platform_device *pdev) if (ret) goto free_host; + /* + * Set phases : These values are mostly the datasheet recommended ones + * except for the Tx phase. Datasheet recommends 180 but some cards + * fail at initialisation with it. 270 works just fine, it fixes these + * initialisation issues and enable eMMC DDR52 mode. + */ host->tp.core_phase = 180; - host->tp.tx_phase = 0; + host->tp.tx_phase = 270; host->tp.rx_phase = 0; ret = meson_mmc_clk_init(host);