| Message ID | 20170829131238.4988-2-jglauber@cavium.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Tue, Aug 29, 2017 at 03:12:32PM +0200, Jan Glauber wrote: > The memory controller on ThunderX/OcteonTX systems does not > support power management. Therefore remove the suspend/resume > callbacks. > > Signed-off-by: Jan Glauber <jglauber@cavium.com> > --- > drivers/edac/thunderx_edac.c | 21 --------------------- > 1 file changed, 21 deletions(-) Just when I thought I'd pick that one up now because it is removing stuff: drivers/edac/thunderx_edac.c:817:14: error: ‘thunderx_lmc_suspend’ undeclared here (not in a function) .suspend = thunderx_lmc_suspend, ^~~~~~~~~~~~~~~~~~~~ drivers/edac/thunderx_edac.c:818:14: error: ‘thunderx_lmc_resume’ undeclared here (not in a function) .resume = thunderx_lmc_resume, ^~~~~~~~~~~~~~~~~~~ scripts/Makefile.build:308: recipe for target 'drivers/edac/thunderx_edac.o' failed make[1]: *** [drivers/edac/thunderx_edac.o] Error 1 make[1]: *** Waiting for unfinished jobs.... Makefile:1682: recipe for target 'drivers/edac/' failed make: *** [drivers/edac/] Error 2 Please make sure you build and test every patch before submitting. You're lucky I can at least build arm64 on my x86 workstation. :-) Thx.
On Wed, Aug 30, 2017 at 07:54:06PM +0200, Borislav Petkov wrote: > On Tue, Aug 29, 2017 at 03:12:32PM +0200, Jan Glauber wrote: > > The memory controller on ThunderX/OcteonTX systems does not > > support power management. Therefore remove the suspend/resume > > callbacks. > > > > Signed-off-by: Jan Glauber <jglauber@cavium.com> > > --- > > drivers/edac/thunderx_edac.c | 21 --------------------- > > 1 file changed, 21 deletions(-) > > Just when I thought I'd pick that one up now because it is removing > stuff: > > drivers/edac/thunderx_edac.c:817:14: error: ‘thunderx_lmc_suspend’ undeclared here (not in a function) > .suspend = thunderx_lmc_suspend, > ^~~~~~~~~~~~~~~~~~~~ > drivers/edac/thunderx_edac.c:818:14: error: ‘thunderx_lmc_resume’ undeclared here (not in a function) > .resume = thunderx_lmc_resume, > ^~~~~~~~~~~~~~~~~~~ > scripts/Makefile.build:308: recipe for target 'drivers/edac/thunderx_edac.o' failed > make[1]: *** [drivers/edac/thunderx_edac.o] Error 1 > make[1]: *** Waiting for unfinished jobs.... > Makefile:1682: recipe for target 'drivers/edac/' failed > make: *** [drivers/edac/] Error 2 Argh... forgot to build test the single patches. > Please make sure you build and test every patch before submitting. > You're lucky I can at least build arm64 on my x86 workstation. :-) Sorry for that. The whole series builds because I removed the suspend/resume callbacks during the move to the soc driver. --Jan > Thx. > > -- > Regards/Gruss, > Boris. > > Good mailing practices for 400: avoid top-posting and trim the reply.
diff --git a/drivers/edac/thunderx_edac.c b/drivers/edac/thunderx_edac.c index 2d352b4..d02bf3b 100644 --- a/drivers/edac/thunderx_edac.c +++ b/drivers/edac/thunderx_edac.c @@ -639,27 +639,6 @@ static irqreturn_t thunderx_lmc_threaded_isr(int irq, void *dev_id) return ret; } -#ifdef CONFIG_PM -static int thunderx_lmc_suspend(struct pci_dev *pdev, pm_message_t state) -{ - pci_save_state(pdev); - pci_disable_device(pdev); - - pci_set_power_state(pdev, pci_choose_state(pdev, state)); - - return 0; -} - -static int thunderx_lmc_resume(struct pci_dev *pdev) -{ - pci_set_power_state(pdev, PCI_D0); - pci_enable_wake(pdev, PCI_D0, 0); - pci_restore_state(pdev); - - return 0; -} -#endif - static const struct pci_device_id thunderx_lmc_pci_tbl[] = { { PCI_DEVICE(PCI_VENDOR_ID_CAVIUM, PCI_DEVICE_ID_THUNDER_LMC) }, { 0, },
The memory controller on ThunderX/OcteonTX systems does not support power management. Therefore remove the suspend/resume callbacks. Signed-off-by: Jan Glauber <jglauber@cavium.com> --- drivers/edac/thunderx_edac.c | 21 --------------------- 1 file changed, 21 deletions(-)