| Message ID | 20171011022958.31268-4-chris.packham@alliedtelesis.co.nz (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
Hi Chris, On mer., oct. 11 2017, Chris Packham <chris.packham@alliedtelesis.co.nz> wrote: > The watchdog timer interrupt is available internally on the Armada-38x > SoCs. Connect it so that we can have the orion_wdt_irq generate debug > information when a watchdog timeout occurs. Given the patch 2, when an interrupt is provided by the dt, then the behavior of the watchdog changes. So we can't do it for all the platform. As you propose on your cover letter it is better to set it at board level. So instead of this patch you should update the binding documentation with this new resources. Thanks to this each board developer will be able to decide to use this feature or not. Thanks, Gregory > > Signed-off-by: Chris Packham <chris.packham@alliedtelesis.co.nz> > --- > arch/arm/boot/dts/armada-38x.dtsi | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/arch/arm/boot/dts/armada-38x.dtsi b/arch/arm/boot/dts/armada-38x.dtsi > index 7ff0811e61db..9ac76c54c9e5 100644 > --- a/arch/arm/boot/dts/armada-38x.dtsi > +++ b/arch/arm/boot/dts/armada-38x.dtsi > @@ -408,6 +408,7 @@ > reg = <0x20300 0x34>, <0x20704 0x4>, <0x18260 0x4>; > clocks = <&coreclk 2>, <&refclk>; > clock-names = "nbclk", "fixed"; > + interrupts = <GIC_SPI 64 IRQ_TYPE_LEVEL_HIGH>; > }; > > cpurst: cpurst@20800 { > -- > 2.14.2 >
On 13/10/17 03:17, Gregory CLEMENT wrote: > Hi Chris, > > On mer., oct. 11 2017, Chris Packham <chris.packham@alliedtelesis.co.nz> wrote: > >> The watchdog timer interrupt is available internally on the Armada-38x >> SoCs. Connect it so that we can have the orion_wdt_irq generate debug >> information when a watchdog timeout occurs. > > Given the patch 2, when an interrupt is provided by the dt, then the > behavior of the watchdog changes. So we can't do it for all the > platform. > > As you propose on your cover letter it is better to set it at board > level. > > So instead of this patch you should update the binding documentation > with this new resources. Thanks to this each board developer will be > able to decide to use this feature or not. Agreed. I'll drop this patch in favor of a documentation update in v2. > > Thanks, > > Gregory > >> >> Signed-off-by: Chris Packham <chris.packham@alliedtelesis.co.nz> >> --- >> arch/arm/boot/dts/armada-38x.dtsi | 1 + >> 1 file changed, 1 insertion(+) >> >> diff --git a/arch/arm/boot/dts/armada-38x.dtsi b/arch/arm/boot/dts/armada-38x.dtsi >> index 7ff0811e61db..9ac76c54c9e5 100644 >> --- a/arch/arm/boot/dts/armada-38x.dtsi >> +++ b/arch/arm/boot/dts/armada-38x.dtsi >> @@ -408,6 +408,7 @@ >> reg = <0x20300 0x34>, <0x20704 0x4>, <0x18260 0x4>; >> clocks = <&coreclk 2>, <&refclk>; >> clock-names = "nbclk", "fixed"; >> + interrupts = <GIC_SPI 64 IRQ_TYPE_LEVEL_HIGH>; >> }; >> >> cpurst: cpurst@20800 { >> -- >> 2.14.2 >> >
diff --git a/arch/arm/boot/dts/armada-38x.dtsi b/arch/arm/boot/dts/armada-38x.dtsi index 7ff0811e61db..9ac76c54c9e5 100644 --- a/arch/arm/boot/dts/armada-38x.dtsi +++ b/arch/arm/boot/dts/armada-38x.dtsi @@ -408,6 +408,7 @@ reg = <0x20300 0x34>, <0x20704 0x4>, <0x18260 0x4>; clocks = <&coreclk 2>, <&refclk>; clock-names = "nbclk", "fixed"; + interrupts = <GIC_SPI 64 IRQ_TYPE_LEVEL_HIGH>; }; cpurst: cpurst@20800 {
The watchdog timer interrupt is available internally on the Armada-38x SoCs. Connect it so that we can have the orion_wdt_irq generate debug information when a watchdog timeout occurs. Signed-off-by: Chris Packham <chris.packham@alliedtelesis.co.nz> --- arch/arm/boot/dts/armada-38x.dtsi | 1 + 1 file changed, 1 insertion(+)