From patchwork Wed Nov 8 00:44:42 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Florian Fainelli X-Patchwork-Id: 10047485 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 01F3960247 for ; Wed, 8 Nov 2017 00:51:25 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id E8C1A28F67 for ; Wed, 8 Nov 2017 00:51:24 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id DD4122A277; Wed, 8 Nov 2017 00:51:24 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.2 required=2.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED, DKIM_VALID, FREEMAIL_FROM, RCVD_IN_DNSWL_MED autolearn=ham version=3.3.1 Received: from bombadil.infradead.org (bombadil.infradead.org [65.50.211.133]) (using TLSv1.2 with cipher AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 9692128F67 for ; Wed, 8 Nov 2017 00:51:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:MIME-Version:Cc:List-Subscribe: List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id:References: In-Reply-To:Message-Id:Date:Subject:To:From:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Owner; bh=F3AolQPG4eZyoE6yC3RCIxqsLTUqAMzu+WVl4Qf/zn8=; b=KevKczpobumAqCjgtY5cT6QxPS Paxs+6wr+apvOoLmabcxeFwr8SLlxSQskVO9cEfsj0OWZnPh8RmZHF9nXd0b+GZOKiKoAdJ5o58Yo s4rFOxUaujpGLmA00Gjtcl8UT928QysLNPEz2LOe6hEWHHKpawUXEiHR4D65zLi/TFDItASmu3F/2 79+aT5BRL2KTVamZKef0RCaNgL6tYAzMoiyScEHHGY8qguLmSWQdF0feeESsIemxWgTweBU12IKIn CZdvYIueAW+IGf1JI1t5L0zo71XaxH3ScWEvLdHqs5NNR4ingWlOyCdQQ+Sid9P20jskf8Jw7dMXb fGzHwTNw==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.87 #1 (Red Hat Linux)) id 1eCEaL-0003ns-JC; Wed, 08 Nov 2017 00:51:17 +0000 Received: from mail-qk0-x242.google.com ([2607:f8b0:400d:c09::242]) by bombadil.infradead.org with esmtps (Exim 4.87 #1 (Red Hat Linux)) id 1eCEUm-0005gr-AC; Wed, 08 Nov 2017 00:45:38 +0000 Received: by mail-qk0-x242.google.com with SMTP id 78so1411531qkz.0; Tue, 07 Nov 2017 16:45:11 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=6a8IvgwuJ4WW5xrFcEkoR/J868kRMD53Wd1EtssvYVc=; b=dVTEsTSXZHdFK8r5tcwsRkOTPFR+1r77KIKBEOYN79G0ZrVmV0NCNrH6sNyvudOLuI Fswgre/P+lxEm6hKpR8XVZ6woFJhKQtIdnosJPOL4bN1J1J1tOE7ht2I+p/ZZqDD8hIS w7GiTw00mdKRiGscJMLgzR5O1BrtNKEwUBELuxRqCVsjHsH/bNqQLZnszlFCVEVgeSel 91KZ1k1z41DW3RUmojTVuHN9t5qc5y0inNCLJQZxl12yRzROuB3zgAMsu2hiqUne4W5m Pwuwb5HI94CG1abC1ovHgkl7Dj9rQ76+BL3yTAW7+QUVEtsskbHQ8RZu2FLZ13Oc4m3c 9yEg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=6a8IvgwuJ4WW5xrFcEkoR/J868kRMD53Wd1EtssvYVc=; b=nqRVrD3ChImrzRwUHF7TFTMHtHIpd+xM6oH2agqI7BpS2lVzWQA5KdSL9ciHysRJEP YbfGywJrWEoaUOL3owQarO5Iy/PmFEsh7fb4WOP/94bjHfNxdLSHgJsuG8liDqldrPuZ jx07OKoaAFxmjDZu04XWXgnDXI3lcPNQD3JH3lmyeRBgixqFOwukJQWjBIR2Zga4rFm/ 6j4xwILDYmkd70lQbdfJvSdJRmEL5HTA0qGaK/X9ELvRseo8T/Nx4A8hJZBGA103D8C3 QAsubK3njOhV6Yb5cVAx6l6z+xHNXrXk4hyzItSTDAi7YZdDKyv14QXTwad+N03NUUvi a5nQ== X-Gm-Message-State: AJaThX58hT/MMMqdinYD6WD5xKiiaiLstXCwNLz6CJ9NAZGvUYgHsuUx E1jDMmvojuVNF/O4ztxGb0I= X-Google-Smtp-Source: AGs4zMZbA7PtpvoVXGLKOMx/4lpeIKQzHdRs1noJRPSJ5F1XDYbaWQYzF8PGNkLvNZGx32AeIbYLLA== X-Received: by 10.55.71.72 with SMTP id u69mr883868qka.289.1510101910808; Tue, 07 Nov 2017 16:45:10 -0800 (PST) Received: from fainelli-desktop.broadcom.com ([192.19.255.250]) by smtp.gmail.com with ESMTPSA id y9sm1862407qth.43.2017.11.07.16.45.07 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 07 Nov 2017 16:45:09 -0800 (PST) From: Florian Fainelli To: linux-kernel@vger.kernel.org Subject: [PATCH v2 05/12] hwrng: bcm2835-rng: Use device managed helpers Date: Tue, 7 Nov 2017 16:44:42 -0800 Message-Id: <20171108004449.32730-6-f.fainelli@gmail.com> X-Mailer: git-send-email 2.9.3 In-Reply-To: <20171108004449.32730-1-f.fainelli@gmail.com> References: <20171108004449.32730-1-f.fainelli@gmail.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20171107_164532_847968_066064E1 X-CRM114-Status: UNSURE ( 9.62 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , Stefan Wahren , Florian Fainelli , Martin Kaiser , Herbert Xu , Scott Branden , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , Ray Jui , PrasannaKumar Muralidharan , Harald Freudenberger , Krzysztof Kozlowski , Eric Anholt , Russell King , Rob Herring , "maintainer:BROADCOM BCM281XX/BCM11XXX/BCM216XX ARM ARCHITE..." , "open list:HARDWARE RANDOM NUMBER GENERATOR CORE" , Sean Wang , Matt Mackall , Steffen Trumtrar , "moderated list:BROADCOM BCM2835 ARM ARCHITECTURE" , "moderated list:BROADCOM BCM2835 ARM ARCHITECTURE" MIME-Version: 1.0 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org X-Virus-Scanned: ClamAV using ClamSMTP Now that we have moved the RNG disabling into a hwrng::cleanup callback, we can use the device managed registration operation and remove our remove callback since it won't do anything necessary. Signed-off-by: Florian Fainelli Reviewed-by: Eric Anholt --- drivers/char/hw_random/bcm2835-rng.c | 13 +------------ 1 file changed, 1 insertion(+), 12 deletions(-) diff --git a/drivers/char/hw_random/bcm2835-rng.c b/drivers/char/hw_random/bcm2835-rng.c index 4d0356110b1b..67b9bd3be28d 100644 --- a/drivers/char/hw_random/bcm2835-rng.c +++ b/drivers/char/hw_random/bcm2835-rng.c @@ -138,7 +138,7 @@ static int bcm2835_rng_probe(struct platform_device *pdev) rng_setup(priv->base); /* register driver */ - err = hwrng_register(&priv->rng); + err = devm_hwrng_register(dev, &priv->rng); if (err) dev_err(dev, "hwrng registration failed\n"); else @@ -147,16 +147,6 @@ static int bcm2835_rng_probe(struct platform_device *pdev) return err; } -static int bcm2835_rng_remove(struct platform_device *pdev) -{ - struct bcm2835_rng_priv *priv = platform_get_drvdata(pdev); - - /* unregister driver */ - hwrng_unregister(&priv->rng); - - return 0; -} - MODULE_DEVICE_TABLE(of, bcm2835_rng_of_match); static struct platform_driver bcm2835_rng_driver = { @@ -165,7 +155,6 @@ static struct platform_driver bcm2835_rng_driver = { .of_match_table = bcm2835_rng_of_match, }, .probe = bcm2835_rng_probe, - .remove = bcm2835_rng_remove, }; module_platform_driver(bcm2835_rng_driver);