From patchwork Thu Nov 9 14:08:33 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Greg KH X-Patchwork-Id: 10051015 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id E600960381 for ; Thu, 9 Nov 2017 14:08:49 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id D80332AC02 for ; Thu, 9 Nov 2017 14:08:49 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id CC9D02AD7F; Thu, 9 Nov 2017 14:08:49 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.2 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,RCVD_IN_DNSWL_MED autolearn=ham version=3.3.1 Received: from bombadil.infradead.org (bombadil.infradead.org [65.50.211.133]) (using TLSv1.2 with cipher AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 3E1362AC02 for ; Thu, 9 Nov 2017 14:08:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=TGGidyvSJlM86B2q9wtuI6+JKeAijF3cMFx9KqhMjeY=; b=S2GVXXxqkfU8gO pEv/9FG+ggmG5VqikEBmI6ymHfA+Ii+OoTv0MU79VXmBaKib7W7HynPD07pyQnAoC5816TJwOH6Tm kPrtjavuT1v+OjOPuVnPpnO+slyUMYUQAiuIbfLPwfMth+0TvCil4ANLriYLU5v8lknGNhkccaEiy gWzbUQcCcOV53xnJtvyn+1kOFIlkBXNyc3TdLvnXDu+xgQ4t62r9DeE+oJnpj1+9bb/ej0/Jfnjps UF3MyAFyOFtiwxsAs0fUB9QzDNrORZRc4T0sJF2F/NN4qamv+9Uz06hTQw0xlfcHw4Qs5/A4n/wSj 7L+tCpmaMse9g+Md8jdg==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.87 #1 (Red Hat Linux)) id 1eCnVg-0001Q4-88; Thu, 09 Nov 2017 14:08:48 +0000 Received: from mail.linuxfoundation.org ([140.211.169.12]) by bombadil.infradead.org with esmtps (Exim 4.87 #1 (Red Hat Linux)) id 1eCnVb-0001Fo-Cd for linux-arm-kernel@lists.infradead.org; Thu, 09 Nov 2017 14:08:45 +0000 Received: from localhost (LFbn-1-12253-150.w90-92.abo.wanadoo.fr [90.92.67.150]) by mail.linuxfoundation.org (Postfix) with ESMTPSA id A0CA9BD8; Thu, 9 Nov 2017 14:08:21 +0000 (UTC) Date: Thu, 9 Nov 2017 15:08:33 +0100 From: Greg KH To: Mark Brown Subject: Re: next/master boot: 264 boots: 62 failed, 199 passed with 3 conflicts (next-20171109) Message-ID: <20171109140833.GJ6545@kroah.com> References: <5a0446a2.85a8500a.55819.1c58@mx.google.com> <20171109134502.wyxxcstplybe4ed4@sirena.co.uk> <20171109134713.fjw7wlflu4dj45xm@sirena.co.uk> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20171109134713.fjw7wlflu4dj45xm@sirena.co.uk> User-Agent: Mutt/1.9.1 (2017-09-22) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20171109_060843_532694_9D281302 X-CRM114-Status: GOOD ( 15.28 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Florian Fainelli , "kernelci.org bot" , Scott Branden , kernel-build-reports@lists.linaro.org, Ray Jui , linux-usb@vger.kernel.org, Guillaume Tucker , linux-arm-kernel@lists.infradead.org Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org X-Virus-Scanned: ClamAV using ClamSMTP On Thu, Nov 09, 2017 at 01:47:13PM +0000, Mark Brown wrote: > On Thu, Nov 09, 2017 at 01:45:02PM +0000, Mark Brown wrote: > > On Thu, Nov 09, 2017 at 04:14:26AM -0800, kernelci.org bot wrote: > > > > Today's -next fails to boot a bcm2836-rpi-2-b on any config in kernelci, > > it was working yesterday: > > > > > bcm2835_defconfig: > > > bcm2836-rpi-2-b: > > > lab-collabora: new failure (last pass: next-20171107) > > > > The boot log looks like something went badly wrong with USB: > > > > [ 1.643488] dwc2 3f980000.usb: DWC OTG Controller > > [ 1.648225] dwc2 3f980000.usb: new USB bus registered, assigned bus number 1 > > [ 1.655328] dwc2 3f980000.usb: irq 39, io mem 0x3f980000 > > [ 1.661495] hub 1-0:1.0: USB hub found > > [ 1.665301] hub 1-0:1.0: 1 port detected > > [ 1.669239] hub 1-0:1.0: config failed, can't get hub status (err 2) > > [ 1.676763] hub 1-0:1.0: activate --> -22 > > [ 1.680806] hub 1-0:1.0: activate --> -22 > > [ 1.684855] hub 1-0:1.0: activate --> -22 > > > > and so on until the tester gets bored. There's nothing obvious changed > > in arch/arm or drivers/usb though. > > > > More info and full log here: > > > > https://kernelci.org/boot/id/5a04231159b514cb291cdd1a/ > > There's similar issues reported for Odroid c1 with the same DesignWare > controller so it's unlikely to be something Raspberry Pi related: > > https://kernelci.org/boot/id/5a0416c059b514c4931cdd1b/ Fix is already diagnosed and is in my tree now. I've put it below if you need/want it now. thanks, greg k-h ------------- From d656fa32b13424701bb85f6b5183ea869b363799 Mon Sep 17 00:00:00 2001 From: Felipe Balbi Date: Thu, 9 Nov 2017 12:59:58 +0200 Subject: usb: core: message: remember to reset 'ret' to 0 when necessary usb_control_msg() will return the amount of bytes transferred, if that amount matches what we wanted to transfer, we need to reset 'ret' to 0 from usb_get_status(). Fixes: 2e43f0fe379c ("usb: core: add a 'type' parameter to usb_get_status()") Reported-by: Tony Lindgren Signed-off-by: Felipe Balbi Signed-off-by: Greg Kroah-Hartman --- drivers/usb/core/message.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/usb/core/message.c b/drivers/usb/core/message.c index ebaea514161f..77001bcfc504 100644 --- a/drivers/usb/core/message.c +++ b/drivers/usb/core/message.c @@ -975,6 +975,7 @@ int usb_get_status(struct usb_device *dev, int recip, int type, int target, } *(u32 *) data = le32_to_cpu(*(__le32 *) status); + ret = 0; break; case 2: if (type != USB_STATUS_TYPE_STANDARD) { @@ -983,6 +984,7 @@ int usb_get_status(struct usb_device *dev, int recip, int type, int target, } *(u16 *) data = le16_to_cpu(*(__le16 *) status); + ret = 0; break; default: ret = -EIO;