From patchwork Fri Nov 10 08:37:55 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Christoffer Dall X-Patchwork-Id: 10052593 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 068016035D for ; Fri, 10 Nov 2017 08:38:18 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id E836E2AD5A for ; Fri, 10 Nov 2017 08:38:17 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id DCF7D2B282; Fri, 10 Nov 2017 08:38:17 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.2 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,RCVD_IN_DNSWL_MED autolearn=unavailable version=3.3.1 Received: from bombadil.infradead.org (bombadil.infradead.org [65.50.211.133]) (using TLSv1.2 with cipher AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 72B1D2AD5A for ; Fri, 10 Nov 2017 08:38:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=JjpujsrsgnTKf67BlHMeZeSZi+SmyX5+GmjEJGNtH+8=; b=XQ9VPvo1qgfKDP 2qF3j49ZdHTTyyfqO6ExUv7JVhg1IycOduekoSCFnuU2hVVImh/soilDQD9CIhoXB7oMQVLWmuqH0 D9hmSwvjM75eHrMUZCM5L7Tnt2sKxF35LbagRjusUXhVbW1JiQ4YkQhzM/ASYSpecp2ixOuvffDrd xne8CxP5b4u2cdx1NjaVsHUrCzjuGzwEgioEyMlaACLUVFR9YhKo3NafG/VJAjgxnDnxqFtmFznwI EhQlRAZ/neO2TynoqwwAvOQEWhxKwtHBqE0JJMuMEXiQDdKAbydCgRk1N+xWchloyGfDsMcJBOZxQ jUzK52hnZbRWeW8eGaHg==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.87 #1 (Red Hat Linux)) id 1eD4pM-0002Cq-ON; Fri, 10 Nov 2017 08:38:16 +0000 Received: from mail-wm0-x243.google.com ([2a00:1450:400c:c09::243]) by bombadil.infradead.org with esmtps (Exim 4.87 #1 (Red Hat Linux)) id 1eD4pI-0002B0-I5 for linux-arm-kernel@lists.infradead.org; Fri, 10 Nov 2017 08:38:14 +0000 Received: by mail-wm0-x243.google.com with SMTP id r68so4989840wmr.0 for ; Fri, 10 Nov 2017 00:37:52 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=gB3jqghxM9B77Z7h9+jiNPAuA0oFGLB43Dt/Tn3ix+M=; b=CMhWF7nIa57h4rS0sj4J4wqF/3hQow+r+Y/rYSk4OV0+BVAY4+TISKvJuXtloDJ7SQ JwtZdR8BV7JbEwx06UM0uVOIPrrI+HdYz1bxfS5fdPpUygerjAeGTtFQEmg3T6Sii9zS iuNCL5m2h5GA3XZbV79nZUSJyTdc+rK034oe0= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=gB3jqghxM9B77Z7h9+jiNPAuA0oFGLB43Dt/Tn3ix+M=; b=uldUTeyZBtgpqHjfihohj1nvFoQfylKsTvBLStwZDH1DMdSN4b67Bqi7Y8ihIhDvwQ MMDMwnMpjYIUJdyAD+3UjnCYxr+5pvjuJmNKWCxbeU3RScYESdkX5BFTQShV+tzriOfr iPjW7WGyK9ySoaHu3n5eLfHMv3XhPqpYiv/vqMI5Nb9W7wkd/MTXtghUuNeTSZxSKFFM V1W4DyESe21LZBU9ykcXf6vp+GKqK6EyaRwqs6+phRVAUUNrO64A8M7RddLWc9pImtsa YrAegTUkqQGhz8rbcW3rrbGr7RAHt34T3oaCUKk4xfgdUttUwFOq7s15X3LRru4IKgHr yCCg== X-Gm-Message-State: AJaThX5PzLLJW+mXO0HyYv0Y5ylb0/iA5HZUgtq20elCVbsLoaUs0RxB pAm0yuXb53slhmRoA+ku1RANWA== X-Google-Smtp-Source: AGs4zMZtmjkaIihkTlbIWwmdXYG2+PkmVxvNb7RHrqMSH7KXagQGfW7+2r6EuActpr/fWIZ96hYOlw== X-Received: by 10.28.99.139 with SMTP id x133mr491311wmb.122.1510303070897; Fri, 10 Nov 2017 00:37:50 -0800 (PST) Received: from localhost (xd93dd96b.cust.hiper.dk. [217.61.217.107]) by smtp.gmail.com with ESMTPSA id o82sm253166wmo.18.2017.11.10.00.37.49 (version=TLS1_2 cipher=AES128-SHA bits=128/128); Fri, 10 Nov 2017 00:37:49 -0800 (PST) Date: Fri, 10 Nov 2017 09:37:55 +0100 From: Christoffer Dall To: Marc Zyngier Subject: Re: [PATCH v5 16/26] KVM: arm/arm64: GICv4: Propagate property updates to VLPIs Message-ID: <20171110083755.GI14144@cbox> References: <20171027142855.21584-1-marc.zyngier@arm.com> <20171027142855.21584-17-marc.zyngier@arm.com> <6763d90f-93bf-ddbb-d456-5979b8870aa2@redhat.com> <49bff080-0908-cc7a-7036-543f963180a5@arm.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <49bff080-0908-cc7a-7036-543f963180a5@arm.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20171110_003812_764115_44071E5D X-CRM114-Status: GOOD ( 18.80 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , kvm@vger.kernel.org, Andre Przywara , linux-kernel@vger.kernel.org, Shameerali Kolothum Thodi , Auger Eric , Shanker Donthineni , Christoffer Dall , kvmarm@lists.cs.columbia.edu, linux-arm-kernel@lists.infradead.org Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org X-Virus-Scanned: ClamAV using ClamSMTP On Wed, Nov 08, 2017 at 03:08:36PM +0000, Marc Zyngier wrote: > On 07/11/17 21:28, Auger Eric wrote: > > Hi Marc, > > > > On 27/10/2017 16:28, Marc Zyngier wrote: > >> Upon updating a property, we propagate it all the way to the physical > >> ITS, and ask for an INV command to be executed there. > >> > >> Acked-by: Christoffer Dall > >> Signed-off-by: Marc Zyngier > >> --- > >> virt/kvm/arm/vgic/vgic-its.c | 3 +++ > >> 1 file changed, 3 insertions(+) > >> > >> diff --git a/virt/kvm/arm/vgic/vgic-its.c b/virt/kvm/arm/vgic/vgic-its.c > >> index 0b7e648e7a0c..2e77c7c83942 100644 > >> --- a/virt/kvm/arm/vgic/vgic-its.c > >> +++ b/virt/kvm/arm/vgic/vgic-its.c > >> @@ -296,6 +296,9 @@ static int update_lpi_config(struct kvm *kvm, struct vgic_irq *irq, > >> spin_unlock(&irq->irq_lock); > >> } > >> > >> + if (irq->hw) > >> + return its_prop_update_vlpi(irq->host_irq, prop, true); > >> + > >> return 0; > >> } > > I am confused by the vgic_queue_irq_unlock() on the "hw" path. Why is it > > needed in hw mode? > > It's not. I guess we could bypass this altogether and take a short cut > after having updated the priority and enabled fields. > I can apply this on top of the series as well if you're happy with it: commit b54fba93b1330803a59ca75f3a5102e22cadc871 (HEAD -> next-gicv4) Author: Christoffer Dall Date: Fri Nov 10 09:34:54 2017 +0100 KVM: arm/arm64: Don't queue VLPIs on INV/INVALL Since VLPIs are injected directly by the hardware there's no need to mark these as pending in software and queue them on the AP list. Signed-off-by: Christoffer Dall Thanks, -Christoffer Reviewed-by: Marc Zyngier diff --git a/virt/kvm/arm/vgic/vgic-its.c b/virt/kvm/arm/vgic/vgic-its.c index c93ecd4a903b..a3754ec719c4 100644 --- a/virt/kvm/arm/vgic/vgic-its.c +++ b/virt/kvm/arm/vgic/vgic-its.c @@ -292,11 +292,14 @@ static int update_lpi_config(struct kvm *kvm, struct vgic_irq *irq, irq->priority = LPI_PROP_PRIORITY(prop); irq->enabled = LPI_PROP_ENABLE_BIT(prop); - vgic_queue_irq_unlock(kvm, irq, flags); - } else { - spin_unlock_irqrestore(&irq->irq_lock, flags); + if (!irq->hw) { + vgic_queue_irq_unlock(kvm, irq, flags); + return 0; + } } + spin_unlock_irqrestore(&irq->irq_lock, flags); + if (irq->hw) return its_prop_update_vlpi(irq->host_irq, prop, needs_inv);