From patchwork Sat Nov 18 13:37:32 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Thomas Meyer X-Patchwork-Id: 10064815 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 3D0BC602B8 for ; Sat, 18 Nov 2017 13:38:19 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 21F2429924 for ; Sat, 18 Nov 2017 13:38:19 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 14CAA29C0E; Sat, 18 Nov 2017 13:38:19 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.2 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,RCVD_IN_DNSWL_MED autolearn=ham version=3.3.1 Received: from bombadil.infradead.org (bombadil.infradead.org [65.50.211.133]) (using TLSv1.2 with cipher AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 5E2F429924 for ; Sat, 18 Nov 2017 13:38:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-ID:Subject:To:From :Date:Reply-To:Cc:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References: List-Owner; bh=O5CMYNXzdRS4qgjHRJpg2x53YrHDet4EvaKUPBJHVNU=; b=RgTyEU1lkaxmTn UAGhGHXdWipgbK7/RPVYtLdJJ/7hEXT2DU8NupmZ+DHYYAUF79Q6uT4D69tXfCu8JDhHI2ZyB27lz OePQNbkTRib4R1SoztY/IBaz7onLRTsxoL10xs2bCrCE4TR43wjxkZv+gc+lxqCdbK6zy/rTyCho/ iQ0uyMg0+ZIFvccJvmEWk7kxG5HW1pg6Ytzi3MfyOcpNMP7/6W7CentQ92lYyGDU57caAddhuxQ/w MEY6okTufU68/5pLK/1DFWYVp+s/Ci9MTN/WpufSOKbnaE1M6qFYLPemmtdQs4EXoym10hKRCFv9k bkOblHEIEBjCgzdprcAQ==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.87 #1 (Red Hat Linux)) id 1eG3Jp-0004ZU-E9; Sat, 18 Nov 2017 13:38:01 +0000 Received: from www17.your-server.de ([213.133.104.17]) by bombadil.infradead.org with esmtps (Exim 4.87 #1 (Red Hat Linux)) id 1eG3Jk-0004Xz-Kz for linux-arm-kernel@lists.infradead.org; Sat, 18 Nov 2017 13:37:59 +0000 Received: from [95.222.27.41] (helo=olymp) by www17.your-server.de with esmtpsa (TLSv1.2:DHE-RSA-AES256-GCM-SHA384:256) (Exim 4.85_2) (envelope-from ) id 1eG3JH-0001MY-Hj for linux-arm-kernel@lists.infradead.org; Sat, 18 Nov 2017 14:37:27 +0100 Date: Sat, 18 Nov 2017 14:37:32 +0100 From: Thomas Meyer To: linux-arm-kernel@lists.infradead.org Subject: Relevant for 3.18.x? Message-ID: <20171118133732.mimo2u6vubut34ql@olymp> MIME-Version: 1.0 Content-Disposition: inline User-Agent: NeoMutt/20170113 (1.7.2) X-Authenticated-Sender: thomas@m3y3r.de X-Virus-Scanned: Clear (ClamAV 0.99.2/24051/Sat Nov 18 10:07:23 2017) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20171118_053756_858769_D66A8699 X-CRM114-Status: GOOD ( 10.53 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org X-Virus-Scanned: ClamAV using ClamSMTP Hi, I played around a bit with the source code of the linux version running on my phone and I stumbled upon this patch and I wanted to ask if this patch is maybe also relevant for linux-stable 3.18.x? commit 6a5e04b6af54fdea2a8b5815f18632d74da471b2 Author: Stepan Moskovchenko Date: Wed May 14 16:51:06 2014 -0700 arm64: Call EDAC error handler on system error One possible cause of a system error exception is an ECC error in the CPU's caches. Call the ARM64 EDAC error handler from the system error exception handler to print EDAC error syndrome information to the kernel log. Change-Id: If8757eda0c7fc82b0fccee573cf09627a752fdf3 Signed-off-by: Stepan Moskovchenko And I just realized while writing this email that master and stable-3.18 seem to completely miss the cortex EDAC driver: https://source.codeaurora.org/quic/la/kernel/msm/log/drivers/edac/cortex_arm64_edac.c?h=aosp-new/android-msm-marlin-3.18-oreo so never mind. with kind regards thomas diff --git a/arch/arm64/kernel/traps.c b/arch/arm64/kernel/traps.c index 605f8249325d..ec0d4b22e91e 100644 --- a/arch/arm64/kernel/traps.c +++ b/arch/arm64/kernel/traps.c @@ -37,6 +37,8 @@ #include #include #include +#include +#include #include @@ -442,6 +444,12 @@ asmlinkage void bad_mode(struct pt_regs *regs, int reason, unsigned int esr) info.si_code = ILL_ILLOPC; info.si_addr = pc; + if (esr >> ESR_EL1_EC_SHIFT == ESR_EL1_EC_SERROR) { + pr_crit("System error detected. ESR.ISS = %08x\n", + esr & 0xffffff); + arm64_check_cache_ecc(NULL); + } + arm64_notify_die("Oops - bad mode", regs, &info, 0); }