| Message ID | 20171120172629.24006-1-mark.rutland@arm.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Mon, Nov 20, 2017 at 05:26:29PM +0000, Mark Rutland wrote: > Since commit: > > 155433cb365ee466 ("arm64: cache: Remove support for ASID-tagged VIVT I-caches") > > ... the ASID rollover code no longer performs I-cache maintenance, yet a > leftover comment says it does. The comment doesn't say anything that > can't be inferred from the next line, so let's remove it entirely. > > Signed-off-by: Mark Rutland <mark.rutland@arm.com> > Cc: Catalin Marinas <catalin.marinas@arm.com> > Cc: Will Deacon <will.deacon@arm.com> > --- > arch/arm64/mm/context.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/arch/arm64/mm/context.c b/arch/arm64/mm/context.c > index ab9f5f0fb2c7..b48ec1e18184 100644 > --- a/arch/arm64/mm/context.c > +++ b/arch/arm64/mm/context.c > @@ -117,7 +117,6 @@ static void flush_context(unsigned int cpu) > per_cpu(reserved_asids, i) = asid; > } > > - /* Queue a TLB invalidate and flush the I-cache if necessary. */ > cpumask_setall(&tlb_flush_pending); Given that we don't normally do TLB invalidation by setting a flag, I'd be inclined to say something like /* * Queue a TLB invalidation for each CPU to perform on next * context-switch. */ Also, if you're bored, there's a comment in asm/cacheflush.h talking about ASID-tagged I-cache too. Will
diff --git a/arch/arm64/mm/context.c b/arch/arm64/mm/context.c index ab9f5f0fb2c7..b48ec1e18184 100644 --- a/arch/arm64/mm/context.c +++ b/arch/arm64/mm/context.c @@ -117,7 +117,6 @@ static void flush_context(unsigned int cpu) per_cpu(reserved_asids, i) = asid; } - /* Queue a TLB invalidate and flush the I-cache if necessary. */ cpumask_setall(&tlb_flush_pending); }
Since commit: 155433cb365ee466 ("arm64: cache: Remove support for ASID-tagged VIVT I-caches") ... the ASID rollover code no longer performs I-cache maintenance, yet a leftover comment says it does. The comment doesn't say anything that can't be inferred from the next line, so let's remove it entirely. Signed-off-by: Mark Rutland <mark.rutland@arm.com> Cc: Catalin Marinas <catalin.marinas@arm.com> Cc: Will Deacon <will.deacon@arm.com> --- arch/arm64/mm/context.c | 1 - 1 file changed, 1 deletion(-)