From patchwork Tue Dec 5 12:47:07 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Alexandre Belloni X-Patchwork-Id: 10092871 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id E535D60329 for ; Tue, 5 Dec 2017 12:47:44 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id D0D18287FA for ; Tue, 5 Dec 2017 12:47:44 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id C497A28CE6; Tue, 5 Dec 2017 12:47:44 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.2 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,RCVD_IN_DNSWL_MED autolearn=unavailable version=3.3.1 Received: from bombadil.infradead.org (bombadil.infradead.org [65.50.211.133]) (using TLSv1.2 with cipher AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 5E561287FA for ; Tue, 5 Dec 2017 12:47:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=G01G23QVGoiGyB8jFGxX+VF8kOryCQrLDQ+cviSzJfc=; b=SEPWnD1T3DRtdD ngZ3K7cAD5yWA3CyOf4Fqt/OYmsCkf2TEXi3vRI2OaoiaVcBY0NDw9D+P5F+YwnPjbhijd7meNps3 t7dFiFbvH8vUlO/asyQTQQ1SCaoc8SOQ7VALp/lyVibrvD54xIWhqMF8Ac7RMMu5W/15vKJAUlwsu sruWQ4hJuWJac3IXyiiCg4i/gXyzy9SaZdc7zwzJ2VSBId/v0EhUuBhFjLNpMia+TC5mQxAa9Zws9 +sar9fuR10Q+q9CFScueDfQEhdQ6FyknveN8c0BknyEnoMOdWWWdcviRRhGAyHJV2tIrMBz5GvY5h G1vELWwzZk1F7GMUiZhg==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.87 #1 (Red Hat Linux)) id 1eMCdS-0004RE-8X; Tue, 05 Dec 2017 12:47:42 +0000 Received: from mail.free-electrons.com ([62.4.15.54]) by bombadil.infradead.org with esmtp (Exim 4.87 #1 (Red Hat Linux)) id 1eMCdP-0004Pu-1M for linux-arm-kernel@lists.infradead.org; Tue, 05 Dec 2017 12:47:41 +0000 Received: by mail.free-electrons.com (Postfix, from userid 110) id 376B020741; Tue, 5 Dec 2017 13:47:17 +0100 (CET) Received: from localhost (unknown [88.191.26.124]) by mail.free-electrons.com (Postfix) with ESMTPSA id 0D8A42036E; Tue, 5 Dec 2017 13:47:07 +0100 (CET) Date: Tue, 5 Dec 2017 13:47:07 +0100 From: Alexandre Belloni To: Arnd Bergmann Subject: Re: [PATCH] ASoC: atmel-classd: select correct Kconfig symbol Message-ID: <20171205124707.GJ21780@piout.net> References: <20171205101000.968887-1-arnd@arndb.de> <20171205105750.GI21780@piout.net> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.9.1 (2017-09-22) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20171205_044739_397245_0E2FDC6A X-CRM114-Status: GOOD ( 21.72 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: alsa-devel@alsa-project.org, Liam Girdwood , Linux Kernel Mailing List , Takashi Iwai , Jaroslav Kysela , Mark Brown , Linux ARM Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org X-Virus-Scanned: ClamAV using ClamSMTP On 05/12/2017 at 12:13:41 +0100, Arnd Bergmann wrote: > On Tue, Dec 5, 2017 at 11:57 AM, Alexandre Belloni > wrote: > > On 05/12/2017 at 11:09:38 +0100, Arnd Bergmann wrote: > >> Commit 061981ff8cc8 ("ASoC: atmel: properly select dma driver state") > >> changed the way that the dependencies are handled, but then the > >> Class D amplifier support got merged, which used the old method. > >> > >> This seems to have triggered a very rare randconfig condition for me > >> now, leading to a link error: > >> > >> sound/soc/atmel/atmel_ssc_dai.o: In function `atmel_ssc_set_audio': > >> atmel_ssc_dai.c:(.text+0x79c): undefined reference to `atmel_pcm_dma_platform_register' > >> atmel_ssc_dai.c:(.text+0x79c): relocation truncated to fit: R_AARCH64_CALL26 against undefined symbol `atmel_pcm_dma_platform_register' > >> sound/soc/atmel/atmel_ssc_dai.o: In function `atmel_ssc_put_audio': > >> atmel_ssc_dai.c:(.text+0xf24): undefined reference to `atmel_pcm_dma_platform_unregister' > >> atmel_ssc_dai.c:(.text+0xf24): relocation truncated to fit: R_AARCH64_CALL26 against undefined symbol `atmel_pcm_dma_platform_unregister' > >> > >> Changing it to select SND_ATMEL_SOC_SSC_DMA as intended rather than > >> SND_ATMEL_SOC_DMA directly makes it work again. > >> > >> Fixes: e0a25b6d1862 ("ASoC: atmel-classd: add the Audio Class D Amplifier") > >> Signed-off-by: Arnd Bergmann > > Acked-by: Alexandre Belloni > > Unfortunately, my testing just found a new problem with this patch > applied, I had > not run enough randconfig tests on top of it: > > sound/soc/atmel/atmel_ssc_dai.o: In function `atmel_ssc_set_audio': > atmel_ssc_dai.c:(.text+0x73c): undefined reference to `ssc_request' > sound/soc/atmel/atmel_ssc_dai.o: In function `atmel_ssc_put_audio': > atmel_ssc_dai.c:(.text+0x7be): undefined reference to `ssc_free' > > This is for a configuration with SND_ATMEL_SOC_CLASSD=y > and CONFIG_ATMEL_SSC=n. Could you tell me whether that is a > sensible configuration that should work, or whether we need a dependency > on ATMEL_SSC in SND_ATMEL_SOC_CLASSD? I can't really tell > from the source code, but you probably know the answer. > Ok, does that solve both randconfigs? Tested-by: Arnd Bergmann diff --git a/sound/soc/atmel/Kconfig b/sound/soc/atmel/Kconfig index 4a56f3dfba51..dcee145dd179 100644 --- a/sound/soc/atmel/Kconfig +++ b/sound/soc/atmel/Kconfig @@ -64,7 +64,7 @@ config SND_AT91_SOC_SAM9X5_WM8731 config SND_ATMEL_SOC_CLASSD tristate "Atmel ASoC driver for boards using CLASSD" depends on ARCH_AT91 || COMPILE_TEST - select SND_ATMEL_SOC_DMA + select SND_SOC_GENERIC_DMAENGINE_PCM select REGMAP_MMIO help Say Y if you want to add support for Atmel ASoC driver for boards using