From patchwork Thu Dec 7 14:27:13 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jerome Brunet X-Patchwork-Id: 10099313 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 4531760325 for ; Thu, 7 Dec 2017 14:30:25 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 37FE22A423 for ; Thu, 7 Dec 2017 14:30:25 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 2C8ED2A42D; Thu, 7 Dec 2017 14:30:25 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.2 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,RCVD_IN_DNSWL_MED autolearn=ham version=3.3.1 Received: from bombadil.infradead.org (bombadil.infradead.org [65.50.211.133]) (using TLSv1.2 with cipher AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id BD9BB2A423 for ; Thu, 7 Dec 2017 14:30:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:MIME-Version:Cc:List-Subscribe: List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id:References: In-Reply-To:Message-Id:Date:Subject:To:From:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Owner; bh=SftAyDJD6CnLDLHsHZYpLEGc7awMF2toA3o/mSR0esM=; b=cxrdPFxrFaABNLY4aqvpeb4buV oMZtWOinRiJug11GgL5XhhTYWzuDpWhk1NVhRmBO4xroFqdQ2RnlvUhgLjtFzloX2VxUKXWOlYrju rOR1nuOSANVBuYi6n4+BzOhx9wXuk3KEecpNd5wcHBk0mprQcIC8V3/lGRDY3rzBvcKixZInqJWqz WrQWrUDxFagITuGqAQK1t/e9JopehduCFcfMynxtfbTc6ceZvnb5KXy8TNyzXG4GZ6+TuMcQ+g/2Q 1U+X2oA5e9eQoZTPnk8+HiebfmRxMsexq0H2EXGPbVUmS0RBrTSd1BMzuVAzyuoTffaD5AMYej/6M FZ5J/eHQ==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.87 #1 (Red Hat Linux)) id 1eMxBw-0008IL-6W; Thu, 07 Dec 2017 14:30:24 +0000 Received: from mail-wm0-x243.google.com ([2a00:1450:400c:c09::243]) by bombadil.infradead.org with esmtps (Exim 4.87 #1 (Red Hat Linux)) id 1eMx9O-0004mr-4v for linux-arm-kernel@lists.infradead.org; Thu, 07 Dec 2017 14:28:06 +0000 Received: by mail-wm0-x243.google.com with SMTP id y82so879696wmg.1 for ; Thu, 07 Dec 2017 06:27:25 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=k41/HapxpcUteShWzrcLk6o1is4mUHfA9p2+aRvDPxA=; b=F1SFKqpYxgHELHqUkO6OMmL9IvNfp1jGFCizUHPhmHvV3DNsT4IgsSHa46qT0fqpSS /U1GgZ+L7JZwnWnGVEwt1QNqBB6EuSkoCaXpAUdgXMdSH+vgXgavS+HQPwNJtY3Q4KIn ig2hheIi9jmbps4DXJYRynGNPZMFRJhXt3lyFaBou4CCFQY7cH0idravIz93t+GfHe3b niEl+LydNTA3EFGfEG7OUAMNvx4liSJfC1g+PnCLHVEKllrwbENFka59x/98pPiy6vlm c6neTaJbKk0+967tpnjJ0WI/MwwNQv5jDDMlEQY0yjSez8OJMx7bR9qMdI8cyusj24I7 GjYw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=k41/HapxpcUteShWzrcLk6o1is4mUHfA9p2+aRvDPxA=; b=JUROm9m+qQvfk4nBZRSXYieo7+6xl6zOhFmFq6RTIM33vlXAgry6lhB6MoHir8bgh1 q74q0ZEeA5G5+vVhgBFk0BZzfD3NVzJIThl6eqzAqYPjNzlFFVbGseekUcdSDplf5Za6 b3MqSbkf8TV1DnzPYA753tdIHa2UgpONa4pNxlqZnH1cxte5+SupuqWv5JS4pYbr1bua kgKmh3rS6CZbLCsW/LboX7zvKM90Scc9cs0RxCoehiTsguxiviQszVOgD0etyFFoHdNw 6fHOyMzCRH/qhQtNliw7iYvVvRae92Y7u957Q0KVHxokq2bXV/wi7ElKKdPOd9R2cxt7 eZpw== X-Gm-Message-State: AKGB3mJEGnFyicxBcGEbIxj5RZSAjirZ93o6ZeZAGIik18f5U6aMrPcv UH6/sOCxv4TkDW/fFfpxPvUT9g== X-Google-Smtp-Source: AGs4zMZvAaEjgWrbC4tBShR6Gv8q7jb1BA/iIEwcLAwzLpWibfDxqQyC/LS6EeP8+PwDAVO1AEfx6g== X-Received: by 10.28.110.26 with SMTP id j26mr1289069wmc.46.1512656844203; Thu, 07 Dec 2017 06:27:24 -0800 (PST) Received: from boomer.baylibre.local ([90.63.244.31]) by smtp.googlemail.com with ESMTPSA id t138sm6264520wme.16.2017.12.07.06.27.23 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 07 Dec 2017 06:27:23 -0800 (PST) From: Jerome Brunet To: Andrew Lunn , Florian Fainelli Subject: [PATCH net-next v2 6/8] net: phy: meson-gxl: leave CONFIG_A6 untouched Date: Thu, 7 Dec 2017 15:27:13 +0100 Message-Id: <20171207142715.32578-7-jbrunet@baylibre.com> X-Mailer: git-send-email 2.14.3 In-Reply-To: <20171207142715.32578-1-jbrunet@baylibre.com> References: <20171207142715.32578-1-jbrunet@baylibre.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20171207_062747_302710_DA064526 X-CRM114-Status: GOOD ( 13.20 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Kevin Hilman , linux-kernel@vger.kernel.org, netdev@vger.kernel.org, linux-amlogic@lists.infradead.org, linux-arm-kernel@lists.infradead.org, Jerome Brunet MIME-Version: 1.0 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org X-Virus-Scanned: ClamAV using ClamSMTP The PHY performs just as well when left in its default configuration and it makes senses because this poke gets reset just after init. According to the documentation, all registers in the Analog/DSP bank are reset when there is a mode switch from 10BT to 100BT. In the end, we have used the default configuration so far and there is no reason to change now. Remove CONFIG_A6 poke to make this clear. Signed-off-by: Jerome Brunet Reviewed-by: Andrew Lunn --- Out of curiosity, I tried to re-apply the ANALOG/DSP settings on speed changes (patch available here [0] if someone wants to try) but I did not notice any change as a result. In the end, I thought it was safer to keep on using the ANALOG settings we have been actually using so far, everybody seems to be happy with them [0]: https://github.com/jeromebrunet/linux/commit/b594288e629a61574e76112497474fd3cf46c781 drivers/net/phy/meson-gxl.c | 9 --------- 1 file changed, 9 deletions(-) diff --git a/drivers/net/phy/meson-gxl.c b/drivers/net/phy/meson-gxl.c index 726e0eeed475..5325940fe899 100644 --- a/drivers/net/phy/meson-gxl.c +++ b/drivers/net/phy/meson-gxl.c @@ -38,9 +38,6 @@ #define BANK_WOL 1 #define BANK_BIST 3 -/* Analog/DSP Registers */ -#define A6_CONFIG_REG 0x17 - /* WOL Registers */ #define LPI_STATUS 0xc #define LPI_STATUS_RSV12 BIT(12) @@ -126,12 +123,6 @@ static int meson_gxl_config_init(struct phy_device *phydev) { int ret; - /* Write CONFIG_A6*/ - ret = meson_gxl_write_reg(phydev, BANK_ANALOG_DSP, A6_CONFIG_REG, - 0x8e0d); - if (ret) - return ret; - /* Enable fractional PLL */ ret = meson_gxl_write_reg(phydev, BANK_BIST, FR_PLL_CONTROL, 0x5); if (ret)