From patchwork Wed Dec 13 10:45:54 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Christoffer Dall X-Patchwork-Id: 10109701 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 38E1460327 for ; Wed, 13 Dec 2017 10:47:25 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 2A4A028E74 for ; Wed, 13 Dec 2017 10:47:25 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 1F25528F0E; Wed, 13 Dec 2017 10:47:25 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.2 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,RCVD_IN_DNSWL_MED autolearn=ham version=3.3.1 Received: from bombadil.infradead.org (bombadil.infradead.org [65.50.211.133]) (using TLSv1.2 with cipher AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id AE07B28E74 for ; Wed, 13 Dec 2017 10:47:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:MIME-Version:Cc:List-Subscribe: List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id:References: In-Reply-To:Message-Id:Date:Subject:To:From:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Owner; bh=NMLUXmcI/Wk3IXHUQyDv6mTU+iADKdp2UpLx08OM784=; b=mFRJvRCro+zAdYoa9o8ft5odhG coaep3o7xWWWXqifRi0Gq+w6ReuoXxtxSA8yhKMd9StqxJryp/YnUobt/UZxBL66LMmsgPnFHVbDh 0bUEbnyOIQdLwvGpIAAC5E0gCzqPqo3SUE1nkQk8bX6x+rzn7Yrhu7rExIZtKvf2CkKZi8RglYaqS 2rBLlA3gKD/8XDX+4Gwbyg2BD+mBR6r9tIs2XhwCOKX8sE6haZbJ2EjxH/On5CjdbEs+TUbzGQgzj 9LxLTDD9M6CemO65xKRhByybe6XxUfOgrEJSwmj0I7z1MuDIq/Sbod5mzpYLucSKeBKbOpQJJXrqX GmdJijyg==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.87 #1 (Red Hat Linux)) id 1eP4ZQ-00019t-A0; Wed, 13 Dec 2017 10:47:24 +0000 Received: from mail-wm0-x241.google.com ([2a00:1450:400c:c09::241]) by bombadil.infradead.org with esmtps (Exim 4.87 #1 (Red Hat Linux)) id 1eP4Yz-0000mu-61 for linux-arm-kernel@lists.infradead.org; Wed, 13 Dec 2017 10:47:00 +0000 Received: by mail-wm0-x241.google.com with SMTP id i11so4109040wmf.4 for ; Wed, 13 Dec 2017 02:46:37 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=V30RIWG3ERL0oaJ6phxWU/FcR81NbE7IwlusRmQN3So=; b=A6vFibH3H0ELZokkEWuAyg1XAUFK93PIrziC4GrsGaiIyO2Z303OWskNBLqF5trYZk KVtAYcnHUmyvZMl/sqmicwBKicQ2tzx6DlAv/eOmhi1Mk4dTXDIPU0PT4WtycZrjh4Ix ovSmx/k7Km1X9lE64Ku/18XgSv9pjcEimxoP0= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=V30RIWG3ERL0oaJ6phxWU/FcR81NbE7IwlusRmQN3So=; b=m0ySMDtz2RJwr9go0IRlMCQthM731xatcAi6s37DWPQLfRbQ9qcTRHv6Ef6H9maCh+ M7gB0Ms6rECskNIFUNN/160WxeI85lDcsdj+LQCPWfjVFGBOokSgHP0HUn29v0hlTm6R 2QGHteeyFLfcKc1WXuhdFk4IoOKuuyZvpMW70Q7e/oGEhb4g5AN1Tu7J+SoaTQpgbHvh loM8ydRxVoaAqu73bTFWnwRFRdU8lGHW2E9BB6ScAkJjYzyfH56t97RGKRKUZ+tX7FeX sR+kmKXhCkPf/+dgt5gyV2+DMZjqCpqzB4xFhdeIh8YemClvTNeHWZ8PJLy+crx+lxBM LaOQ== X-Gm-Message-State: AKGB3mKHzq22kHR40kIkQJJDwPKu/exiJiZGgKSpArEaxoGIc6It6VZH i0Ji3AgHVyEVU3/vqnXjgTIUtw== X-Google-Smtp-Source: ACJfBovayxTYZ6tsBlqhjUUSWqdf3MBL26G7q12xesAolrulEN9ZAlcNxG2PX5bDWpnsUMojTgjQuA== X-Received: by 10.80.176.194 with SMTP id j60mr7190765edd.254.1513161995836; Wed, 13 Dec 2017 02:46:35 -0800 (PST) Received: from localhost.localdomain (x50d2404e.cust.hiper.dk. [80.210.64.78]) by smtp.gmail.com with ESMTPSA id d92sm1079682edd.21.2017.12.13.02.46.34 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Wed, 13 Dec 2017 02:46:34 -0800 (PST) From: Christoffer Dall To: kvmarm@lists.cs.columbia.edu, linux-arm-kernel@lists.infradead.org Subject: [PATCH v8 1/9] KVM: arm/arm64: Remove redundant preemptible checks Date: Wed, 13 Dec 2017 11:45:54 +0100 Message-Id: <20171213104602.16383-2-christoffer.dall@linaro.org> X-Mailer: git-send-email 2.14.2 In-Reply-To: <20171213104602.16383-1-christoffer.dall@linaro.org> References: <20171213104602.16383-1-christoffer.dall@linaro.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20171213_024657_382731_69DDFBD8 X-CRM114-Status: GOOD ( 11.05 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Marc Zyngier , Andre Przywara , Christoffer Dall , kvm@vger.kernel.org, Eric Auger MIME-Version: 1.0 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org X-Virus-Scanned: ClamAV using ClamSMTP The __this_cpu_read() and __this_cpu_write() functions already implement checks for the required preemption levels when using CONFIG_DEBUG_PREEMPT which gives you nice error messages and such. Therefore there is no need to explicitly check this using a BUG_ON() in the code (which we don't do for other uses of per cpu variables either). Acked-by: Marc Zyngier Reviewed-by: Andre Przywara Signed-off-by: Christoffer Dall --- virt/kvm/arm/arm.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/virt/kvm/arm/arm.c b/virt/kvm/arm/arm.c index a6524ff27de4..859ff7e3a1eb 100644 --- a/virt/kvm/arm/arm.c +++ b/virt/kvm/arm/arm.c @@ -71,7 +71,6 @@ static DEFINE_PER_CPU(unsigned char, kvm_arm_hardware_enabled); static void kvm_arm_set_running_vcpu(struct kvm_vcpu *vcpu) { - BUG_ON(preemptible()); __this_cpu_write(kvm_arm_running_vcpu, vcpu); } @@ -81,7 +80,6 @@ static void kvm_arm_set_running_vcpu(struct kvm_vcpu *vcpu) */ struct kvm_vcpu *kvm_arm_get_running_vcpu(void) { - BUG_ON(preemptible()); return __this_cpu_read(kvm_arm_running_vcpu); }