From patchwork Mon Dec 18 09:44:44 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jerome Brunet X-Patchwork-Id: 10118667 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 3EE97603FA for ; Mon, 18 Dec 2017 09:48:34 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 2E8F928DC5 for ; Mon, 18 Dec 2017 09:48:34 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 231FD28E3C; Mon, 18 Dec 2017 09:48:34 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.2 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,RCVD_IN_DNSWL_MED autolearn=ham version=3.3.1 Received: from bombadil.infradead.org (bombadil.infradead.org [65.50.211.133]) (using TLSv1.2 with cipher AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 97A9528DC5 for ; Mon, 18 Dec 2017 09:48:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:MIME-Version:Cc:List-Subscribe: List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id:References: In-Reply-To:Message-Id:Date:Subject:To:From:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Owner; bh=gi15EjlHrltclkJM4fjKyhwzPpFBxxMFvhOp8jBqfDQ=; b=U5V85dhMbyG/mhfRrPjuRo00x1 1wJKvDGe4haFiMe43u8hD9hLaKq/XrP5QiU3KEnNPdnNp8HKvzjFNIKH1p85Tj7CeHLb91vi9Jiil 6n7hiWtSwRBo7bZDKqHk7UUOJjV4J0gROp1u47Yfa2ZvwTpuvhVulOc81eg4wohjaY7IMr6LXmNkf tk1ppE7ev39NNK0l4/iBsEl6sFMkDruU4k2ioGXOSjTdTqpuAHHvEnu8xqolPHq+q0zM7/VyFJiaf j9fgTihpgEEdyEvvsxfDc71BSPFN9/LVU2owOh74VL/cQQcVcQft9EEPi5KYnQdRpFMALPYSAhQjf dsV442dQ==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.87 #1 (Red Hat Linux)) id 1eQs2C-0000Ai-Mn; Mon, 18 Dec 2017 09:48:32 +0000 Received: from mail-wr0-x241.google.com ([2a00:1450:400c:c0c::241]) by bombadil.infradead.org with esmtps (Exim 4.87 #1 (Red Hat Linux)) id 1eQrz5-0004fk-8C for linux-arm-kernel@lists.infradead.org; Mon, 18 Dec 2017 09:45:35 +0000 Received: by mail-wr0-x241.google.com with SMTP id y21so13450012wrc.1 for ; Mon, 18 Dec 2017 01:44:58 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=GtweTir+f4z1Z60UugjOzgbytYOQ0oWOM6id0Zorle4=; b=lxdsCVMEffPtjoOttRVGck53LkylDmhwDfEidspO/9Tb24brdxUygbrHSodr6ISDvO 1i7CcWKb3F1AgTf4gIWFKrwKQ28kKXNMzREFuTNtqeMgJZfPFUkaH0PXMdGJMUrgbVIF eyGGHKjeL4KKZ2GtesFIN91QsYf44V5QUWRzSadF0HEX/YIrQSRM0U6SUg9GZI7MxIAB YkXx5cvegmfnIlLkcSXQLH/XIh8Y68iyg2zjZa1yoofDjJQXZLyiSh72zQrP52NzB8aD DKdVupQW3FPBy9C9n7k+UsttceTOy/bRH8ORo+fRTEsMUlcCp5mPjvXwMItNNse6SIYm ty+w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=GtweTir+f4z1Z60UugjOzgbytYOQ0oWOM6id0Zorle4=; b=Qze02fwqKJtgvl0efnm+pHeCwro6t9+ma5Gy+d0NH4ZgBH1uISGngoioHa8xmVP54l gPcT9aGZJV4cRjngzmag6cfxvFZWNAeCX84q2oDNKmlJ+qLEJfvWNYJ8bMiEsHu50AH5 gfSxXYFAsxiFiUTS0fXmiRB/2A+n4w69YYaMd3Z9EfvCPS+4R1R0hI+9Lyv53HVTrIP0 zTMRqppXgKnRphfYoyCmnD/ZaXJSEjM7QJ2hO26sYY156c1LRiqmkh7Q7XWmu4E3Zw98 dRd6Ypfmn5IVVoCwzHfDAfESn8jBpwr525weN6tMybTWUiiMt3tEGCO/fcdYzd2xn6SM iXGA== X-Gm-Message-State: AKGB3mKb8mliMLRyuFqt8cNxbtSVPafGJzjBB6ofJtyyezvaVMGhv385 4G7rjy1c9TncxAGNmxS+1qVAGw== X-Google-Smtp-Source: ACJfBosNbfwFUFJF/FuhqsFCxgIKq0EFAI2efm/K2gteWk3KBHSk/F+icZXFpHXvtviBYVgp/uQ0kg== X-Received: by 10.223.136.56 with SMTP id d53mr5776814wrd.36.1513590297277; Mon, 18 Dec 2017 01:44:57 -0800 (PST) Received: from boomer.baylibre.local ([90.63.244.31]) by smtp.googlemail.com with ESMTPSA id p13sm12820783wrc.61.2017.12.18.01.44.56 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 18 Dec 2017 01:44:56 -0800 (PST) From: Jerome Brunet To: Andrew Lunn , Florian Fainelli Subject: [PATCH net-next v3 5/7] net: phy: meson-gxl: leave CONFIG_A6 untouched Date: Mon, 18 Dec 2017 10:44:44 +0100 Message-Id: <20171218094446.31912-6-jbrunet@baylibre.com> X-Mailer: git-send-email 2.14.3 In-Reply-To: <20171218094446.31912-1-jbrunet@baylibre.com> References: <20171218094446.31912-1-jbrunet@baylibre.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20171218_014519_873136_62E32BFC X-CRM114-Status: GOOD ( 10.40 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Kevin Hilman , linux-kernel@vger.kernel.org, netdev@vger.kernel.org, linux-amlogic@lists.infradead.org, linux-arm-kernel@lists.infradead.org, Jerome Brunet MIME-Version: 1.0 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org X-Virus-Scanned: ClamAV using ClamSMTP The PHY performs just as well when left in its default configuration and it makes senses because this poke gets reset just after init. According to the documentation, all registers in the Analog/DSP bank are reset when there is a mode switch from 10BT to 100BT. The bank is also reset on power down and soft reset, so we will never see the value which may have been set by the bootloader. In the end, we have used the default configuration so far and there is no reason to change now. Remove CONFIG_A6 poke to make this clear. Reviewed-by: Andrew Lunn Signed-off-by: Jerome Brunet --- drivers/net/phy/meson-gxl.c | 9 --------- 1 file changed, 9 deletions(-) diff --git a/drivers/net/phy/meson-gxl.c b/drivers/net/phy/meson-gxl.c index 0a34656a2086..ddc92424e8de 100644 --- a/drivers/net/phy/meson-gxl.c +++ b/drivers/net/phy/meson-gxl.c @@ -38,9 +38,6 @@ #define BANK_WOL 1 #define BANK_BIST 3 -/* Analog/DSP Registers */ -#define A6_CONFIG_REG 0x17 - /* WOL Registers */ #define LPI_STATUS 0xc #define LPI_STATUS_RSV12 BIT(12) @@ -126,12 +123,6 @@ static int meson_gxl_config_init(struct phy_device *phydev) { int ret; - /* Write CONFIG_A6*/ - ret = meson_gxl_write_reg(phydev, BANK_ANALOG_DSP, A6_CONFIG_REG, - 0x8e0d); - if (ret) - return ret; - /* Enable fractional PLL */ ret = meson_gxl_write_reg(phydev, BANK_BIST, FR_PLL_CONTROL, 0x5); if (ret)