| Message ID | 20171219210523.10428-1-kevans91@ksu.edu (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Tue, Dec 19, 2017 at 03:05:23PM -0600, kevans91@ksu.edu wrote: > Allwinner a83t has a 1 KB sid block with efuse for security rootkey and > thermal calibration data, add node to describe it. > > a83t-sid is not currently supported by nvmem/sunxi-sid, but it is > supported in an external driver for FreeBSD. > > Signed-off-by: Kyle Evans <kevans91@ksu.edu> > --- > > Changes in v2: > - remove bogus "From:" line in commit text; no functional change > > Documentation/devicetree/bindings/nvmem/allwinner,sunxi-sid.txt | 1 + > arch/arm/boot/dts/sun8i-a83t.dtsi | 5 +++++ > 2 files changed, 6 insertions(+) Reviewed-by: Rob Herring <robh@kernel.org>
Hi Kyle, On Tue, Dec 19, 2017 at 03:05:23PM -0600, kevans91@ksu.edu wrote: > Allwinner a83t has a 1 KB sid block with efuse for security rootkey and > thermal calibration data, add node to describe it. > > a83t-sid is not currently supported by nvmem/sunxi-sid, but it is > supported in an external driver for FreeBSD. > > Signed-off-by: Kyle Evans <kevans91@ksu.edu> The patch looks fine in itself, but we've had a number of issues with the register layout (and access patterns) in the past, so I'd rather have something that works in Linux too if possible. Maxime
在 2017年12月21日星期四 CST 下午10:55:12，Maxime Ripard 写道： > Hi Kyle, > > On Tue, Dec 19, 2017 at 03:05:23PM -0600, kevans91@ksu.edu wrote: > > Allwinner a83t has a 1 KB sid block with efuse for security rootkey and > > thermal calibration data, add node to describe it. > > > > a83t-sid is not currently supported by nvmem/sunxi-sid, but it is > > supported in an external driver for FreeBSD. > > > > Signed-off-by: Kyle Evans <kevans91@ksu.edu> > > The patch looks fine in itself, but we've had a number of issues with > the register layout (and access patterns) in the past, so I'd rather > have something that works in Linux too if possible. I think for A83T it can just refer H3. > > Maxime
On Thu, Dec 21, 2017 at 8:55 AM, Maxime Ripard <maxime.ripard@free-electrons.com> wrote: > Hi Kyle, > > On Tue, Dec 19, 2017 at 03:05:23PM -0600, kevans91@ksu.edu wrote: >> Allwinner a83t has a 1 KB sid block with efuse for security rootkey and >> thermal calibration data, add node to describe it. >> >> a83t-sid is not currently supported by nvmem/sunxi-sid, but it is >> supported in an external driver for FreeBSD. >> >> Signed-off-by: Kyle Evans <kevans91@ksu.edu> > > The patch looks fine in itself, but we've had a number of issues with > the register layout (and access patterns) in the past, so I'd rather > have something that works in Linux too if possible. Hello! I have a patch that I think should make it work fine on Linux [1], but I'm afraid I have little to no capability to test it myself and so I did not add it as well. I do know that the rootkey is offset 0x200 into the given space [2], as is the case with the H3, and that the readout quirk is not needed. I wasn't 100% sure that the a83t has 2Kbit worth of efuse space as the H3, but I do know that thermal data can be found at 0x34 and 0x38 in this space. [1] https://people.freebsd.org/~kevans/sunxi-sid.diff [2] https://svnweb.freebsd.org/base/head/sys/arm/allwinner/aw_sid.c?view=markup#l56
Hi, On Thu, Dec 21, 2017 at 09:19:24AM -0600, Kyle Evans wrote: > On Thu, Dec 21, 2017 at 8:55 AM, Maxime Ripard > <maxime.ripard@free-electrons.com> wrote: > > Hi Kyle, > > > > On Tue, Dec 19, 2017 at 03:05:23PM -0600, kevans91@ksu.edu wrote: > >> Allwinner a83t has a 1 KB sid block with efuse for security rootkey and > >> thermal calibration data, add node to describe it. > >> > >> a83t-sid is not currently supported by nvmem/sunxi-sid, but it is > >> supported in an external driver for FreeBSD. > >> > >> Signed-off-by: Kyle Evans <kevans91@ksu.edu> > > > > The patch looks fine in itself, but we've had a number of issues with > > the register layout (and access patterns) in the past, so I'd rather > > have something that works in Linux too if possible. > > I have a patch that I think should make it work fine on Linux [1], but > I'm afraid I have little to no capability to test it myself and so I > did not add it as well. > > I do know that the rootkey is offset 0x200 into the given space [2], > as is the case with the H3, and that the readout quirk is not needed. > I wasn't 100% sure that the a83t has 2Kbit worth of efuse space as the > H3, but I do know that thermal data can be found at 0x34 and 0x38 in > this space. Then maybe we should leave it aside until someone takes some time on the A83t. The good news is that the binding itself looks fine, so as far as FreeBSD goes, there shouldn't be anything preventing you from using it I guess. Chen-Yu, what do you think? Thanks! Maxime
On Thu, Dec 21, 2017 at 9:26 AM, Maxime Ripard <maxime.ripard@free-electrons.com> wrote: > Hi, > > On Thu, Dec 21, 2017 at 09:19:24AM -0600, Kyle Evans wrote: >> On Thu, Dec 21, 2017 at 8:55 AM, Maxime Ripard >> <maxime.ripard@free-electrons.com> wrote: >> > Hi Kyle, >> > >> > On Tue, Dec 19, 2017 at 03:05:23PM -0600, kevans91@ksu.edu wrote: >> >> Allwinner a83t has a 1 KB sid block with efuse for security rootkey and >> >> thermal calibration data, add node to describe it. >> >> >> >> a83t-sid is not currently supported by nvmem/sunxi-sid, but it is >> >> supported in an external driver for FreeBSD. >> >> >> >> Signed-off-by: Kyle Evans <kevans91@ksu.edu> >> > >> > The patch looks fine in itself, but we've had a number of issues with >> > the register layout (and access patterns) in the past, so I'd rather >> > have something that works in Linux too if possible. >> >> I have a patch that I think should make it work fine on Linux [1], but >> I'm afraid I have little to no capability to test it myself and so I >> did not add it as well. >> >> I do know that the rootkey is offset 0x200 into the given space [2], >> as is the case with the H3, and that the readout quirk is not needed. >> I wasn't 100% sure that the a83t has 2Kbit worth of efuse space as the >> H3, but I do know that thermal data can be found at 0x34 and 0x38 in >> this space. > > Then maybe we should leave it aside until someone takes some time on > the A83t. The good news is that the binding itself looks fine, so as > far as FreeBSD goes, there shouldn't be anything preventing you from > using it I guess. Yeah, we've had this exact binding in our own copy of DTS up until a recent point when we flipped the switch to pulling DT from Mainline Linux and trying to upstream changes instead of having a bunch of local modifications in our tree. > Chen-Yu, what do you think? > > Thanks! > Maxime > > -- > Maxime Ripard, Free Electrons > Embedded Linux and Kernel engineering > http://free-electrons.com
Hi Maxime, On Thu, 21 Dec 2017 16:26:30 +0100 Maxime Ripard <maxime.ripard@free-electrons.com> wrote: > Hi, > > On Thu, Dec 21, 2017 at 09:19:24AM -0600, Kyle Evans wrote: > > On Thu, Dec 21, 2017 at 8:55 AM, Maxime Ripard > > <maxime.ripard@free-electrons.com> wrote: > > > Hi Kyle, > > > > > > On Tue, Dec 19, 2017 at 03:05:23PM -0600, kevans91@ksu.edu wrote: > > >> Allwinner a83t has a 1 KB sid block with efuse for security rootkey and > > >> thermal calibration data, add node to describe it. > > >> > > >> a83t-sid is not currently supported by nvmem/sunxi-sid, but it is > > >> supported in an external driver for FreeBSD. > > >> > > >> Signed-off-by: Kyle Evans <kevans91@ksu.edu> > > > > > > The patch looks fine in itself, but we've had a number of issues with > > > the register layout (and access patterns) in the past, so I'd rather > > > have something that works in Linux too if possible. > > > > I have a patch that I think should make it work fine on Linux [1], but > > I'm afraid I have little to no capability to test it myself and so I > > did not add it as well. > > > > I do know that the rootkey is offset 0x200 into the given space [2], > > as is the case with the H3, and that the readout quirk is not needed. > > I wasn't 100% sure that the a83t has 2Kbit worth of efuse space as the > > H3, but I do know that thermal data can be found at 0x34 and 0x38 in > > this space. > > Then maybe we should leave it aside until someone takes some time on > the A83t. Take some time on the Linux driver and do not apply this patch for now you mean ? Cheers, > The good news is that the binding itself looks fine, so as > far as FreeBSD goes, there shouldn't be anything preventing you from > using it I guess. > > Chen-Yu, what do you think? > > Thanks! > Maxime > > -- > Maxime Ripard, Free Electrons > Embedded Linux and Kernel engineering > http://free-electrons.com
On Thu, Dec 21, 2017 at 07:09:03PM +0100, Emmanuel Vadot wrote: > > Hi Maxime, > > On Thu, 21 Dec 2017 16:26:30 +0100 > Maxime Ripard <maxime.ripard@free-electrons.com> wrote: > > > Hi, > > > > On Thu, Dec 21, 2017 at 09:19:24AM -0600, Kyle Evans wrote: > > > On Thu, Dec 21, 2017 at 8:55 AM, Maxime Ripard > > > <maxime.ripard@free-electrons.com> wrote: > > > > Hi Kyle, > > > > > > > > On Tue, Dec 19, 2017 at 03:05:23PM -0600, kevans91@ksu.edu wrote: > > > >> Allwinner a83t has a 1 KB sid block with efuse for security rootkey and > > > >> thermal calibration data, add node to describe it. > > > >> > > > >> a83t-sid is not currently supported by nvmem/sunxi-sid, but it is > > > >> supported in an external driver for FreeBSD. > > > >> > > > >> Signed-off-by: Kyle Evans <kevans91@ksu.edu> > > > > > > > > The patch looks fine in itself, but we've had a number of issues with > > > > the register layout (and access patterns) in the past, so I'd rather > > > > have something that works in Linux too if possible. > > > > > > I have a patch that I think should make it work fine on Linux [1], but > > > I'm afraid I have little to no capability to test it myself and so I > > > did not add it as well. > > > > > > I do know that the rootkey is offset 0x200 into the given space [2], > > > as is the case with the H3, and that the readout quirk is not needed. > > > I wasn't 100% sure that the a83t has 2Kbit worth of efuse space as the > > > H3, but I do know that thermal data can be found at 0x34 and 0x38 in > > > this space. > > > > Then maybe we should leave it aside until someone takes some time on > > the A83t. > > Take some time on the Linux driver and do not apply this patch for > now you mean ? Yep. Maxime
On Fri, 22 Dec 2017 09:35:08 +0100 Maxime Ripard <maxime.ripard@free-electrons.com> wrote: > On Thu, Dec 21, 2017 at 07:09:03PM +0100, Emmanuel Vadot wrote: > > > > Hi Maxime, > > > > On Thu, 21 Dec 2017 16:26:30 +0100 > > Maxime Ripard <maxime.ripard@free-electrons.com> wrote: > > > > > Hi, > > > > > > On Thu, Dec 21, 2017 at 09:19:24AM -0600, Kyle Evans wrote: > > > > On Thu, Dec 21, 2017 at 8:55 AM, Maxime Ripard > > > > <maxime.ripard@free-electrons.com> wrote: > > > > > Hi Kyle, > > > > > > > > > > On Tue, Dec 19, 2017 at 03:05:23PM -0600, kevans91@ksu.edu wrote: > > > > >> Allwinner a83t has a 1 KB sid block with efuse for security rootkey and > > > > >> thermal calibration data, add node to describe it. > > > > >> > > > > >> a83t-sid is not currently supported by nvmem/sunxi-sid, but it is > > > > >> supported in an external driver for FreeBSD. > > > > >> > > > > >> Signed-off-by: Kyle Evans <kevans91@ksu.edu> > > > > > > > > > > The patch looks fine in itself, but we've had a number of issues with > > > > > the register layout (and access patterns) in the past, so I'd rather > > > > > have something that works in Linux too if possible. > > > > > > > > I have a patch that I think should make it work fine on Linux [1], but > > > > I'm afraid I have little to no capability to test it myself and so I > > > > did not add it as well. > > > > > > > > I do know that the rootkey is offset 0x200 into the given space [2], > > > > as is the case with the H3, and that the readout quirk is not needed. > > > > I wasn't 100% sure that the a83t has 2Kbit worth of efuse space as the > > > > H3, but I do know that thermal data can be found at 0x34 and 0x38 in > > > > this space. > > > > > > Then maybe we should leave it aside until someone takes some time on > > > the A83t. > > > > Take some time on the Linux driver and do not apply this patch for > > now you mean ? > > Yep. > > Maxime Since linux doesn't have the compatible in it's driver what would be the harm to add the node in the DTS ? If a quirks is needed because some region is weird this would go in the driver right ? I don't see a technical problem for adding this node right now. If Kyle confirm the lenght of the region and that no quirk is needed will it be enough ? Cheers,
On Fri, Dec 22, 2017 at 06:11:52PM +0800, Chen-Yu Tsai wrote: > On Fri, Dec 22, 2017 at 6:07 PM, Emmanuel Vadot <manu@bidouilliste.com> wrote: > > On Fri, 22 Dec 2017 09:35:08 +0100 > > Maxime Ripard <maxime.ripard@free-electrons.com> wrote: > > > >> On Thu, Dec 21, 2017 at 07:09:03PM +0100, Emmanuel Vadot wrote: > >> > > >> > Hi Maxime, > >> > > >> > On Thu, 21 Dec 2017 16:26:30 +0100 > >> > Maxime Ripard <maxime.ripard@free-electrons.com> wrote: > >> > > >> > > Hi, > >> > > > >> > > On Thu, Dec 21, 2017 at 09:19:24AM -0600, Kyle Evans wrote: > >> > > > On Thu, Dec 21, 2017 at 8:55 AM, Maxime Ripard > >> > > > <maxime.ripard@free-electrons.com> wrote: > >> > > > > Hi Kyle, > >> > > > > > >> > > > > On Tue, Dec 19, 2017 at 03:05:23PM -0600, kevans91@ksu.edu wrote: > >> > > > >> Allwinner a83t has a 1 KB sid block with efuse for security rootkey and > >> > > > >> thermal calibration data, add node to describe it. > >> > > > >> > >> > > > >> a83t-sid is not currently supported by nvmem/sunxi-sid, but it is > >> > > > >> supported in an external driver for FreeBSD. > >> > > > >> > >> > > > >> Signed-off-by: Kyle Evans <kevans91@ksu.edu> > >> > > > > > >> > > > > The patch looks fine in itself, but we've had a number of issues with > >> > > > > the register layout (and access patterns) in the past, so I'd rather > >> > > > > have something that works in Linux too if possible. > >> > > > > >> > > > I have a patch that I think should make it work fine on Linux [1], but > >> > > > I'm afraid I have little to no capability to test it myself and so I > >> > > > did not add it as well. > >> > > > > >> > > > I do know that the rootkey is offset 0x200 into the given space [2], > >> > > > as is the case with the H3, and that the readout quirk is not needed. > >> > > > I wasn't 100% sure that the a83t has 2Kbit worth of efuse space as the > >> > > > H3, but I do know that thermal data can be found at 0x34 and 0x38 in > >> > > > this space. > >> > > > >> > > Then maybe we should leave it aside until someone takes some time on > >> > > the A83t. > >> > > >> > Take some time on the Linux driver and do not apply this patch for > >> > now you mean ? > >> > >> Yep. > >> > >> Maxime > > > > Since linux doesn't have the compatible in it's driver what would > > be the harm to add the node in the DTS ? If a quirks is needed because > > some region is weird this would go in the driver right ? I don't see a > > technical problem for adding this node right now. > > If Kyle confirm the lenght of the region and that no quirk is needed > > will it be enough ? > > I guess I wasn't very clear. I'm OK with the patch going in. The device > node currently says nothing about how much efuse space there is. The > memory region covers that and the control section, and the size matches > what the memory map says. > > The size and offset of the efuse space would be dealt with in the driver. Let's merge it then. Acked-by: Maxime Ripard <maxime.ripard@free-electrons.com> Maxime
On Thu, Jan 4, 2018 at 8:01 AM, Maxime Ripard <maxime.ripard@free-electrons.com> wrote: > On Fri, Dec 22, 2017 at 06:11:52PM +0800, Chen-Yu Tsai wrote: >> On Fri, Dec 22, 2017 at 6:07 PM, Emmanuel Vadot <manu@bidouilliste.com> wrote: >> > On Fri, 22 Dec 2017 09:35:08 +0100 >> > Maxime Ripard <maxime.ripard@free-electrons.com> wrote: >> > >> >> On Thu, Dec 21, 2017 at 07:09:03PM +0100, Emmanuel Vadot wrote: >> >> > >> >> > Hi Maxime, >> >> > >> >> > On Thu, 21 Dec 2017 16:26:30 +0100 >> >> > Maxime Ripard <maxime.ripard@free-electrons.com> wrote: >> >> > >> >> > > Hi, >> >> > > >> >> > > On Thu, Dec 21, 2017 at 09:19:24AM -0600, Kyle Evans wrote: >> >> > > > On Thu, Dec 21, 2017 at 8:55 AM, Maxime Ripard >> >> > > > <maxime.ripard@free-electrons.com> wrote: >> >> > > > > Hi Kyle, >> >> > > > > >> >> > > > > On Tue, Dec 19, 2017 at 03:05:23PM -0600, kevans91@ksu.edu wrote: >> >> > > > >> Allwinner a83t has a 1 KB sid block with efuse for security rootkey and >> >> > > > >> thermal calibration data, add node to describe it. >> >> > > > >> >> >> > > > >> a83t-sid is not currently supported by nvmem/sunxi-sid, but it is >> >> > > > >> supported in an external driver for FreeBSD. >> >> > > > >> >> >> > > > >> Signed-off-by: Kyle Evans <kevans91@ksu.edu> >> >> > > > > >> >> > > > > The patch looks fine in itself, but we've had a number of issues with >> >> > > > > the register layout (and access patterns) in the past, so I'd rather >> >> > > > > have something that works in Linux too if possible. >> >> > > > >> >> > > > I have a patch that I think should make it work fine on Linux [1], but >> >> > > > I'm afraid I have little to no capability to test it myself and so I >> >> > > > did not add it as well. >> >> > > > >> >> > > > I do know that the rootkey is offset 0x200 into the given space [2], >> >> > > > as is the case with the H3, and that the readout quirk is not needed. >> >> > > > I wasn't 100% sure that the a83t has 2Kbit worth of efuse space as the >> >> > > > H3, but I do know that thermal data can be found at 0x34 and 0x38 in >> >> > > > this space. >> >> > > >> >> > > Then maybe we should leave it aside until someone takes some time on >> >> > > the A83t. >> >> > >> >> > Take some time on the Linux driver and do not apply this patch for >> >> > now you mean ? >> >> >> >> Yep. >> >> >> >> Maxime >> > >> > Since linux doesn't have the compatible in it's driver what would >> > be the harm to add the node in the DTS ? If a quirks is needed because >> > some region is weird this would go in the driver right ? I don't see a >> > technical problem for adding this node right now. >> > If Kyle confirm the lenght of the region and that no quirk is needed >> > will it be enough ? >> >> I guess I wasn't very clear. I'm OK with the patch going in. The device >> node currently says nothing about how much efuse space there is. The >> memory region covers that and the control section, and the size matches >> what the memory map says. >> >> The size and offset of the efuse space would be dealt with in the driver. > > Let's merge it then. > > Acked-by: Maxime Ripard <maxime.ripard@free-electrons.com> > > Maxime Hi, What does the timeline for these things normally look like? I'm new to these parts. =) Thanks, Kyle Evans
On Mon, Jan 08, 2018 at 09:30:57AM -0600, Kyle Evans wrote: > On Thu, Jan 4, 2018 at 8:01 AM, Maxime Ripard > <maxime.ripard@free-electrons.com> wrote: > > On Fri, Dec 22, 2017 at 06:11:52PM +0800, Chen-Yu Tsai wrote: > >> On Fri, Dec 22, 2017 at 6:07 PM, Emmanuel Vadot <manu@bidouilliste.com> wrote: > >> > On Fri, 22 Dec 2017 09:35:08 +0100 > >> > Maxime Ripard <maxime.ripard@free-electrons.com> wrote: > >> > > >> >> On Thu, Dec 21, 2017 at 07:09:03PM +0100, Emmanuel Vadot wrote: > >> >> > > >> >> > Hi Maxime, > >> >> > > >> >> > On Thu, 21 Dec 2017 16:26:30 +0100 > >> >> > Maxime Ripard <maxime.ripard@free-electrons.com> wrote: > >> >> > > >> >> > > Hi, > >> >> > > > >> >> > > On Thu, Dec 21, 2017 at 09:19:24AM -0600, Kyle Evans wrote: > >> >> > > > On Thu, Dec 21, 2017 at 8:55 AM, Maxime Ripard > >> >> > > > <maxime.ripard@free-electrons.com> wrote: > >> >> > > > > Hi Kyle, > >> >> > > > > > >> >> > > > > On Tue, Dec 19, 2017 at 03:05:23PM -0600, kevans91@ksu.edu wrote: > >> >> > > > >> Allwinner a83t has a 1 KB sid block with efuse for security rootkey and > >> >> > > > >> thermal calibration data, add node to describe it. > >> >> > > > >> > >> >> > > > >> a83t-sid is not currently supported by nvmem/sunxi-sid, but it is > >> >> > > > >> supported in an external driver for FreeBSD. > >> >> > > > >> > >> >> > > > >> Signed-off-by: Kyle Evans <kevans91@ksu.edu> > >> >> > > > > > >> >> > > > > The patch looks fine in itself, but we've had a number of issues with > >> >> > > > > the register layout (and access patterns) in the past, so I'd rather > >> >> > > > > have something that works in Linux too if possible. > >> >> > > > > >> >> > > > I have a patch that I think should make it work fine on Linux [1], but > >> >> > > > I'm afraid I have little to no capability to test it myself and so I > >> >> > > > did not add it as well. > >> >> > > > > >> >> > > > I do know that the rootkey is offset 0x200 into the given space [2], > >> >> > > > as is the case with the H3, and that the readout quirk is not needed. > >> >> > > > I wasn't 100% sure that the a83t has 2Kbit worth of efuse space as the > >> >> > > > H3, but I do know that thermal data can be found at 0x34 and 0x38 in > >> >> > > > this space. > >> >> > > > >> >> > > Then maybe we should leave it aside until someone takes some time on > >> >> > > the A83t. > >> >> > > >> >> > Take some time on the Linux driver and do not apply this patch for > >> >> > now you mean ? > >> >> > >> >> Yep. > >> >> > >> >> Maxime > >> > > >> > Since linux doesn't have the compatible in it's driver what would > >> > be the harm to add the node in the DTS ? If a quirks is needed because > >> > some region is weird this would go in the driver right ? I don't see a > >> > technical problem for adding this node right now. > >> > If Kyle confirm the lenght of the region and that no quirk is needed > >> > will it be enough ? > >> > >> I guess I wasn't very clear. I'm OK with the patch going in. The device > >> node currently says nothing about how much efuse space there is. The > >> memory region covers that and the control section, and the size matches > >> what the memory map says. > >> > >> The size and offset of the efuse space would be dealt with in the driver. > > > > Let's merge it then. > > > > Acked-by: Maxime Ripard <maxime.ripard@free-electrons.com> > > What does the timeline for these things normally look like? I'm new to > these parts. =) We're one week away from the merge window, so it's a bit late for it to be merged in 4.16, but it'll be in 4.17. Maxime
On Tue, Jan 9, 2018 at 7:34 AM, Maxime Ripard <maxime.ripard@free-electrons.com> wrote: > On Mon, Jan 08, 2018 at 09:30:57AM -0600, Kyle Evans wrote: >> On Thu, Jan 4, 2018 at 8:01 AM, Maxime Ripard >> <maxime.ripard@free-electrons.com> wrote: >> > On Fri, Dec 22, 2017 at 06:11:52PM +0800, Chen-Yu Tsai wrote: >> >> On Fri, Dec 22, 2017 at 6:07 PM, Emmanuel Vadot <manu@bidouilliste.com> wrote: >> >> > On Fri, 22 Dec 2017 09:35:08 +0100 >> >> > Maxime Ripard <maxime.ripard@free-electrons.com> wrote: >> >> > >> >> >> On Thu, Dec 21, 2017 at 07:09:03PM +0100, Emmanuel Vadot wrote: >> >> >> > >> >> >> > Hi Maxime, >> >> >> > >> >> >> > On Thu, 21 Dec 2017 16:26:30 +0100 >> >> >> > Maxime Ripard <maxime.ripard@free-electrons.com> wrote: >> >> >> > >> >> >> > > Hi, >> >> >> > > >> >> >> > > On Thu, Dec 21, 2017 at 09:19:24AM -0600, Kyle Evans wrote: >> >> >> > > > On Thu, Dec 21, 2017 at 8:55 AM, Maxime Ripard >> >> >> > > > <maxime.ripard@free-electrons.com> wrote: >> >> >> > > > > Hi Kyle, >> >> >> > > > > >> >> >> > > > > On Tue, Dec 19, 2017 at 03:05:23PM -0600, kevans91@ksu.edu wrote: >> >> >> > > > >> Allwinner a83t has a 1 KB sid block with efuse for security rootkey and >> >> >> > > > >> thermal calibration data, add node to describe it. >> >> >> > > > >> >> >> >> > > > >> a83t-sid is not currently supported by nvmem/sunxi-sid, but it is >> >> >> > > > >> supported in an external driver for FreeBSD. >> >> >> > > > >> >> >> >> > > > >> Signed-off-by: Kyle Evans <kevans91@ksu.edu> >> >> >> > > > > >> >> >> > > > > The patch looks fine in itself, but we've had a number of issues with >> >> >> > > > > the register layout (and access patterns) in the past, so I'd rather >> >> >> > > > > have something that works in Linux too if possible. >> >> >> > > > >> >> >> > > > I have a patch that I think should make it work fine on Linux [1], but >> >> >> > > > I'm afraid I have little to no capability to test it myself and so I >> >> >> > > > did not add it as well. >> >> >> > > > >> >> >> > > > I do know that the rootkey is offset 0x200 into the given space [2], >> >> >> > > > as is the case with the H3, and that the readout quirk is not needed. >> >> >> > > > I wasn't 100% sure that the a83t has 2Kbit worth of efuse space as the >> >> >> > > > H3, but I do know that thermal data can be found at 0x34 and 0x38 in >> >> >> > > > this space. >> >> >> > > >> >> >> > > Then maybe we should leave it aside until someone takes some time on >> >> >> > > the A83t. >> >> >> > >> >> >> > Take some time on the Linux driver and do not apply this patch for >> >> >> > now you mean ? >> >> >> >> >> >> Yep. >> >> >> >> >> >> Maxime >> >> > >> >> > Since linux doesn't have the compatible in it's driver what would >> >> > be the harm to add the node in the DTS ? If a quirks is needed because >> >> > some region is weird this would go in the driver right ? I don't see a >> >> > technical problem for adding this node right now. >> >> > If Kyle confirm the lenght of the region and that no quirk is needed >> >> > will it be enough ? >> >> >> >> I guess I wasn't very clear. I'm OK with the patch going in. The device >> >> node currently says nothing about how much efuse space there is. The >> >> memory region covers that and the control section, and the size matches >> >> what the memory map says. >> >> >> >> The size and offset of the efuse space would be dealt with in the driver. >> > >> > Let's merge it then. >> > >> > Acked-by: Maxime Ripard <maxime.ripard@free-electrons.com> >> >> What does the timeline for these things normally look like? I'm new to >> these parts. =) > > We're one week away from the merge window, so it's a bit late for it > to be merged in 4.16, but it'll be in 4.17. Ok, cool, that makes sense. Thanks!
On Tue, Jan 9, 2018 at 7:34 AM, Maxime Ripard <maxime.ripard@free-electrons.com> wrote: > On Mon, Jan 08, 2018 at 09:30:57AM -0600, Kyle Evans wrote: >> On Thu, Jan 4, 2018 at 8:01 AM, Maxime Ripard >> <maxime.ripard@free-electrons.com> wrote: >> > On Fri, Dec 22, 2017 at 06:11:52PM +0800, Chen-Yu Tsai wrote: >> >> On Fri, Dec 22, 2017 at 6:07 PM, Emmanuel Vadot <manu@bidouilliste.com> wrote: >> >> > On Fri, 22 Dec 2017 09:35:08 +0100 >> >> > Maxime Ripard <maxime.ripard@free-electrons.com> wrote: >> >> > >> >> >> On Thu, Dec 21, 2017 at 07:09:03PM +0100, Emmanuel Vadot wrote: >> >> >> > >> >> >> > Hi Maxime, >> >> >> > >> >> >> > On Thu, 21 Dec 2017 16:26:30 +0100 >> >> >> > Maxime Ripard <maxime.ripard@free-electrons.com> wrote: >> >> >> > >> >> >> > > Hi, >> >> >> > > >> >> >> > > On Thu, Dec 21, 2017 at 09:19:24AM -0600, Kyle Evans wrote: >> >> >> > > > On Thu, Dec 21, 2017 at 8:55 AM, Maxime Ripard >> >> >> > > > <maxime.ripard@free-electrons.com> wrote: >> >> >> > > > > Hi Kyle, >> >> >> > > > > >> >> >> > > > > On Tue, Dec 19, 2017 at 03:05:23PM -0600, kevans91@ksu.edu wrote: >> >> >> > > > >> Allwinner a83t has a 1 KB sid block with efuse for security rootkey and >> >> >> > > > >> thermal calibration data, add node to describe it. >> >> >> > > > >> >> >> >> > > > >> a83t-sid is not currently supported by nvmem/sunxi-sid, but it is >> >> >> > > > >> supported in an external driver for FreeBSD. >> >> >> > > > >> >> >> >> > > > >> Signed-off-by: Kyle Evans <kevans91@ksu.edu> >> >> >> > > > > >> >> >> > > > > The patch looks fine in itself, but we've had a number of issues with >> >> >> > > > > the register layout (and access patterns) in the past, so I'd rather >> >> >> > > > > have something that works in Linux too if possible. >> >> >> > > > >> >> >> > > > I have a patch that I think should make it work fine on Linux [1], but >> >> >> > > > I'm afraid I have little to no capability to test it myself and so I >> >> >> > > > did not add it as well. >> >> >> > > > >> >> >> > > > I do know that the rootkey is offset 0x200 into the given space [2], >> >> >> > > > as is the case with the H3, and that the readout quirk is not needed. >> >> >> > > > I wasn't 100% sure that the a83t has 2Kbit worth of efuse space as the >> >> >> > > > H3, but I do know that thermal data can be found at 0x34 and 0x38 in >> >> >> > > > this space. >> >> >> > > >> >> >> > > Then maybe we should leave it aside until someone takes some time on >> >> >> > > the A83t. >> >> >> > >> >> >> > Take some time on the Linux driver and do not apply this patch for >> >> >> > now you mean ? >> >> >> >> >> >> Yep. >> >> >> >> >> >> Maxime >> >> > >> >> > Since linux doesn't have the compatible in it's driver what would >> >> > be the harm to add the node in the DTS ? If a quirks is needed because >> >> > some region is weird this would go in the driver right ? I don't see a >> >> > technical problem for adding this node right now. >> >> > If Kyle confirm the lenght of the region and that no quirk is needed >> >> > will it be enough ? >> >> >> >> I guess I wasn't very clear. I'm OK with the patch going in. The device >> >> node currently says nothing about how much efuse space there is. The >> >> memory region covers that and the control section, and the size matches >> >> what the memory map says. >> >> >> >> The size and offset of the efuse space would be dealt with in the driver. >> > >> > Let's merge it then. >> > >> > Acked-by: Maxime Ripard <maxime.ripard@free-electrons.com> >> >> What does the timeline for these things normally look like? I'm new to >> these parts. =) > > We're one week away from the merge window, so it's a bit late for it > to be merged in 4.16, but it'll be in 4.17. > > Maxime > Hi, It's been two months and this still hasn't quite landed in sunxi/for-next. =( May I ask the status on this? Thanks, Kyle Evans
On Wed, Apr 18, 2018 at 09:05:19AM -0500, Kyle Evans wrote: > On Tue, Jan 9, 2018 at 7:34 AM, Maxime Ripard > <maxime.ripard@free-electrons.com> wrote: > > On Mon, Jan 08, 2018 at 09:30:57AM -0600, Kyle Evans wrote: > >> On Thu, Jan 4, 2018 at 8:01 AM, Maxime Ripard > >> <maxime.ripard@free-electrons.com> wrote: > >> > On Fri, Dec 22, 2017 at 06:11:52PM +0800, Chen-Yu Tsai wrote: > >> >> On Fri, Dec 22, 2017 at 6:07 PM, Emmanuel Vadot <manu@bidouilliste.com> wrote: > >> >> > On Fri, 22 Dec 2017 09:35:08 +0100 > >> >> > Maxime Ripard <maxime.ripard@free-electrons.com> wrote: > >> >> > > >> >> >> On Thu, Dec 21, 2017 at 07:09:03PM +0100, Emmanuel Vadot wrote: > >> >> >> > > >> >> >> > Hi Maxime, > >> >> >> > > >> >> >> > On Thu, 21 Dec 2017 16:26:30 +0100 > >> >> >> > Maxime Ripard <maxime.ripard@free-electrons.com> wrote: > >> >> >> > > >> >> >> > > Hi, > >> >> >> > > > >> >> >> > > On Thu, Dec 21, 2017 at 09:19:24AM -0600, Kyle Evans wrote: > >> >> >> > > > On Thu, Dec 21, 2017 at 8:55 AM, Maxime Ripard > >> >> >> > > > <maxime.ripard@free-electrons.com> wrote: > >> >> >> > > > > Hi Kyle, > >> >> >> > > > > > >> >> >> > > > > On Tue, Dec 19, 2017 at 03:05:23PM -0600, kevans91@ksu.edu wrote: > >> >> >> > > > >> Allwinner a83t has a 1 KB sid block with efuse for security rootkey and > >> >> >> > > > >> thermal calibration data, add node to describe it. > >> >> >> > > > >> > >> >> >> > > > >> a83t-sid is not currently supported by nvmem/sunxi-sid, but it is > >> >> >> > > > >> supported in an external driver for FreeBSD. > >> >> >> > > > >> > >> >> >> > > > >> Signed-off-by: Kyle Evans <kevans91@ksu.edu> > >> >> >> > > > > > >> >> >> > > > > The patch looks fine in itself, but we've had a number of issues with > >> >> >> > > > > the register layout (and access patterns) in the past, so I'd rather > >> >> >> > > > > have something that works in Linux too if possible. > >> >> >> > > > > >> >> >> > > > I have a patch that I think should make it work fine on Linux [1], but > >> >> >> > > > I'm afraid I have little to no capability to test it myself and so I > >> >> >> > > > did not add it as well. > >> >> >> > > > > >> >> >> > > > I do know that the rootkey is offset 0x200 into the given space [2], > >> >> >> > > > as is the case with the H3, and that the readout quirk is not needed. > >> >> >> > > > I wasn't 100% sure that the a83t has 2Kbit worth of efuse space as the > >> >> >> > > > H3, but I do know that thermal data can be found at 0x34 and 0x38 in > >> >> >> > > > this space. > >> >> >> > > > >> >> >> > > Then maybe we should leave it aside until someone takes some time on > >> >> >> > > the A83t. > >> >> >> > > >> >> >> > Take some time on the Linux driver and do not apply this patch for > >> >> >> > now you mean ? > >> >> >> > >> >> >> Yep. > >> >> >> > >> >> >> Maxime > >> >> > > >> >> > Since linux doesn't have the compatible in it's driver what would > >> >> > be the harm to add the node in the DTS ? If a quirks is needed because > >> >> > some region is weird this would go in the driver right ? I don't see a > >> >> > technical problem for adding this node right now. > >> >> > If Kyle confirm the lenght of the region and that no quirk is needed > >> >> > will it be enough ? > >> >> > >> >> I guess I wasn't very clear. I'm OK with the patch going in. The device > >> >> node currently says nothing about how much efuse space there is. The > >> >> memory region covers that and the control section, and the size matches > >> >> what the memory map says. > >> >> > >> >> The size and offset of the efuse space would be dealt with in the driver. > >> > > >> > Let's merge it then. > >> > > >> > Acked-by: Maxime Ripard <maxime.ripard@free-electrons.com> > >> > >> What does the timeline for these things normally look like? I'm new to > >> these parts. =) > > > > We're one week away from the merge window, so it's a bit late for it > > to be merged in 4.16, but it'll be in 4.17. > It's been two months and this still hasn't quite landed in > sunxi/for-next. =( May I ask the status on this? It seems to have fallen through the cracks, sorry :/ Can you resend it based on 4.17? Thanks! Maxime
diff --git a/Documentation/devicetree/bindings/nvmem/allwinner,sunxi-sid.txt b/Documentation/devicetree/bindings/nvmem/allwinner,sunxi-sid.txt index d69543701..e319fe5e2 100644 --- a/Documentation/devicetree/bindings/nvmem/allwinner,sunxi-sid.txt +++ b/Documentation/devicetree/bindings/nvmem/allwinner,sunxi-sid.txt @@ -4,6 +4,7 @@ Required properties: - compatible: Should be one of the following: "allwinner,sun4i-a10-sid" "allwinner,sun7i-a20-sid" + "allwinner,sun8i-a83t-sid" "allwinner,sun8i-h3-sid" "allwinner,sun50i-a64-sid" diff --git a/arch/arm/boot/dts/sun8i-a83t.dtsi b/arch/arm/boot/dts/sun8i-a83t.dtsi index de5119a2a..cced6e5fb 100644 --- a/arch/arm/boot/dts/sun8i-a83t.dtsi +++ b/arch/arm/boot/dts/sun8i-a83t.dtsi @@ -238,6 +238,11 @@ #size-cells = <0>; }; + sid: eeprom@1c14000 { + compatible = "allwinner,sun8i-a83t-sid"; + reg = <0x1c14000 0x400>; + }; + usb_otg: usb@1c19000 { compatible = "allwinner,sun8i-a83t-musb", "allwinner,sun8i-a33-musb";
Allwinner a83t has a 1 KB sid block with efuse for security rootkey and thermal calibration data, add node to describe it. a83t-sid is not currently supported by nvmem/sunxi-sid, but it is supported in an external driver for FreeBSD. Signed-off-by: Kyle Evans <kevans91@ksu.edu> --- Changes in v2: - remove bogus "From:" line in commit text; no functional change Documentation/devicetree/bindings/nvmem/allwinner,sunxi-sid.txt | 1 + arch/arm/boot/dts/sun8i-a83t.dtsi | 5 +++++ 2 files changed, 6 insertions(+)