From patchwork Wed Dec 20 21:41:21 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Boris BREZILLON X-Patchwork-Id: 10126639 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 7062C60245 for ; Wed, 20 Dec 2017 21:41:42 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 618A629912 for ; Wed, 20 Dec 2017 21:41:42 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 54DFE29916; Wed, 20 Dec 2017 21:41:42 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.2 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,RCVD_IN_DNSWL_MED autolearn=ham version=3.3.1 Received: from bombadil.infradead.org (bombadil.infradead.org [65.50.211.133]) (using TLSv1.2 with cipher AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 86CBF29912 for ; Wed, 20 Dec 2017 21:41:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=1hv424f5lln5vdBUhwbMyjLdS6AahYxs4ZRJlDXlT98=; b=YRRFoW5Y+XSv68 NqL768y5uJN/5f5qP0W0f0+C95cWOK7vOTIirdonylRgy1e4NqjFPWsmpnFnNGsHqaQ4EKqVEwyft SR0q5G+hYAv/IUW0c8LPkWS+udv6aoJn+tLs1V6QJBmx3rhyPI9bYCkMtfou3x9Ktr2cjdFaCFIjS roPWEn6/FFjTOEnJp/H0GlZCTTJ3eTKoDMuNqwtsXGgDO9g71Pv0YM/t5u6YqRySeEXsmfpTzWZnp bpZLAXVsb+lkvXN/uM8MqLkU+5Xb09eoyFH9PCRf1I2sftcJEZNShtSilWfK/MU5jCXBayBkcOPXU 59y4IQNMJ09yJh7T6EOg==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.89 #1 (Red Hat Linux)) id 1eRm7N-0007Ta-6R; Wed, 20 Dec 2017 21:41:37 +0000 Received: from mail.free-electrons.com ([62.4.15.54]) by bombadil.infradead.org with esmtp (Exim 4.89 #1 (Red Hat Linux)) id 1eRm7J-0007RG-DQ; Wed, 20 Dec 2017 21:41:35 +0000 Received: by mail.free-electrons.com (Postfix, from userid 110) id 8F513207A7; Wed, 20 Dec 2017 22:41:21 +0100 (CET) Received: from bbrezillon (91-160-177-164.subs.proxad.net [91.160.177.164]) by mail.free-electrons.com (Postfix) with ESMTPSA id 1259D2037F; Wed, 20 Dec 2017 22:41:21 +0100 (CET) Date: Wed, 20 Dec 2017 22:41:21 +0100 From: Boris Brezillon To: Robert Jarzmik Subject: Re: [PATCH 00/12] Marvell NAND controller rework with ->exec_op() Message-ID: <20171220224121.2cb6f690@bbrezillon> In-Reply-To: <87y3lxccr7.fsf@belgarion.home> References: <20171207201814.30411-1-miquel.raynal@free-electrons.com> <20171214070930.0b885f6d@bbrezillon> <877etkecig.fsf@belgarion.home> <20171218092535.2ca1fe13@xps13> <87y3lxccr7.fsf@belgarion.home> X-Mailer: Claws Mail 3.14.1 (GTK+ 2.24.31; x86_64-pc-linux-gnu) MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20171220_134133_744603_772FA8DC X-CRM114-Status: GOOD ( 28.28 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , Andrew Lunn , Catalin Marinas , Hanna Hawa , Will Deacon , Nadav Haklai , linux-mtd@lists.infradead.org, Richard Weinberger , Russell King , Marek Vasut , Ezequiel Garcia , Sebastian Hesselbarth , devicetree@vger.kernel.org, Jason Cooper , Haojian Zhuang , Rob Herring , Miquel RAYNAL , Gregory Clement , Ofer Heifetz , linux-arm-kernel@lists.infradead.org, Thomas Petazzoni , Eric Miao , Antoine Tenart , Cyrille Pitchen , Neta Zur Hershkovits , Brian Norris , David Woodhouse , Daniel Mack Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org X-Virus-Scanned: ClamAV using ClamSMTP On Wed, 20 Dec 2017 22:26:04 +0100 Robert Jarzmik wrote: > Miquel RAYNAL writes: > > > Hello Robert, > > > > On Mon, 18 Dec 2017 08:11:35 +0100 > > Robert Jarzmik wrote: > > > >> Boris Brezillon writes: > >> > >> >> Robert, it would be great if you could also do more testing on PXA > >> >> and validate this driver. If needed, a branch ready to be tested is > >> >> available at [3]. It is based on nand/next and has all the changes > >> >> brought by the previously mentionned series as well as this one. > >> > > >> > Robert, do you think you'll have some time to test Miquel's branch > >> > on your PXA boards? Miquel already tested on one of these boards > >> > (CM-X300), but we'd like to have other testers. Also feel free to > >> > review the driver if have the time. > >> > > >> > Thanks, > >> > > >> > Boris > >> > >> Hi Boris and Miquel, > >> > >> I have applied the whole serie to linux-next yesterday. > >> > >> A boot attempt on my zylonite with my old defconfig (with the new > >> Marvell NAND config activated) yields to : > >> - this message > >> [ 3.136818] marvell-nfc pxa3xx-nand: could not identify the nand > >> chip [ 3.143874] marvell-nfc: probe of pxa3xx-nand failed with > >> error -22 > >> - then my board hangs > >> > >> Is there something to be done to improve the trace level so that you > >> can guess what's happening ? > > > > Thank you very much for testing this. > > > > Could you please try this branch [1] instead of linux-next + the > > patches? > > > > Also, can you please add #define DEBUG in marvell_nand.c + nand_base.c, > > it should help us figuring out what is wrong. > > Done, same result, the dmesg is in [1]. Looks like there is a mismatch on the nand bus width detected by the core and the one declared by the driver. Can you try with the following diff applied? Thanks, Boris --->8--- diff --git a/drivers/mtd/nand/marvell_nand.c b/drivers/mtd/nand/marvell_nand.c index c618ccb22a61..ddd6a07888e2 100644 --- a/drivers/mtd/nand/marvell_nand.c +++ b/drivers/mtd/nand/marvell_nand.c @@ -2481,6 +2481,7 @@ static int marvell_nand_chip_init(struct device *dev, struct marvell_nfc *nfc, */ chip->ecc.mode = NAND_ECC_HW; + chip->options |= NAND_BUSWIDTH_AUTO; ret = nand_scan_ident(mtd, marvell_nand->nsels, NULL); if (ret) { dev_err(dev, "could not identify the nand chip\n");