| Message ID | 20171227221446.18459-2-antoine.tenart@free-electrons.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Wed, Dec 27, 2017 at 11:14:41PM +0100, Antoine Tenart wrote: > This patch adds one more generic PHY mode to the phy_mode enum, to allow > configuring generic PHYs to the 2.5G SGMII mode by using the set_mode > callback. > > Signed-off-by: Antoine Tenart <antoine.tenart@free-electrons.com> > --- > include/linux/phy/phy.h | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/include/linux/phy/phy.h b/include/linux/phy/phy.h > index 4f8423a948d5..70459a28f3a1 100644 > --- a/include/linux/phy/phy.h > +++ b/include/linux/phy/phy.h > @@ -28,6 +28,7 @@ enum phy_mode { > PHY_MODE_USB_DEVICE, > PHY_MODE_USB_OTG, > PHY_MODE_SGMII, > + PHY_MODE_SGMII_2_5G, > PHY_MODE_10GKR, > PHY_MODE_UFS_HS_A, > PHY_MODE_UFS_HS_B, Hi Antoine There was a discussion maybe last month about adding 2.5G SGMII. I would prefer 2500SGMII. Putting the number first makes it uniform with the other defines, 1000BASEX, 25000BASEX, 10GKR. Andrew
Hi Andrew, On Thu, Dec 28, 2017 at 08:20:53AM +0100, Andrew Lunn wrote: > On Wed, Dec 27, 2017 at 11:14:41PM +0100, Antoine Tenart wrote: > > This patch adds one more generic PHY mode to the phy_mode enum, to allow > > configuring generic PHYs to the 2.5G SGMII mode by using the set_mode > > callback. > > > > Signed-off-by: Antoine Tenart <antoine.tenart@free-electrons.com> > > --- > > include/linux/phy/phy.h | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/include/linux/phy/phy.h b/include/linux/phy/phy.h > > index 4f8423a948d5..70459a28f3a1 100644 > > --- a/include/linux/phy/phy.h > > +++ b/include/linux/phy/phy.h > > @@ -28,6 +28,7 @@ enum phy_mode { > > PHY_MODE_USB_DEVICE, > > PHY_MODE_USB_OTG, > > PHY_MODE_SGMII, > > + PHY_MODE_SGMII_2_5G, > > PHY_MODE_10GKR, > > PHY_MODE_UFS_HS_A, > > PHY_MODE_UFS_HS_B, > > There was a discussion maybe last month about adding 2.5G SGMII. I > would prefer 2500SGMII. Putting the number first makes it uniform with > the other defines, 1000BASEX, 25000BASEX, 10GKR. Good to know. I wasn't completely sure how to name this mode properly, but I'm fine with PHY_MODE_2500SGMII. I'll update the patches and send a v2 (without the dt part). Thanks! Antoine
On 12/28/2017 02:06 AM, Antoine Tenart wrote: > Hi Andrew, > > On Thu, Dec 28, 2017 at 08:20:53AM +0100, Andrew Lunn wrote: >> On Wed, Dec 27, 2017 at 11:14:41PM +0100, Antoine Tenart wrote: >>> This patch adds one more generic PHY mode to the phy_mode enum, to allow >>> configuring generic PHYs to the 2.5G SGMII mode by using the set_mode >>> callback. >>> >>> Signed-off-by: Antoine Tenart <antoine.tenart@free-electrons.com> >>> --- >>> include/linux/phy/phy.h | 1 + >>> 1 file changed, 1 insertion(+) >>> >>> diff --git a/include/linux/phy/phy.h b/include/linux/phy/phy.h >>> index 4f8423a948d5..70459a28f3a1 100644 >>> --- a/include/linux/phy/phy.h >>> +++ b/include/linux/phy/phy.h >>> @@ -28,6 +28,7 @@ enum phy_mode { >>> PHY_MODE_USB_DEVICE, >>> PHY_MODE_USB_OTG, >>> PHY_MODE_SGMII, >>> + PHY_MODE_SGMII_2_5G, >>> PHY_MODE_10GKR, >>> PHY_MODE_UFS_HS_A, >>> PHY_MODE_UFS_HS_B, >> >> There was a discussion maybe last month about adding 2.5G SGMII. I >> would prefer 2500SGMII. Putting the number first makes it uniform with >> the other defines, 1000BASEX, 25000BASEX, 10GKR. > > Good to know. I wasn't completely sure how to name this mode properly, > but I'm fine with PHY_MODE_2500SGMII. I'll update the patches and send a > v2 (without the dt part). And since you are respinning, please make sure you update phy_modes() in the same header file as well as Documentation/devicetree/bindings/net/ethernet.txt with the newly added PHY interface mode.
Hi Florian, On Thu, Dec 28, 2017 at 06:16:51AM -0800, Florian Fainelli wrote: > > And since you are respinning, please make sure you update phy_modes() in > the same header file as well as > Documentation/devicetree/bindings/net/ethernet.txt with the newly added > PHY interface mode. You're right. Thanks for pointing this out! Antoine
Hi Florian, On Thu, Dec 28, 2017 at 06:16:51AM -0800, Florian Fainelli wrote: > On 12/28/2017 02:06 AM, Antoine Tenart wrote: > > On Thu, Dec 28, 2017 at 08:20:53AM +0100, Andrew Lunn wrote: > >> On Wed, Dec 27, 2017 at 11:14:41PM +0100, Antoine Tenart wrote: > >>> This patch adds one more generic PHY mode to the phy_mode enum, to allow > >>> configuring generic PHYs to the 2.5G SGMII mode by using the set_mode > >>> callback. > >>> > >>> Signed-off-by: Antoine Tenart <antoine.tenart@free-electrons.com> > >>> --- > >>> include/linux/phy/phy.h | 1 + > >>> 1 file changed, 1 insertion(+) > >>> > >>> diff --git a/include/linux/phy/phy.h b/include/linux/phy/phy.h > >>> index 4f8423a948d5..70459a28f3a1 100644 > >>> --- a/include/linux/phy/phy.h > >>> +++ b/include/linux/phy/phy.h > >>> @@ -28,6 +28,7 @@ enum phy_mode { > >>> PHY_MODE_USB_DEVICE, > >>> PHY_MODE_USB_OTG, > >>> PHY_MODE_SGMII, > >>> + PHY_MODE_SGMII_2_5G, > >>> PHY_MODE_10GKR, > >>> PHY_MODE_UFS_HS_A, > >>> PHY_MODE_UFS_HS_B, > >> > >> There was a discussion maybe last month about adding 2.5G SGMII. I > >> would prefer 2500SGMII. Putting the number first makes it uniform with > >> the other defines, 1000BASEX, 25000BASEX, 10GKR. > > > > Good to know. I wasn't completely sure how to name this mode properly, > > but I'm fine with PHY_MODE_2500SGMII. I'll update the patches and send a > > v2 (without the dt part). > > And since you are respinning, please make sure you update phy_modes() in > the same header file as well as > Documentation/devicetree/bindings/net/ethernet.txt with the newly added > PHY interface mode. Actually it's a generic PHY mode I'm adding, not a network PHY mode. There's no phy_modes() function for generic PHYs (and this 2500BaseX mode already is supported in the network PHY modes). Thanks! Antoine
> > >>> diff --git a/include/linux/phy/phy.h b/include/linux/phy/phy.h > > >>> index 4f8423a948d5..70459a28f3a1 100644 > > >>> --- a/include/linux/phy/phy.h > > >>> +++ b/include/linux/phy/phy.h > > >>> @@ -28,6 +28,7 @@ enum phy_mode { > > >>> PHY_MODE_USB_DEVICE, > > >>> PHY_MODE_USB_OTG, > > >>> PHY_MODE_SGMII, > > >>> + PHY_MODE_SGMII_2_5G, > > >>> PHY_MODE_10GKR, > > >>> PHY_MODE_UFS_HS_A, > > >>> PHY_MODE_UFS_HS_B, > > >> > > >> There was a discussion maybe last month about adding 2.5G SGMII. I > > >> would prefer 2500SGMII. Putting the number first makes it uniform with > > >> the other defines, 1000BASEX, 25000BASEX, 10GKR. > > > > > > Good to know. I wasn't completely sure how to name this mode properly, > > > but I'm fine with PHY_MODE_2500SGMII. I'll update the patches and send a > > > v2 (without the dt part). > > > > And since you are respinning, please make sure you update phy_modes() in > > the same header file as well as > > Documentation/devicetree/bindings/net/ethernet.txt with the newly added > > PHY interface mode. > > Actually it's a generic PHY mode I'm adding, not a network PHY mode. > There's no phy_modes() function for generic PHYs (and this 2500BaseX > mode already is supported in the network PHY modes). Hi Antoine Don't you need it in both include/linux/phy/phy.h and include/linux/phy.h? Andrew
On Wed, Jan 03, 2018 at 04:08:30PM +0100, Andrew Lunn wrote: > > > >>> diff --git a/include/linux/phy/phy.h b/include/linux/phy/phy.h > > > >>> index 4f8423a948d5..70459a28f3a1 100644 > > > >>> --- a/include/linux/phy/phy.h > > > >>> +++ b/include/linux/phy/phy.h > > > >>> @@ -28,6 +28,7 @@ enum phy_mode { > > > >>> PHY_MODE_USB_DEVICE, > > > >>> PHY_MODE_USB_OTG, > > > >>> PHY_MODE_SGMII, > > > >>> + PHY_MODE_SGMII_2_5G, > > > >>> PHY_MODE_10GKR, > > > >>> PHY_MODE_UFS_HS_A, > > > >>> PHY_MODE_UFS_HS_B, > > > >> > > > >> There was a discussion maybe last month about adding 2.5G SGMII. I > > > >> would prefer 2500SGMII. Putting the number first makes it uniform with > > > >> the other defines, 1000BASEX, 25000BASEX, 10GKR. > > > > > > > > Good to know. I wasn't completely sure how to name this mode properly, > > > > but I'm fine with PHY_MODE_2500SGMII. I'll update the patches and send a > > > > v2 (without the dt part). > > > > > > And since you are respinning, please make sure you update phy_modes() in > > > the same header file as well as > > > Documentation/devicetree/bindings/net/ethernet.txt with the newly added > > > PHY interface mode. > > > > Actually it's a generic PHY mode I'm adding, not a network PHY mode. > > There's no phy_modes() function for generic PHYs (and this 2500BaseX > > mode already is supported in the network PHY modes). > > Hi Antoine > > Don't you need it in both include/linux/phy/phy.h and > include/linux/phy.h? Is it really 2.5G SGMII or 2.5G Base-X - iow, which configuration word is permissible at 2.5G speeds for the pp2? We already have 2500BASEX in linux/phy.h, which is the 802.3z compliant 16-bit configuration word rather than the Cisco variant.
diff --git a/include/linux/phy/phy.h b/include/linux/phy/phy.h index 4f8423a948d5..70459a28f3a1 100644 --- a/include/linux/phy/phy.h +++ b/include/linux/phy/phy.h @@ -28,6 +28,7 @@ enum phy_mode { PHY_MODE_USB_DEVICE, PHY_MODE_USB_OTG, PHY_MODE_SGMII, + PHY_MODE_SGMII_2_5G, PHY_MODE_10GKR, PHY_MODE_UFS_HS_A, PHY_MODE_UFS_HS_B,
This patch adds one more generic PHY mode to the phy_mode enum, to allow configuring generic PHYs to the 2.5G SGMII mode by using the set_mode callback. Signed-off-by: Antoine Tenart <antoine.tenart@free-electrons.com> --- include/linux/phy/phy.h | 1 + 1 file changed, 1 insertion(+)