From patchwork Wed Jan 10 16:22:00 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Arnd Bergmann X-Patchwork-Id: 10155547 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 4763C60231 for ; Wed, 10 Jan 2018 16:22:50 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 3833326B41 for ; Wed, 10 Jan 2018 16:22:50 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 2CEC328414; Wed, 10 Jan 2018 16:22:50 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.2 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,RCVD_IN_DNSWL_MED autolearn=ham version=3.3.1 Received: from bombadil.infradead.org (bombadil.infradead.org [65.50.211.133]) (using TLSv1.2 with cipher AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 8859726B41 for ; Wed, 10 Jan 2018 16:22:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:MIME-Version:Cc:List-Subscribe: List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id:Message-Id:Date: Subject:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To: References:List-Owner; bh=qHd18P+5/uqxOd3fSlqx1uAAjkgqvb+GPsxT7klt9Ts=; b=WQx kX/gD7Z4ZrFczchgj7trN7uu/lFuTUbi8ndpTPKum3MkhQpD9aDJotwu0MCyVtSrG6sNsS/aJISzI rmVO4QOP3UXJPUNUTXcfPI+m5j1cjRwwuxlqL04LK+4qcjgSdeqHZx/SK9+Gh0fAHgMC3eToAat+e gv/KVnxPbOv/d9kNWDHfY03HnGN5c2JIJCHNtGBUGRGdkrSvGaMqDnW2N+6PkzT8lDiPFHLo8C01Q rUHoJKMpbldcuD2LkSO4LdQDofsENSWD5nXca63QK7G8I2Yo74GjzsE+eh+SamB8nUX3UAb+HoxE8 FRKqMqe56y2oaMladylxfCS768s0ZNQ==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.89 #1 (Red Hat Linux)) id 1eZJ9L-0003Dv-QV; Wed, 10 Jan 2018 16:22:47 +0000 Received: from mout.kundenserver.de ([212.227.126.134]) by bombadil.infradead.org with esmtps (Exim 4.89 #1 (Red Hat Linux)) id 1eZJ9C-00031h-B3 for linux-arm-kernel@lists.infradead.org; Wed, 10 Jan 2018 16:22:41 +0000 Received: from wuerfel.lan ([95.208.111.237]) by mrelayeu.kundenserver.de (mreue007 [212.227.15.129]) with ESMTPA (Nemesis) id 0LrDwG-1f0xrW2zro-0136HM; Wed, 10 Jan 2018 17:22:22 +0100 From: Arnd Bergmann To: Vladimir Zapolskiy , Sylvain Lemieux Subject: [PATCH] ARM: lpc3250: fix uda1380 gpio numbers Date: Wed, 10 Jan 2018 17:22:00 +0100 Message-Id: <20180110162220.224945-1-arnd@arndb.de> X-Mailer: git-send-email 2.9.0 X-Provags-ID: V03:K0:XL6nn3E9bLVTcjoo67Q6rfPUECqoWqnR+0pPXOieuFZLOe0F+/P bQP8EkNKrQqEPAEo/F5AAcvDC3UcjSDbetuP56GM5JPRUIwwFt6xndVLkHt8qoTbYFlXXgk IHr3Sbc4JkDgk1wPwRjajUDYNmSyeUCBFThBN3Y2MqtFrM11B6n4rjjw1/lWIO4QZhvXotu RSynj5k2fh/NRVKxZfV+w== X-UI-Out-Filterresults: notjunk:1; V01:K0:0QfRX3aqUNE=:PDlFcW1eEYmLfyUP+aoFYj np5i75SdYPh9i9te7JX5SoLI7mSHJBc5NdL2MXBWl5e5slOEz/gSZTwnX8Z2sbSSUvAo8dY9z 2U8Fz9cHOgMC5HjvREyGtKthUj4dLQ8eEkvEDPX+cxg/qo4LCjT8wZMUPT7gxYQxqmwTEyMkS jMmxHpmCf65vCA2tMmVYUYtV6YJ93qU7UuAC/Ze2PCF2besN+e5GDfTDc4BxVgebnNZPl2sVO Se8iTaIN/LkPKJwmdJePhqAHC4ltFvRxjUA0bA9kbMDhE9oU/JZQNiAVvA4CF8GdWt5hesONF yODAx5PfCpkkeNDg6Xg2FP3RrEcluC8xQEe+s6hj4o24WfTIKpShb3totJFtfyA2CDiH+t25h 4ma+WAPRTUolsK89107aaA79++/6L1sVMFoq2XPZLJ+xESH8GTsEh8u/uDXAeXh1cj88nR0EM VK1unJo5BR0fNO8i+lMFtPyxiZJPmgNfMpyOmGWjCDi+HFT1qvHYwgJ52MeuVe54SoPG/W2mt VRVHZDp19oposJTAZG1VQu9IVgxAUplId1+e1o+nRS3c/DHDkvTVCIg845aOXmN7NuNn/6s53 SFyHAV/PfwU0RVtQUs0nbY2ST7tU/ppo+7pNBt+o7BMWWsXYfFNnHWBrX0Qij+nt7FNPZlCrG 3l2oyeL5Irmm3d8VdoLxHufvO0Wt5sTA9ke48aGE0dX1UAT8B/YoV74aTstEfPzXs5Rgn4GZf a6RLe1RCsdcQtYCSpzvIFbq8BVP44CijVuiUlA== X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20180110_082238_798630_B3ADFE7E X-CRM114-Status: GOOD ( 11.90 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , devicetree@vger.kernel.org, Arnd Bergmann , linux-kernel@vger.kernel.org, Rob Herring , linux-arm-kernel@lists.infradead.org MIME-Version: 1.0 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org X-Virus-Scanned: ClamAV using ClamSMTP dtc warns about obviously incorrect GPIO numbers for the audio codec on both lpc32xx boards: arch/arm/boot/dts/lpc3250-phy3250.dtb: Warning (gpios_property): reset-gpio property size (12) too small for cell size 3 in /ahb/apb/i2c@400A0000/uda1380@18 arch/arm/boot/dts/lpc3250-phy3250.dtb: Warning (gpios_property): power-gpio property size (12) too small for cell size 3 in /ahb/apb/i2c@400A0000/uda1380@18 arch/arm/boot/dts/lpc3250-ea3250.dtb: Warning (gpios_property): reset-gpio property size (12) too small for cell size 3 in /ahb/apb/i2c@400A0000/uda1380@18 arch/arm/boot/dts/lpc3250-ea3250.dtb: Warning (gpios_property): power-gpio property size (12) too small for cell size 3 in /ahb/apb/i2c@400A0000/uda1380@18 It looks like the nodes are written for a different binding that combines the GPIO number into a single number rather than a bank/number pair. I found the right numbers on stackexchange.com, so this patch fixes the warning and has a reasonable chance of getting things to actually work. Link: https://unix.stackexchange.com/questions/59497/alsa-asoc-how-to-correctly-load-devices-drivers/62217#62217 Signed-off-by: Arnd Bergmann --- arch/arm/boot/dts/lpc3250-ea3250.dts | 4 ++-- arch/arm/boot/dts/lpc3250-phy3250.dts | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/arch/arm/boot/dts/lpc3250-ea3250.dts b/arch/arm/boot/dts/lpc3250-ea3250.dts index c43adb7b4d7c..58ea0a4e7afa 100644 --- a/arch/arm/boot/dts/lpc3250-ea3250.dts +++ b/arch/arm/boot/dts/lpc3250-ea3250.dts @@ -156,8 +156,8 @@ uda1380: uda1380@18 { compatible = "nxp,uda1380"; reg = <0x18>; - power-gpio = <&gpio 0x59 0>; - reset-gpio = <&gpio 0x51 0>; + power-gpio = <&gpio 3 10 0>; + reset-gpio = <&gpio 3 2 0>; dac-clk = "wspll"; }; diff --git a/arch/arm/boot/dts/lpc3250-phy3250.dts b/arch/arm/boot/dts/lpc3250-phy3250.dts index c72eb9845603..1e1c2f517a82 100644 --- a/arch/arm/boot/dts/lpc3250-phy3250.dts +++ b/arch/arm/boot/dts/lpc3250-phy3250.dts @@ -81,8 +81,8 @@ uda1380: uda1380@18 { compatible = "nxp,uda1380"; reg = <0x18>; - power-gpio = <&gpio 0x59 0>; - reset-gpio = <&gpio 0x51 0>; + power-gpio = <&gpio 3 10 0>; + reset-gpio = <&gpio 3 2 0>; dac-clk = "wspll"; };