From patchwork Fri Jan 12 17:51:07 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Mauro Carvalho Chehab X-Patchwork-Id: 10161521 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id B5796602A7 for ; Fri, 12 Jan 2018 17:51:38 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id A5B4528975 for ; Fri, 12 Jan 2018 17:51:38 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 99E8A28978; Fri, 12 Jan 2018 17:51:38 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.2 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,RCVD_IN_DNSWL_MED autolearn=ham version=3.3.1 Received: from bombadil.infradead.org (bombadil.infradead.org [65.50.211.133]) (using TLSv1.2 with cipher AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 9395928975 for ; Fri, 12 Jan 2018 17:51:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=lY7tiN/x863L/MnPa9q8O9H539OTrg9qYuFAGII8CM8=; b=WdXoNeh8Nq95aR sfGywzC+iDjqCm/WaelEV07rskw7HQ0H9+lDOXFea7Z2dBQlDp6vNNXVDhhcMPKHFNinENChXj9BQ pYtIqwJ/BxiEBmhbYvsFABUL/E7UUHU6HclCJsrj7Xws33Sg1RQdjB5J2w1nnEtxN9s4N4u0x8x5X LfYKl6ej1dVB/R7b1ciI6i5NrpPKkPBZbqkmrYhki+oh2Y6l0Di3p58KWggLCcHtzqnq1S7fXIZPQ ke8nB/XY3oIR3Aoe8GpAyO4qPMctYsN6yVv+RZAgvGQm04IQPJ3Kzqry+ActEpxwVTCGtuulBOlDP labgCFLiOjct/zLX2n3A==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.89 #1 (Red Hat Linux)) id 1ea3UM-0007X9-Fb; Fri, 12 Jan 2018 17:51:34 +0000 Received: from osg.samsung.com ([64.30.133.232]) by bombadil.infradead.org with esmtp (Exim 4.89 #1 (Red Hat Linux)) id 1ea3UJ-0007EJ-D7 for linux-arm-kernel@lists.infradead.org; Fri, 12 Jan 2018 17:51:33 +0000 Received: from localhost (localhost [127.0.0.1]) by osg.samsung.com (Postfix) with ESMTP id B267F2E89E; Fri, 12 Jan 2018 09:51:18 -0800 (PST) X-Virus-Scanned: Debian amavisd-new at dev.s-opensource.com Received: from osg.samsung.com ([127.0.0.1]) by localhost (localhost [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id bbqSoit1q9Ef; Fri, 12 Jan 2018 09:51:13 -0800 (PST) Received: from vento.lan (201.86.165.32.dynamic.adsl.gvt.net.br [201.86.165.32]) by osg.samsung.com (Postfix) with ESMTPSA id CB31E2E896; Fri, 12 Jan 2018 09:51:10 -0800 (PST) Date: Fri, 12 Jan 2018 15:51:07 -0200 From: Mauro Carvalho Chehab To: Arnd Bergmann Subject: Re: [PATCH] usb: dwc2: Fix endless deferral probe Message-ID: <20180112155107.39b9d765@vento.lan> In-Reply-To: References: <1515526134-2148-1-git-send-email-stefan.wahren@i2se.com> <7ef21b99-67c8-b246-cc9a-b7202264a7a0@i2se.com> <277384ef-b30c-fb5a-5ffe-1efc15c500bb@i2se.com> Organization: Samsung X-Mailer: Claws Mail 3.15.1-dirty (GTK+ 2.24.31; x86_64-redhat-linux-gnu) MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20180112_095131_486011_B1A3934C X-CRM114-Status: GOOD ( 17.75 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Stefan Wahren , Felipe Balbi , Florian Fainelli , John Youn , Greg Kroah-Hartman , linux-usb@vger.kernel.org, Minas Harutyunyan , Kishon Vijay Abraham I , Eric Anholt , Hans Verkuil , Linux ARM Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org X-Virus-Scanned: ClamAV using ClamSMTP Em Fri, 12 Jan 2018 10:18:59 +0100 Arnd Bergmann escreveu: > On Fri, Jan 12, 2018 at 9:06 AM, Stefan Wahren wrote: > > Am 12.01.2018 um 00:32 schrieb Arnd Bergmann: > >> On Wed, Jan 10, 2018 at 1:15 PM, Stefan Wahren > > >> diff --git a/drivers/phy/phy-core.c b/drivers/phy/phy-core.c > >> index b4964b067aec..93b55fb71d54 100644 > >> --- a/drivers/phy/phy-core.c > >> +++ b/drivers/phy/phy-core.c > >> @@ -410,6 +410,10 @@ static struct phy *_of_phy_get(struct device_node > >> *np, int index) > >> if (ret) > >> return ERR_PTR(-ENODEV); > >> > >> + /* This phy type handled by the usb-phy subsystem for now */ > >> + if (of_device_is_compatible(np, "usb-nop-xceiv")) > >> + return ERR_PTR(-ENODEV); > >> + > >> mutex_lock(&phy_provider_mutex); > >> phy_provider = of_phy_provider_lookup(args.np); > >> if (IS_ERR(phy_provider) || !try_module_get(phy_provider->owner)) > >> { > > > > > > I tried this, but it doesn't work. "np" is the node of the USB controller, > > not of the phy? > > Correct, that was a really dumb mistake on my end, I'm glad I asked > you to try it first. > > I'll fix it up and send the right version with a proper changelog right away. I suspect you meant to do, instead: (e. g. args.np, instead of np). The above works for me on RPi3: $ uname -a Linux raspberrypi 4.15.0-rc7-mcc+ #28 SMP Fri Jan 12 12:35:19 EST 2018 armv7l GNU/Linux $ lsusb Bus 001 Device 005: ID 045e:0750 Microsoft Corp. Wired Keyboard 600 Bus 001 Device 004: ID 0572:960c Conexant Systems (Rockwell), Inc. DVBSky S960C DVB-S2 tuner Bus 001 Device 003: ID 0424:ec00 Standard Microsystems Corp. SMSC9512/9514 Fast Ethernet Adapter Bus 001 Device 002: ID 0424:9514 Standard Microsystems Corp. SMC9514 Hub Bus 001 Device 001: ID 1d6b:0002 Linux Foundation 2.0 root hub So, if you change np -> args.np, feel free to add my: Tested-by: Mauro Carvalho Chehab Regards, Mauro diff --git a/drivers/phy/phy-core.c b/drivers/phy/phy-core.c index b4964b067aec..584cc1469f7d 100644 --- a/drivers/phy/phy-core.c +++ b/drivers/phy/phy-core.c @@ -410,6 +410,10 @@ static struct phy *_of_phy_get(struct device_node *np, int index) if (ret) return ERR_PTR(-ENODEV); + /* This phy type handled by the usb-phy subsystem for now */ + if (of_device_is_compatible(args.np, "usb-nop-xceiv")) + return ERR_PTR(-ENODEV); + mutex_lock(&phy_provider_mutex); phy_provider = of_phy_provider_lookup(args.np); if (IS_ERR(phy_provider) || !try_module_get(phy_provider->owner)) {