| Message ID | 20180115163719.1736753-1-arnd@arndb.de (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Mon, Jan 15, 2018 at 5:37 PM, Arnd Bergmann <arnd@arndb.de> wrote: > The clcd device is lacking an interrupt-parent property, which makes > the interrupt unusable and shows up as a warning with the latest > dtc version: > > arch/arm/boot/dts/ste-nomadik-s8815.dtb: Warning (interrupts_property): Missing interrupt-parent for /amba/clcd@10120000 > arch/arm/boot/dts/ste-nomadik-nhk15.dtb: Warning (interrupts_property): Missing interrupt-parent for /amba/clcd@10120000 > > I looked up the old board files and found that this interrupt has > the same irqchip as all the other on-chip device, it just needs one > extra line. > > Fixes: 17470b7da11c ("ARM: dts: add the CLCD LCD display to the NHK15") > Cc: stable@vger.kernel.org > Signed-off-by: Arnd Bergmann <arnd@arndb.de> Reviewed-by: Linus Walleij <linus.walleij@linaro.org> Sorry for not getting to fixing this myself quickly enough. Yours, Linus Walleij
On Tue, Jan 16, 2018 at 8:29 AM, Linus Walleij <linus.walleij@linaro.org> wrote: > On Mon, Jan 15, 2018 at 5:37 PM, Arnd Bergmann <arnd@arndb.de> wrote: > >> The clcd device is lacking an interrupt-parent property, which makes >> the interrupt unusable and shows up as a warning with the latest >> dtc version: >> >> arch/arm/boot/dts/ste-nomadik-s8815.dtb: Warning (interrupts_property): Missing interrupt-parent for /amba/clcd@10120000 >> arch/arm/boot/dts/ste-nomadik-nhk15.dtb: Warning (interrupts_property): Missing interrupt-parent for /amba/clcd@10120000 >> >> I looked up the old board files and found that this interrupt has >> the same irqchip as all the other on-chip device, it just needs one >> extra line. >> >> Fixes: 17470b7da11c ("ARM: dts: add the CLCD LCD display to the NHK15") >> Cc: stable@vger.kernel.org >> Signed-off-by: Arnd Bergmann <arnd@arndb.de> > > Reviewed-by: Linus Walleij <linus.walleij@linaro.org> > > Sorry for not getting to fixing this myself quickly enough. Applied to next/dt, thanks! Arnd
diff --git a/arch/arm/boot/dts/ste-nomadik-stn8815.dtsi b/arch/arm/boot/dts/ste-nomadik-stn8815.dtsi index 68aab50a73ab..733678b75b88 100644 --- a/arch/arm/boot/dts/ste-nomadik-stn8815.dtsi +++ b/arch/arm/boot/dts/ste-nomadik-stn8815.dtsi @@ -750,6 +750,7 @@ reg = <0x10120000 0x1000>; interrupt-names = "combined"; interrupts = <14>; + interrupt-parent = <&vica>; clocks = <&clcdclk>, <&hclkclcd>; clock-names = "clcdclk", "apb_pclk"; status = "disabled";
The clcd device is lacking an interrupt-parent property, which makes the interrupt unusable and shows up as a warning with the latest dtc version: arch/arm/boot/dts/ste-nomadik-s8815.dtb: Warning (interrupts_property): Missing interrupt-parent for /amba/clcd@10120000 arch/arm/boot/dts/ste-nomadik-nhk15.dtb: Warning (interrupts_property): Missing interrupt-parent for /amba/clcd@10120000 I looked up the old board files and found that this interrupt has the same irqchip as all the other on-chip device, it just needs one extra line. Fixes: 17470b7da11c ("ARM: dts: add the CLCD LCD display to the NHK15") Cc: stable@vger.kernel.org Signed-off-by: Arnd Bergmann <arnd@arndb.de> --- arch/arm/boot/dts/ste-nomadik-stn8815.dtsi | 1 + 1 file changed, 1 insertion(+)