From patchwork Wed Jan 31 13:16:31 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andrew Jones X-Patchwork-Id: 10193993 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 1EBBD603EE for ; Wed, 31 Jan 2018 13:16:56 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 12F0728485 for ; Wed, 31 Jan 2018 13:16:56 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 06A0D28565; Wed, 31 Jan 2018 13:16:56 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.2 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,RCVD_IN_DNSWL_MED autolearn=ham version=3.3.1 Received: from bombadil.infradead.org (bombadil.infradead.org [65.50.211.133]) (using TLSv1.2 with cipher AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 85EDD28485 for ; Wed, 31 Jan 2018 13:16:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=wqN+9MmBpTzTV+elZX6VDQJYvaCy2+tYARXYUqSZyzE=; b=P5qrRtZ9QnRSYS FUWN1JHiXqUvQ21Oov/CQ+cLFB7HNfnGXnbxSimkbHYTyFjOJ7+LgdEVlFc0DJw7GLRo+bkjO8Tsi aQhMc2MPn4iy61E4Kc5h8c2r1nWn2NaOUdYxRXDzRNtEvvAaCKHpIE9FLw2+JKSSANT8tyBjv7ElW gKPUWFSy+93m++Pv1q2WsUY/MXzxS2G68VMgazZ9I8j2scMus7xMv+Auwj8RrouenNQ5vhJ3Shvbt vkZ+QptX1G+0w1O9FvvNUCcE6UDr0Df8CweLSRfxaEem5fCT7vhu0ODKy27dij/y265m/1Wt7UwNq d9H3gYpQxqj4y87Qcp9Q==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.89 #1 (Red Hat Linux)) id 1egsFw-0005mk-BO; Wed, 31 Jan 2018 13:16:52 +0000 Received: from mx1.redhat.com ([209.132.183.28]) by bombadil.infradead.org with esmtps (Exim 4.89 #1 (Red Hat Linux)) id 1egsFs-0005ly-Is for linux-arm-kernel@lists.infradead.org; Wed, 31 Jan 2018 13:16:50 +0000 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 3A4A9C0567B3; Wed, 31 Jan 2018 13:16:36 +0000 (UTC) Received: from kamzik.brq.redhat.com (unknown [10.43.2.160]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 830EA5D97E; Wed, 31 Jan 2018 13:16:33 +0000 (UTC) Date: Wed, 31 Jan 2018 14:16:31 +0100 From: Andrew Jones To: Christoffer Dall Subject: Re: [PATCH] KVM: arm/arm64: Fix arch timers with userspace irqchips Message-ID: <20180131131631.hecvgdsa67bhf2gv@kamzik.brq.redhat.com> References: <20180130124609.15076-1-christoffer.dall@linaro.org> <9eb4f221-2aad-8656-912a-4a7e068a23eb@arm.com> <20180131100530.GZ21802@cbox> <560b5cbc-4ac7-a55a-3f11-9a32b1ffc9e0@arm.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.6.0.1 (2016-04-01) X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.32]); Wed, 31 Jan 2018 13:16:36 +0000 (UTC) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Marc Zyngier , kvm@vger.kernel.org, kvmarm@lists.cs.columbia.edu, Stable , linux-arm-kernel@lists.infradead.org Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org X-Virus-Scanned: ClamAV using ClamSMTP On Wed, Jan 31, 2018 at 12:23:09PM +0100, Christoffer Dall wrote: > Did I mention that I hate this feature, which keeps breaking, and > which really isn't covered by a simple kvm-unit-test script? > Doesn't running the kvm-unit-tests' timer tests with '-machine kernel_irqchip=off' exercise at least some of these paths? If so, then the kvm-unit-tests patch below may help Thanks, drew diff --git a/arm/unittests.cfg b/arm/unittests.cfg index 44b98cfc7afde..7c0041e44d5f3 100644 --- a/arm/unittests.cfg +++ b/arm/unittests.cfg @@ -116,3 +116,10 @@ file = timer.flat groups = timer timeout = 2s arch = arm64 + +[timer-userspace-gic] +file = timer.flat +extra_params = -machine kernel_irqchip=off +groups = timer +timeout = 2s +arch = arm64