From patchwork Fri Feb 9 19:27:24 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Marcus Folkesson X-Patchwork-Id: 10209911 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id AECD260596 for ; Fri, 9 Feb 2018 19:30:39 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 9BA442960C for ; Fri, 9 Feb 2018 19:30:39 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 8FF3E2960E; Fri, 9 Feb 2018 19:30:39 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.2 required=2.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED, DKIM_VALID, FREEMAIL_FROM, RCVD_IN_DNSWL_MED autolearn=ham version=3.3.1 Received: from bombadil.infradead.org (bombadil.infradead.org [65.50.211.133]) (using TLSv1.2 with cipher AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id F1C1D29619 for ; Fri, 9 Feb 2018 19:30:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:MIME-Version:Cc:List-Subscribe: List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id:References: In-Reply-To:Message-Id:Date:Subject:To:From:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Owner; bh=Pom+Ku3RH/gQwcomEEsUFFKH/dxlJ5pmbiYSIdNfKBw=; b=Xjv9nC/aFVTWi6//oORUUPTE5M ALqR60T1ee+XW7t+7dIIPUx+lbyLgdAdsXbpHLcG7fTuJOf+m3Itf1CoZTGui4tPPGpeIUgZKbZvR pAdcWNPkF9p3+AUnkNGMV5EX0c2HMAiYnFktGPh3BOslr6sUwJx7WOazy1Yup11Wx/MPwWRF7e+2w PxuGi680u4tRTstGUky9k5QB8MQ/FeYwY5mPKcQ5lGr8YoDbagFEYgrT0E9JTX7+xJJ/6R1/kfQgd IlkQ7fTjsINuabrDHQgQYMW1nSmH3FwUYMAbFvOH+ivCjybrd1+AYTQQ74Aijr9V05vG67HMwKyJz gbp0c3sg==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.89 #1 (Red Hat Linux)) id 1ekENS-0005Hz-Ph; Fri, 09 Feb 2018 19:30:30 +0000 Received: from mail-lf0-x244.google.com ([2a00:1450:4010:c07::244]) by bombadil.infradead.org with esmtps (Exim 4.89 #1 (Red Hat Linux)) id 1ekELT-0001j4-SJ; Fri, 09 Feb 2018 19:28:31 +0000 Received: by mail-lf0-x244.google.com with SMTP id f136so12660684lff.8; Fri, 09 Feb 2018 11:28:17 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=7/JGLW6QF0o2tE8qhT47lTA1bVmuhmI7KrieBH5NS6Q=; b=q8fxWP1CnDKlNSWRP0pDvgltVTCK/MI8FYSbQqc1RKW+C8LSYV8VWtPOKi079Xcnqy bhcLBvaL6EHZuIq93YAxX7CBd7t5BcgnEjMnsW8IzfTTO2jjA3KoyZ8YLeBOMx57+RIp ZeIs7QDzK7CiWraxSxO9RLf78PNZ7Em4zdj86TUVftaa71HNADLygaDz5ElDeq635ubp r/1M+mrldWpqdojtOegMk9XkPtgRtC5N/Wn2VVDNwP2DDpiQdTlT7UrR+qI459BcXDVV VPwn+DgM5NSdHHPE+3hTAGSbF2TBTECT4uZD+6LaXrM3QKzScVMb4C+gK6sCbvtR2t44 ynxQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=7/JGLW6QF0o2tE8qhT47lTA1bVmuhmI7KrieBH5NS6Q=; b=a5I0VE7PLrdIsuNX5Ip8VBs3/d82ChzqJTTsFXT1hX37W1FbjyVZqEOgNM9AbTQPxl 5ZYM72QTHDhNVf9rUNICzZ7O5RxGBiuiks57b0D1psTgVmT6JBByO7iCdSmATL30qFZx A+e51lsvXZg2lJF1mpVGTanRf3YMNdmTiMT3B6WqjVFveBVuamjPZR9B/KsZW992wXIJ VflGKe0aWP61WEFRDJY3WZaDrrdGIunwC64KN9E9BrV3CgAkPPLjsVK6Vrl5yNm4f08W XP8vsUaIU0WmPVAo3rmH3zU1vvRNTOfKjTpoHkIGz0VDdPFV0995u3jlWPxRLl/EkSaQ cuzg== X-Gm-Message-State: APf1xPD+tbzzvRnbE2kne+R8//F7EP7AKZN1OPqi4jRsdMRSf9OrL2RY NcD3j2alAs0aYeVQW8dtx9A= X-Google-Smtp-Source: AH8x226WmOYQ7ZtMsr5B6vEIJRRaGw6XQPNdWlW7vsG5T0p0R3hg+BervHK9qzdk2+CL7OpwWmeKlw== X-Received: by 10.46.89.71 with SMTP id n68mr2482233ljb.40.1518204496221; Fri, 09 Feb 2018 11:28:16 -0800 (PST) Received: from localhost.localdomain (c-2ec27091-74736162.cust.telenor.se. [46.194.112.145]) by smtp.gmail.com with ESMTPSA id e21sm570315lfb.51.2018.02.09.11.28.13 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 09 Feb 2018 11:28:15 -0800 (PST) From: Marcus Folkesson To: Wim Van Sebroeck , Guenter Roeck , Rob Herring , Mark Rutland , Carlo Caione , Kevin Hilman , Matthias Brugger , Barry Song , Maxime Ripard , Chen-Yu Tsai , Linus Walleij , Vladimir Zapolskiy , Sylvain Lemieux , Nicolas Ferre , Alexandre Belloni Subject: [PATCH 7/7] watchdog: coh901327: make use of timeout-secs provided in devicetree Date: Fri, 9 Feb 2018 20:27:24 +0100 Message-Id: <20180209192724.1227-8-marcus.folkesson@gmail.com> X-Mailer: git-send-email 2.15.1 In-Reply-To: <20180209192724.1227-1-marcus.folkesson@gmail.com> References: <20180209192724.1227-1-marcus.folkesson@gmail.com> X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, Marcus Folkesson , linux-watchdog@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mediatek@lists.infradead.org, linux-amlogic@lists.infradead.org, linux-arm-kernel@lists.infradead.org MIME-Version: 1.0 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org X-Virus-Scanned: ClamAV using ClamSMTP watchdog_init_timeout() will allways pick timeout_param since it defaults to a valid timeout. Following best practice described in Documentation/watchdog/watchdog-kernel-api.txt to make use of the parameter logic. Signed-off-by: Marcus Folkesson --- drivers/watchdog/coh901327_wdt.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/watchdog/coh901327_wdt.c b/drivers/watchdog/coh901327_wdt.c index 4410337f4f7f..437f865e5c6b 100644 --- a/drivers/watchdog/coh901327_wdt.c +++ b/drivers/watchdog/coh901327_wdt.c @@ -67,7 +67,7 @@ #define U300_WDOG_IFR_WILL_BARK_IRQ_FORCE_ENABLE 0x0001U /* Default timeout in seconds = 1 minute */ -static unsigned int margin = 60; +static unsigned int margin; static int irq; static void __iomem *virtbase; static struct device *parent;