From patchwork Fri Feb 16 22:30:41 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Pavel Machek X-Patchwork-Id: 10225855 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 711EE602CB for ; Fri, 16 Feb 2018 22:31:17 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 5129F29543 for ; Fri, 16 Feb 2018 22:31:17 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 458EA29683; Fri, 16 Feb 2018 22:31:17 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID autolearn=ham version=3.3.1 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id B9D6C29543 for ; Fri, 16 Feb 2018 22:31:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender:Content-Type: List-Subscribe:List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id: MIME-Version:Message-ID:Subject:To:From:Date:Reply-To:Cc: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To: References:List-Owner; bh=8A2o1KyT2q7mixtb0lXekEdI9getmlRFwHzV4iobjkk=; b=KZy SHm7ITBDGwKX/XEMkDXIV+piCqVtanhKQiQE2hIhGYRtX1nMy7cOsVrWziXss+RYKpAWgwPpLc+EK Wn4+9N0zdSP+p7i9DVP6zgDVW/H6XiHRuiu0Vd1uzQ+SiP+XxlLZnR7KStaJYVuq9O9nKhGMMyMlp xiMfBatL1CiVL/PUgTk2p/lfkukipLsyBjECsEK0HByzeCJRySfYODG76TTF2DDFe2DbT8ZM2MIIQ CiqC+yUZQt7oXOb10RY0fzTanbaY3o3aog6ackxy8UaIzX4An+UnXnOjYzRC5NvoLD1TktmHOtese IHQkbuh7uBE3KmdN0zlj4Yefvu6wcUA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.89 #1 (Red Hat Linux)) id 1emoX0-0002p7-Mt; Fri, 16 Feb 2018 22:31:02 +0000 Received: from atrey.karlin.mff.cuni.cz ([195.113.26.193]) by bombadil.infradead.org with esmtps (Exim 4.89 #1 (Red Hat Linux)) id 1emoWu-0002kj-Vk for linux-arm-kernel@lists.infradead.org; Fri, 16 Feb 2018 22:30:59 +0000 Received: by atrey.karlin.mff.cuni.cz (Postfix, from userid 512) id F013080179; Fri, 16 Feb 2018 23:30:40 +0100 (CET) Date: Fri, 16 Feb 2018 23:30:41 +0100 From: Pavel Machek To: pali.rohar@gmail.com, sre@kernel.org, kernel list , linux-arm-kernel , linux-omap@vger.kernel.org, tony@atomide.com, khilman@kernel.org, aaro.koskinen@iki.fi, ivo.g.dimitrov.75@gmail.com, patrikbachan@gmail.com, serge@hallyn.com, abcloriens@gmail.com, clayton@craftyguy.net, martijn@brixit.nl, sakari.ailus@linux.intel.com, Filip =?utf-8?Q?Matijevi=C4=87?= Subject: Nokia N900 camera in v4.16-rc1: ready for testing? Message-ID: <20180216223041.GA16010@amd> MIME-Version: 1.0 User-Agent: Mutt/1.5.23 (2014-03-12) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20180216_143057_238927_30F79CE9 X-CRM114-Status: GOOD ( 12.29 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org X-Virus-Scanned: ClamAV using ClamSMTP Hi! Camera should work on N900, with v4.16-rc1. Autofocus should work; flash is in the queue. This patch is needed for non-square image. Patched v4l-utils is very much recommened for taking photos. Sakari: any ideas about this one? This is the bug I showed you in Prague... Best regards, Pavel commit b685b7b98fc50149779416b33d234e4f9ff6ad0e Author: Pavel Date: Mon Feb 13 21:26:51 2017 +0100 omap3isp: fix VP2SDR bit so capture (not preview) works This is neccessary for capture (not preview) to work properly on N900. Why is unknown. diff --git a/drivers/media/platform/omap3isp/ispccdc.c b/drivers/media/platform/omap3isp/ispccdc.c index b66276a..6435857 100644 --- a/drivers/media/platform/omap3isp/ispccdc.c +++ b/drivers/media/platform/omap3isp/ispccdc.c @@ -1182,7 +1182,8 @@ static void ccdc_configure(struct isp_ccdc_device *ccdc) /* Use the raw, unprocessed data when writing to memory. The H3A and * histogram modules are still fed with lens shading corrected data. */ - syn_mode &= ~ISPCCDC_SYN_MODE_VP2SDR; +// syn_mode &= ~ISPCCDC_SYN_MODE_VP2SDR; + syn_mode |= ISPCCDC_SYN_MODE_VP2SDR; if (ccdc->output & CCDC_OUTPUT_MEMORY) syn_mode |= ISPCCDC_SYN_MODE_WEN; @@ -1249,6 +1250,8 @@ static void ccdc_configure(struct isp_ccdc_device *ccdc) << ISPCCDC_VERT_LINES_NLV_SHIFT, OMAP3_ISP_IOMEM_CCDC, ISPCCDC_VERT_LINES); + printk("configuring for %d(%d)x%d\n", crop->width, ccdc->video_out.bpl_value, crop->height); + ccdc_config_outlineoffset(ccdc, ccdc->video_out.bpl_value, format->field);