From patchwork Tue Feb 20 15:09:19 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Arnd Bergmann X-Patchwork-Id: 10230229 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 2E611602A7 for ; Tue, 20 Feb 2018 15:10:18 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 1E4F2286DB for ; Tue, 20 Feb 2018 15:10:18 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 12866286E2; Tue, 20 Feb 2018 15:10:18 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID autolearn=ham version=3.3.1 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id A2FD2286DB for ; Tue, 20 Feb 2018 15:10:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:MIME-Version:Cc:List-Subscribe: List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id:Message-Id:Date: Subject:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To: References:List-Owner; bh=BFakFFGCxYa+s741JBnnyV7CXUIgZv5ghvh6CcA4oI8=; b=XIZ Z57wxaUKOScWteV/EH28ZWN3dC+thtusc74wVjmO89mYnzD74Ysz9MTPNN2wxgp5zfNQoBLgQu2gY Z+T+zaJOYtaOYdE9UHUTsB2DCMJvfne/nTJfZY0GlnCWcarwOzgG/nUtLQKJ1WLI5UONgHIaHExZ7 3ttLK+a6xt4ZM9X3j47NhxSfIfwt7Sy8ook3f53L/le13qdh26QzUnNuAStbfWltp/GNLXnw3dkbi v5iOxBEnFQCVGtTmSg+v8xzzjPvp4c6SkvXcD7EtkdE3U78/2d4yKmANr4JmhPXb1im5dtftsWehI ohdA2xSGv1Psv1pi+NCGYAt2XLcklAg==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.89 #1 (Red Hat Linux)) id 1eo9YM-0007aZ-NZ; Tue, 20 Feb 2018 15:09:58 +0000 Received: from mout.kundenserver.de ([212.227.126.135]) by bombadil.infradead.org with esmtps (Exim 4.89 #1 (Red Hat Linux)) id 1eo9YI-0007Xd-R8 for linux-arm-kernel@lists.infradead.org; Tue, 20 Feb 2018 15:09:56 +0000 Received: from wuerfel.lan ([95.208.111.237]) by mrelayeu.kundenserver.de (mreue007 [212.227.15.129]) with ESMTPA (Nemesis) id 0LblS4-1eMlL81cXM-00jJxR; Tue, 20 Feb 2018 16:09:34 +0100 From: Arnd Bergmann To: Russell King Subject: [PATCH] ARM: make CONFIG_DEBUG_WX depend on MMU Date: Tue, 20 Feb 2018 16:09:19 +0100 Message-Id: <20180220150932.3285766-1-arnd@arndb.de> X-Mailer: git-send-email 2.9.0 X-Provags-ID: V03:K0:1pubBCoyK7Vg1tXRaiUowkWqm20Md9suTAdDsnV4jjuPy33aM1q K1GU3Q6Kg6NFzgMbkT35Kc3NIA1CAuEZQXMKbVIVVxq17PM8smSBveu+XCtp8WU/j/bGYfe /imGXFfYEuf8iukRWJJcjc979247qNIbc0UGsJ0+RI9iq6tXoYIRVgdk3t9SmSsfVVLV+t0 MG0FGyTUJjbf9mdIXb69g== X-UI-Out-Filterresults: notjunk:1; V01:K0:ZYwGFYNpsEA=:DXZnnXZYEXPBRl6wo5CJSV TMGvVgya691kufufp48KiS188U88u1ue9PzuSnX30hoCE1jPSkpkh135gyZ0gOW71C0lTEus+ +9x70Jl1dPQhBD1QeFEOy8wHmDqPiLb010ZpNIcxbeBPuQgALJAU26qJ9P7RyMNzKIfeZdfQt Tm0EG6z6+HkfLs1gbTc/0biY39q4U/HhZPu4Qoh2apB5Oz2Wn486rv6nIVXj1ZyfF9jb4q3wg 4gCWGmhq6/yWnEgesb+zLvsekexjEUI2w5V1J3k0M87hk7E9nmUc2TS6B0w43v1E3sQGWFs0O rvgj2Mxlw3ZT3eKJqTX8qknGYWo6ajuvmGwmXkK1FudqlT2T+YDCUlnHoCU5X7m4d5BC7NCYZ Bd6qU+e58DhbUH5su2sdJZZz8DJQPT5X4pFiO1VADMUVDhSSqnWzIhQRAH0U9ZmPyZJ6UmPf8 DOKK3HaH6PCkH9z0+DgyTyazi7C37OTDfN+bEsNIAoKOsZtBaqkd2CJP2y4jxv6SPaVpzOrDH i5eOod9qaYAmZFU3o5WbRNTM1D9LdA/g1PFvFeUgCRlSwgxA9lgTOuJSPcXb4JliaOwks77hj icGVn/JkzdIHwmaaSenMGASDBGGUSz/sgheSmY1I6KAs3Dzf+wnztLnrgz7Z8vd5FFRlD7sau VwbSOG9CvldBhsTqRToqi8+lRBT+VFLgb47R8c9w8YOT20Ws14Tv5dMfyreXjM2AYltLpL7Ei aYWtGBaX5UrmnnSqvl5TfGztg3RbqccFuAgXfg== X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20180220_070955_204365_A87E0C40 X-CRM114-Status: GOOD ( 11.68 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Kees Cook , Arnd Bergmann , Tony Lindgren , linux-kernel@vger.kernel.org, Jinbum Park , Laura Abbott , linux-arm-kernel@lists.infradead.org MIME-Version: 1.0 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org X-Virus-Scanned: ClamAV using ClamSMTP Without CONFIG_MMU, this results in a build failure: ./arch/arm/include/asm/memory.h:92:23: error: initializer element is not constant #define VECTORS_BASE vectors_base arch/arm/mm/dump.c:32:4: note: in expansion of macro 'VECTORS_BASE' { VECTORS_BASE, "Vectors" }, arch/arm/mm/dump.c:71:11: error: 'L_PTE_USER' undeclared here (not in a function); did you mean 'VTIME_USER'? .mask = L_PTE_USER, ^~~~~~~~~~ Obviously the feature only makes sense with an MMU, so let's add the dependency here. Fixes: a8e53c151fe7 ("ARM: 8737/1: mm: dump: add checking for writable and executable") Signed-off-by: Arnd Bergmann Acked-by: Laura Abbott --- arch/arm/Kconfig.debug | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/arm/Kconfig.debug b/arch/arm/Kconfig.debug index 7b3d9c5c73bb..6db106b5b9e9 100644 --- a/arch/arm/Kconfig.debug +++ b/arch/arm/Kconfig.debug @@ -22,6 +22,7 @@ config ARM_PTDUMP_DEBUGFS config DEBUG_WX bool "Warn on W+X mappings at boot" + depends on MMU select ARM_PTDUMP_CORE ---help--- Generate a warning if any W+X mappings are found at boot.