diff mbox

[v2,1/6] staging: vc04_services: Replace "firmware" node with a compatible lookup.

Message ID 20180307185716.17449-1-eric@anholt.net (mailing list archive)
State New, archived
Headers show

Commit Message

Eric Anholt March 7, 2018, 6:57 p.m. UTC
This was requested by Rob Herring in DT bindings review.

Signed-off-by: Eric Anholt <eric@anholt.net>
---
v2: new patch

 drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

Comments

Stefan Wahren March 8, 2018, 7:30 p.m. UTC | #1
Hi Eric,

> Eric Anholt <eric@anholt.net> hat am 7. März 2018 um 19:57 geschrieben:
> 
> 
> This was requested by Rob Herring in DT bindings review.
> 
> Signed-off-by: Eric Anholt <eric@anholt.net>

Acked-by: Stefan Wahren <stefan.wahren@i2se.com>

for Patches V2: #1, #4, #5

I'm okay with #6 as long as it's unused by any new driver.

Stefan
diff mbox

Patch

diff --git a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c b/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c
index f5cefda49b22..8068c0308b34 100644
--- a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c
+++ b/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c
@@ -3594,7 +3594,8 @@  static int vchiq_probe(struct platform_device *pdev)
 	struct rpi_firmware *fw;
 	int err;
 
-	fw_node = of_parse_phandle(pdev->dev.of_node, "firmware", 0);
+	fw_node = of_find_compatible_node(NULL, NULL,
+					  "raspberrypi,bcm2835-firmware");
 	if (!fw_node) {
 		dev_err(&pdev->dev, "Missing firmware node\n");
 		return -ENOENT;