From patchwork Mon Mar 19 15:49:18 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sasha Levin X-Patchwork-Id: 10292667 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 95B9960385 for ; Mon, 19 Mar 2018 15:51:03 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 844942949D for ; Mon, 19 Mar 2018 15:51:03 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 78E08294A0; Mon, 19 Mar 2018 15:51:03 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID autolearn=ham version=3.3.1 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id E656E2949D for ; Mon, 19 Mar 2018 15:51:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:In-Reply-To:References: Message-ID:Date:Subject:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=F6Z4Zk60isIV/4l0ABZjOjhnCPGK4oB8pPcYXYU0hWM=; b=Ffd+2w/STIV1to fVuhmOwN/eouchAsOjjeMddSXjc+78yW2Hns0Jgh98qwwIHCmToZVNyCqBllKxFtaXpqGyT73xi4A +PJJqiZP/brZONzMeshLW6y5WQvUkH4AOOrVPzZ4FxFtg8/2xqJwdsYzyJUutna8RqDczRzOdWJaN YI+lIvPQXfzKMiNbv5ewpv/Kr2L4p/5R1m497+kcPeaPWBLQLelzFITB/C7tqHAZVtr9WX/SBEQdp 8ffyuL8o5rKxRB3s6hyA4gEFgsJTS1OeZfambPdQshiB4Vuag/r3La9SbGo34pakwq3VkkDf1NbMJ Lt2paDToRhVgZ3dckBBA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1exx3n-00041G-Hg; Mon, 19 Mar 2018 15:50:55 +0000 Received: from mail-bn3nam01on0119.outbound.protection.outlook.com ([104.47.33.119] helo=NAM01-BN3-obe.outbound.protection.outlook.com) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1exx3j-0003xQ-Fd for linux-arm-kernel@lists.infradead.org; Mon, 19 Mar 2018 15:50:53 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=swwkRqHIkL+W04xqRX8Pp7HNFudoJKv3jKiVRaqPj2U=; b=Q8YxkrnJm6aJ3I8y35hjJAdnzlWhAKYWZB8929mQXS6VgohAoroaBCclbwbT72nWRY8wNIghQ3HzMTKKfXK1UK9jk3/PNgvbO3CuZDfbYkvr45m8WuEl51hlShULOV6fCm5eS/R01RlFOIKu2X+IbTsh+hgOd0TN502ApL/ROgU= Received: from DM5PR2101MB1032.namprd21.prod.outlook.com (52.132.128.13) by DM5PR2101MB1063.namprd21.prod.outlook.com (52.132.128.39) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.631.0; Mon, 19 Mar 2018 15:50:37 +0000 Received: from DM5PR2101MB1032.namprd21.prod.outlook.com ([fe80::3d9b:79e7:94eb:5d62]) by DM5PR2101MB1032.namprd21.prod.outlook.com ([fe80::3d9b:79e7:94eb:5d62%5]) with mapi id 15.20.0631.004; Mon, 19 Mar 2018 15:50:37 +0000 From: Sasha Levin To: "linux-kernel@vger.kernel.org" , "stable@vger.kernel.org" Subject: [PATCH AUTOSEL for 4.15 121/124] signal/arm: Document conflicts with SI_USER and SIGFPE Thread-Topic: [PATCH AUTOSEL for 4.15 121/124] signal/arm: Document conflicts with SI_USER and SIGFPE Thread-Index: AQHTv5nWRZ9GVwkWOECfLe8vrUOZow== Date: Mon, 19 Mar 2018 15:49:18 +0000 Message-ID: <20180319154645.11350-121-alexander.levin@microsoft.com> References: <20180319154645.11350-1-alexander.levin@microsoft.com> In-Reply-To: <20180319154645.11350-1-alexander.levin@microsoft.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [52.168.54.252] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1; DM5PR2101MB1063; 7:yTCEDT+uDlVs85rduKyc9nIX7nrzNSiJumvI/tAImv75xg7PDGYpF4L19+z2EIWHS26dWW8bINtTDMSu4ZRZ2TPK817ZKIjq60LBTeQ313ZflTca1sTrXUqO6GbDQa5LUejFav1a9mlc3WuVyXGktnGuTcy/hDFpk6n/etq/IzYXlj13kOiXVyqFNZAh64dZIZI6Hl6ErMyqBdKSUiNzKtYGD9c8fvSo8NoDAhXnF7bEhbtFItHD/sw89knDwdaY; 20:pYtLANcuM9XSmvtjgKa0D86lhoX2AzpRRrV2sAMxgVoCeqbZO0N/Ff0rp1+XYZjD78+9fYeccm48h+EaNnCeBAIjn7p4k56TnV2fAXbXXyBQ3rUB0FxnahUfMJVsQ8HeF4bT5Ytyn+ojx4Dyln33e/B8sjJQfzbWhN4PligUJbM= x-ms-office365-filtering-ht: Tenant x-ms-office365-filtering-correlation-id: 5444294a-d800-46dc-dcb4-08d58db128fc x-microsoft-antispam: UriScan:; BCL:0; PCL:0; RULEID:(7020095)(4652020)(48565401081)(5600026)(4604075)(3008032)(4534165)(4627221)(201703031133081)(201702281549075)(2017052603328)(7193020); SRVR:DM5PR2101MB1063; x-ms-traffictypediagnostic: DM5PR2101MB1063: authentication-results: spf=none (sender IP is ) smtp.mailfrom=Alexander.Levin@microsoft.com; x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:(28532068793085)(89211679590171)(258649278758335)(84791874153150); x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(8211001083)(61425038)(6040522)(2401047)(5005006)(8121501046)(3231221)(944501300)(52105095)(3002001)(93006095)(93001095)(10201501046)(6055026)(61426038)(61427038)(6041310)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123560045)(20161123562045)(20161123564045)(20161123558120)(6072148)(201708071742011); SRVR:DM5PR2101MB1063; BCL:0; PCL:0; RULEID:; SRVR:DM5PR2101MB1063; x-forefront-prvs: 06167FAD59 x-forefront-antispam-report: SFV:NSPM; SFS:(10019020)(396003)(39380400002)(39860400002)(376002)(366004)(346002)(189003)(199004)(10290500003)(68736007)(966005)(110136005)(478600001)(72206003)(36756003)(99286004)(97736004)(10090500001)(305945005)(7736002)(6666003)(2950100002)(107886003)(76176011)(26005)(6436002)(86612001)(54906003)(6486002)(4326008)(186003)(3660700001)(25786009)(53936002)(81166006)(2906002)(2501003)(81156014)(5250100002)(86362001)(2900100001)(5660300001)(8936002)(6116002)(8676002)(1076002)(6306002)(3846002)(3280700002)(66066001)(316002)(59450400001)(6506007)(14454004)(106356001)(22452003)(105586002)(102836004)(6512007)(22906009)(217873001); DIR:OUT; SFP:1102; SCL:1; SRVR:DM5PR2101MB1063; H:DM5PR2101MB1032.namprd21.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; received-spf: None (protection.outlook.com: microsoft.com does not designate permitted sender hosts) x-microsoft-antispam-message-info: AOhUJJxC84IvlntW5jv+j/D9Z+D/imRUAmolsZIXVNQftT/O6hL5/Q5884UTSNGz+YMnbwUbJts638i304GVCrs4jFCdWshWLZylw+beLsZW32Gs5YItZq+KssqE0h5nc6GRZ8awLFTYQ8aMqC3AsFu1Y1ARwAFoERPILaMbGFiHJK0Z7sVgfteqGKw3/gXJzoFXgwjTQx0rlbNXeCfHrwcr7B7ajrQU+53RosQl9/Dd1V0ha4vqUCVyuzbalDjtijloGQh7p4HXTUUWJFQinc1oR9pfeBmuY1W5CN4PNBjSvg8jRvZZmQoblkt1yIKHqQrFhqXrkrQRVW14cFH3bw== spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM MIME-Version: 1.0 X-OriginatorOrg: microsoft.com X-MS-Exchange-CrossTenant-Network-Message-Id: 5444294a-d800-46dc-dcb4-08d58db128fc X-MS-Exchange-CrossTenant-originalarrivaltime: 19 Mar 2018 15:49:18.2334 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 72f988bf-86f1-41af-91ab-2d7cd011db47 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR2101MB1063 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20180319_085051_691796_3CABE734 X-CRM114-Status: GOOD ( 17.50 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Sasha Levin , Russell King , "Eric W. Biederman" , "linux-arm-kernel@lists.infradead.org" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org X-Virus-Scanned: ClamAV using ClamSMTP From: "Eric W. Biederman" [ Upstream commit 7771c66457004977b616bab785209f49d164f527 ] Setting si_code to 0 results in a userspace seeing an si_code of 0. This is the same si_code as SI_USER. Posix and common sense requires that SI_USER not be a signal specific si_code. As such this use of 0 for the si_code is a pretty horribly broken ABI. Further use of si_code == 0 guaranteed that copy_siginfo_to_user saw a value of __SI_KILL and now sees a value of SIL_KILL with the result that uid and pid fields are copied and which might copying the si_addr field by accident but certainly not by design. Making this a very flakey implementation. Utilizing FPE_FIXME, siginfo_layout will now return SIL_FAULT and the appropriate fields will be reliably copied. Possible ABI fixes includee: - Send the signal without siginfo - Don't generate a signal - Possibly assign and use an appropriate si_code - Don't handle cases which can't happen Cc: Russell King Cc: linux-arm-kernel@lists.infradead.org Ref: 451436b7bbb2 ("[ARM] Add support code for ARM hardware vector floating point") History Tree: https://git.kernel.org/pub/scm/linux/kernel/git/tglx/history.git Signed-off-by: "Eric W. Biederman" Signed-off-by: Sasha Levin --- arch/arm/include/uapi/asm/siginfo.h | 13 +++++++++++++ arch/arm/vfp/vfpmodule.c | 2 +- 2 files changed, 14 insertions(+), 1 deletion(-) create mode 100644 arch/arm/include/uapi/asm/siginfo.h diff --git a/arch/arm/include/uapi/asm/siginfo.h b/arch/arm/include/uapi/asm/siginfo.h new file mode 100644 index 000000000000..d0513880be21 --- /dev/null +++ b/arch/arm/include/uapi/asm/siginfo.h @@ -0,0 +1,13 @@ +#ifndef __ASM_SIGINFO_H +#define __ASM_SIGINFO_H + +#include + +/* + * SIGFPE si_codes + */ +#ifdef __KERNEL__ +#define FPE_FIXME 0 /* Broken dup of SI_USER */ +#endif /* __KERNEL__ */ + +#endif diff --git a/arch/arm/vfp/vfpmodule.c b/arch/arm/vfp/vfpmodule.c index a71a48e71fff..03c6a3c72f9c 100644 --- a/arch/arm/vfp/vfpmodule.c +++ b/arch/arm/vfp/vfpmodule.c @@ -257,7 +257,7 @@ static void vfp_raise_exceptions(u32 exceptions, u32 inst, u32 fpscr, struct pt_ if (exceptions == VFP_EXCEPTION_ERROR) { vfp_panic("unhandled bounce", inst); - vfp_raise_sigfpe(0, regs); + vfp_raise_sigfpe(FPE_FIXME, regs); return; }