From patchwork Wed Mar 21 15:28:58 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Paul Kocialkowski X-Patchwork-Id: 10299679 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 5B78D602B3 for ; Wed, 21 Mar 2018 15:31:50 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 4340729876 for ; Wed, 21 Mar 2018 15:31:50 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 37D232987A; Wed, 21 Mar 2018 15:31:50 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID autolearn=ham version=3.3.1 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 91E4129876 for ; Wed, 21 Mar 2018 15:31:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:MIME-Version:Cc:List-Subscribe: List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id:References: In-Reply-To:Message-Id:Date:Subject:To:From:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Owner; bh=DIPRz1mFp0x+lEwNpHP+c4Uda7jtJ6R+QtnXPl/z8IU=; b=nSfKzlnNcHXAR2DZaXGHRr6sSi V3/lddDmWoz4SAXIFCgoe+B0DfPTd+FhUivy913ADyb/4/kIV8z5if4Kk+xykdlNryazbbeDLJLAe eESszo/l/eS/IN1v5ixJjBTN+K9PErCP/X+UAhym2sSake3CJKf3P8ozjFWEAoUCN9k3tQsyNVaYW 788zOKL3WtVS1G9RD7/iX+/WRBjQ5XLEeI08sIbyXv/BaG8YXl1CgKdC98of9N8WhyBFrdgKhRmMI Zdyf+ck5dE4qTUI7udhkx4qaO7YDangSDHAcnKVWHO7ehSVJQgjbrShha+1DLCiieImTuNQQYP1I6 mhARX66w==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1eyfiM-0004WZ-3N; Wed, 21 Mar 2018 15:31:46 +0000 Received: from mail.bootlin.com ([62.4.15.54]) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1eyfhb-00044u-NG for linux-arm-kernel@lists.infradead.org; Wed, 21 Mar 2018 15:31:04 +0000 Received: by mail.bootlin.com (Postfix, from userid 110) id 9D5A52087E; Wed, 21 Mar 2018 16:30:46 +0100 (CET) Received: from localhost.localdomain (LStLambert-657-1-97-87.w90-63.abo.wanadoo.fr [90.63.216.87]) by mail.bootlin.com (Postfix) with ESMTPSA id 312B4203B8; Wed, 21 Mar 2018 16:30:46 +0100 (CET) From: Paul Kocialkowski To: linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-arm-kernel@lists.infradead.org Subject: [PATCH 04/10] drm/sun4i: Explicitly list and check formats supported by the backend Date: Wed, 21 Mar 2018 16:28:58 +0100 Message-Id: <20180321152904.22411-5-paul.kocialkowski@bootlin.com> X-Mailer: git-send-email 2.16.2 In-Reply-To: <20180321152904.22411-1-paul.kocialkowski@bootlin.com> References: <20180321152904.22411-1-paul.kocialkowski@bootlin.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20180321_083100_263756_17942E43 X-CRM114-Status: GOOD ( 17.19 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: David Airlie , Gustavo Padovan , Paul Kocialkowski , Chen-Yu Tsai , Sean Paul , Daniel Vetter , Maxime Ripard MIME-Version: 1.0 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org X-Virus-Scanned: ClamAV using ClamSMTP In order to check whether the backend supports a specific format, an explicit list and a related helper are introduced. They are then used to determine whether the frontend should be used for a layer, when the format is not supported by the backend. Signed-off-by: Paul Kocialkowski --- drivers/gpu/drm/sun4i/sun4i_backend.c | 48 ++++++++++++++++++++++++++++++++++- drivers/gpu/drm/sun4i/sun4i_backend.h | 1 + 2 files changed, 48 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/sun4i/sun4i_backend.c b/drivers/gpu/drm/sun4i/sun4i_backend.c index 274a1db6fa8e..7703ba989743 100644 --- a/drivers/gpu/drm/sun4i/sun4i_backend.c +++ b/drivers/gpu/drm/sun4i/sun4i_backend.c @@ -172,6 +172,39 @@ static int sun4i_backend_drm_format_to_layer(u32 format, u32 *mode) return 0; } +static const uint32_t sun4i_backend_formats[] = { + /* RGB */ + DRM_FORMAT_ARGB4444, + DRM_FORMAT_RGBA4444, + DRM_FORMAT_ARGB1555, + DRM_FORMAT_RGBA5551, + DRM_FORMAT_RGB565, + DRM_FORMAT_RGB888, + DRM_FORMAT_XRGB8888, + DRM_FORMAT_BGRX8888, + DRM_FORMAT_ARGB8888, + /* YUV422 */ + DRM_FORMAT_YUYV, + DRM_FORMAT_YVYU, + DRM_FORMAT_UYVY, + DRM_FORMAT_VYUY, +}; + +bool sun4i_backend_format_is_supported(uint32_t fmt) +{ + bool found = false; + unsigned int i; + + for (i = 0; i < ARRAY_SIZE(sun4i_backend_formats); i++) { + if (sun4i_backend_formats[i] == fmt) { + found = true; + break; + } + } + + return found; +} + int sun4i_backend_update_layer_coord(struct sun4i_backend *backend, int layer, struct drm_plane *plane) { @@ -436,15 +469,28 @@ static bool sun4i_backend_plane_uses_frontend(struct drm_plane_state *state) { struct sun4i_layer *layer = plane_to_sun4i_layer(state->plane); struct sun4i_backend *backend = layer->backend; + struct drm_framebuffer *fb = state->fb; if (IS_ERR(backend->frontend)) return false; + /* + * Let's pretend that every format is either supported by the backend or + * the frontend. This is not true in practice, as some tiling modes are + * not supported by either. There is still room to check this later in + * the atomic check process. + */ + if (!sun4i_backend_format_is_supported(fb->format->format)) + return true; + /* * TODO: Don't use the frontend for x2/x4 scaling and allow RGB formats * with an alpha component then. */ - return sun4i_backend_plane_uses_scaler(state); + if (sun4i_backend_plane_uses_scaler(state)) + return true; + + return false; } static void sun4i_backend_atomic_begin(struct sunxi_engine *engine, diff --git a/drivers/gpu/drm/sun4i/sun4i_backend.h b/drivers/gpu/drm/sun4i/sun4i_backend.h index cb6df2b690c0..a7bfc38f12bd 100644 --- a/drivers/gpu/drm/sun4i/sun4i_backend.h +++ b/drivers/gpu/drm/sun4i/sun4i_backend.h @@ -207,5 +207,6 @@ int sun4i_backend_update_layer_zpos(struct sun4i_backend *backend, int layer, struct drm_plane *plane); void sun4i_backend_disable_layer_frontend(struct sun4i_backend *backend, int layer); +bool sun4i_backend_format_is_supported(uint32_t fmt); #endif /* _SUN4I_BACKEND_H_ */