From patchwork Thu Mar 29 11:04:50 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jacopo Mondi X-Patchwork-Id: 10314911 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 4994C6037E for ; Thu, 29 Mar 2018 11:05:45 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 3C70E2A2DD for ; Thu, 29 Mar 2018 11:05:45 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 3098C2A2ED; Thu, 29 Mar 2018 11:05:45 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID autolearn=ham version=3.3.1 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 4369D2A2DD for ; Thu, 29 Mar 2018 11:05:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender:Content-Type:Cc: List-Subscribe:List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id: In-Reply-To:MIME-Version:References:Message-ID:Subject:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=EgggjcOdFjjcTLG5kdqrnXOG9CnV9VikfUKSlmfk1AM=; b=APs5zq5Q/ANCyLFtSfaQvWc6+ /kGspG5dmVPcJ0Dl8egNVrrWw32DD/wwAnRYPQXyNCTtPVBvEv70EsSWPmguyA++zWhgnyk70yR8Z IQokMbTBFI+O7iywflBZsVclPOOGktgVDT+I6R8E4fTCR5t3oGt2Hn5aYKkgsxrtCBkGLeH6Wqvwx b8ESJpyCTJIMn5dmv+XUeVcCUdMQpKd24DhzdFgocUXktgt+RSUgGI4LMfNq2GBCFiKUzMVyCmlfU SJvEzeX18QLRggaZgl/3Em0KSHHYf+85DzS4iOv0gTPJzjTYuui8BYPaPuiC80Yh1GvyWozN02igc TT9UltFKA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1f1VN6-0002CY-KX; Thu, 29 Mar 2018 11:05:32 +0000 Received: from relay7-d.mail.gandi.net ([217.70.183.200]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1f1VN1-0002Af-EI for linux-arm-kernel@lists.infradead.org; Thu, 29 Mar 2018 11:05:30 +0000 X-Originating-IP: 2.224.242.101 Received: from w540 (unknown [2.224.242.101]) (Authenticated sender: jacopo@jmondi.org) by relay7-d.mail.gandi.net (Postfix) with ESMTPSA id 21D592000D; Thu, 29 Mar 2018 13:04:57 +0200 (CEST) Date: Thu, 29 Mar 2018 13:04:50 +0200 From: jacopo mondi To: Michel Pollet Subject: Re: [PATCH v3 6/8] DT: arm: Add Renesas RZ/N1 SoC base device tree file Message-ID: <20180329110450.GA24193@w540> References: <1522309629-10152-1-git-send-email-michel.pollet@bp.renesas.com> <1522309629-10152-7-git-send-email-michel.pollet@bp.renesas.com> MIME-Version: 1.0 In-Reply-To: <1522309629-10152-7-git-send-email-michel.pollet@bp.renesas.com> User-Agent: Mutt/1.5.24 (2015-08-30) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20180329_040527_778833_59A808EB X-CRM114-Status: GOOD ( 27.73 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Michel Pollet , Mark Rutland , phil.edworthy@renesas.com, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org, Magnus Damm , Russell King , Rob Herring , Sebastian Reichel , linux-renesas-soc@vger.kernel.org, Simon Horman , Lee Jones , linux-arm-kernel@lists.infradead.org Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org X-Virus-Scanned: ClamAV using ClamSMTP Hi Michel The subject of all your patches for arch/arm should start with: ARM: dts: A git log on that directory clearly shows that's the preferred one. I would also say that you are missing a symbol definition in arch/arm/mach-shmobile/Kconfig (even if you got rid of any board file) I would expect a symbol to select in menuconfig, with your dependencies listed there (ie, the serial interface driver) Something like this (I left the 'xx' out from the part name on purpose) But please wait for others (preferibly Geert or Simon) to confim this. On Thu, Mar 29, 2018 at 08:47:02AM +0100, Michel Pollet wrote: > This adds the Renesas RZ/N1 Family (Part #R9A06G0xx) SoC > bare bone support. > > This currently only handles generic parts (gic, architected timer) > and a UART. > For simplicity sake, this also relies on the bootloader to set the > pinctrl and clocks. > > Signed-off-by: Michel Pollet > --- > arch/arm/boot/dts/r9a06g0xx.dtsi | 96 ++++++++++++++++++++++++++++++++++++++++ > 1 file changed, 96 insertions(+) > create mode 100644 arch/arm/boot/dts/r9a06g0xx.dtsi > > diff --git a/arch/arm/boot/dts/r9a06g0xx.dtsi b/arch/arm/boot/dts/r9a06g0xx.dtsi > new file mode 100644 > index 0000000..c6eeee3 > --- /dev/null > +++ b/arch/arm/boot/dts/r9a06g0xx.dtsi > @@ -0,0 +1,96 @@ > +// SPDX-License-Identifier: GPL-2.0 > +/* > + * Base Device Tree Source for the Renesas RZ/N1 SoC Family of devices > + * > + * Copyright (C) 2018 Renesas Electronics Europe Limited > + * > + */ > + > +#include > + > +/ { > + compatible = "renesas,rzn1"; > + #address-cells = <1>; > + #size-cells = <1>; > + > + cpus { > + #address-cells = <1>; > + #size-cells = <0>; > + > + cpu@0 { > + device_type = "cpu"; > + compatible = "arm,cortex-a7"; > + reg = <0>; > + }; > + cpu@1 { > + device_type = "cpu"; > + compatible = "arm,cortex-a7"; > + reg = <1>; > + }; > + }; I see you don't like empy lines, that's fine, it is not a strict requiremen afaik, but I find a few empty lines here and there more redable, expecially if the file is going to grow, as it will be. > + clocks { > + /* > + * this is fixed clock for now, > + * until the clock driver is merged > + */ > + clkuarts: clkuarts { You can remove the node lable if it's the same as the node name afaik > + #clock-cells = <0>; > + compatible = "fixed-clock"; > + clock-frequency = <47619047>; > + }; > + }; Grouping clock nodes under a "clocks" one is now deprecated. Please see, ie. "ARM: dts: r7s72100: stop grouping clocks under a "clocks" subnode" Thanks j > + arch-timer { > + compatible = "arm,cortex-a7-timer", > + "arm,armv7-timer"; > + interrupt-parent = <&gic>; > + arm,cpu-registers-not-fw-configured; > + interrupts = > + + IRQ_TYPE_LEVEL_LOW)>, > + + IRQ_TYPE_LEVEL_LOW)>, > + + IRQ_TYPE_LEVEL_LOW)>, > + + IRQ_TYPE_LEVEL_LOW)>; > + }; > + soc { > + compatible = "simple-bus"; > + #address-cells = <1>; > + #size-cells = <1>; > + interrupt-parent = <&gic>; > + ranges; > + > + gic: gic@44101000 { > + compatible = "arm,cortex-a7-gic", "arm,gic-400"; > + interrupt-controller; > + #interrupt-cells = <3>; > + reg = <0x44101000 0x1000>, /* Distributer */ > + <0x44102000 0x2000>, /* CPU interface */ > + <0x44104000 0x2000>, /* Virt interface control */ > + <0x44106000 0x2000>; /* Virt CPU interface */ > + interrupts = > + + IRQ_TYPE_LEVEL_HIGH)>; > + }; > + sysctrl: sysctrl@4000c000 { > + compatible = "renesas,rzn1-sysctrl", "syscon", > + "simple-mfd"; > + reg = <0x4000c000 0x1000>; > + > + reboot { > + compatible = "renesas,rzn1-reboot"; > + }; > + }; > + uart0: serial@40060000 { > + compatible = "snps,dw-apb-uart"; > + reg = <0x40060000 0x400>; > + interrupts = ; > + reg-shift = <2>; > + reg-io-width = <4>; > + clocks = <&clkuarts>; > + clock-names = "baudclk"; > + status = "disabled"; > + }; > + }; > +}; > -- > 2.7.4 > diff --git a/arch/arm/mach-shmobile/Kconfig b/arch/arm/mach-shmobile/Kconfig index 280e731..9a519330 100644 --- a/arch/arm/mach-shmobile/Kconfig +++ b/arch/arm/mach-shmobile/Kconfig @@ -114,4 +114,8 @@ config ARCH_SH73A0 bool "SH-Mobile AG5 (R8A73A00)" select ARCH_RMOBILE select RENESAS_INTC_IRQPIN + +config ARCH_R9A06G0 + bool "RZ/N1 (R9A06G0)" + select SERIAL_8250_DW endif