| Message ID | 20180427140649.GD19583@mwanda (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On 27/04/18 15:06, Dan Carpenter wrote: > We need to return here instead of setting up the freed sdev device as a > transport. > > Fixes: 907b6d14911d ("firmware: arm_scmi: add per-protocol channels support using idr objects") > Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com> Thanks for the fix, will send to ARM-SoC in the next round.
diff --git a/drivers/firmware/arm_scmi/driver.c b/drivers/firmware/arm_scmi/driver.c index 14b147135a0c..2455be8cbc4f 100644 --- a/drivers/firmware/arm_scmi/driver.c +++ b/drivers/firmware/arm_scmi/driver.c @@ -778,6 +778,7 @@ scmi_create_protocol_device(struct device_node *np, struct scmi_info *info, if (scmi_mbox_chan_setup(info, &sdev->dev, prot_id)) { dev_err(&sdev->dev, "failed to setup transport\n"); scmi_device_destroy(sdev); + return; } /* setup handle now as the transport is ready */
We need to return here instead of setting up the freed sdev device as a transport. Fixes: 907b6d14911d ("firmware: arm_scmi: add per-protocol channels support using idr objects") Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>