From patchwork Thu May 3 19:38:38 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Pavel Machek X-Patchwork-Id: 10379037 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 8459F603B4 for ; Thu, 3 May 2018 19:39:05 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 7839429253 for ; Thu, 3 May 2018 19:39:05 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 6C80F29265; Thu, 3 May 2018 19:39:05 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.9 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,MAILING_LIST_MULTI autolearn=ham version=3.3.1 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 2A93A29253 for ; Thu, 3 May 2018 19:39:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender:Content-Type:Cc: List-Subscribe:List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id: In-Reply-To:MIME-Version:References:Message-ID:Subject:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=wa+2CQopqbZBeA1AW2/D76fUORvVVCnp3sDiUXn5k/Q=; b=amgbwIdk86Z+BJ60/m78K5iZG +jCbJIJ4q46CsYVjcAvdegEy7fq2CF9D1kKZOdQTcb21AAFyGecqRQbmOQM5EDbGze7NRE5tJRFBE 2Upt+MAiBaUG0Q9b7itmat48GvP+YpRNBGs0hX17UYvLb5nlU0+vOh+MqHDckot6ZwEu5xjr+Yk4Z Xj16DqaPICj25fnhpxqLJmhAGZ1vfng0BnMd19oNDTtrROP5/Dt5uRVxAh49ZEeFdkjsC4LW1MJWu 6D8qVgz4N3+I4nihH0Whbj6m42UBSKpYDM4YXTMj3PWrQhyEKtnDVfBVVc5hy8JEPARgHykenIH2K q+5TZgywQ==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1fEK46-00040w-55; Thu, 03 May 2018 19:38:54 +0000 Received: from atrey.karlin.mff.cuni.cz ([195.113.26.193]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1fEK42-0003yM-4z for linux-arm-kernel@lists.infradead.org; Thu, 03 May 2018 19:38:51 +0000 Received: by atrey.karlin.mff.cuni.cz (Postfix, from userid 512) id 8CDD1804E5; Thu, 3 May 2018 21:38:38 +0200 (CEST) Date: Thu, 3 May 2018 21:38:38 +0200 From: Pavel Machek To: Tony Lindgren Subject: Re: Droid 4: very confusing config around OHCI_OMAP3_HCD Message-ID: <20180503193837.GC32572@amd> References: <20180503192510.GB32572@amd> <20180503192838.GY98604@atomide.com> MIME-Version: 1.0 In-Reply-To: <20180503192838.GY98604@atomide.com> User-Agent: Mutt/1.5.23 (2014-03-12) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20180503_123850_364738_068E32D3 X-CRM114-Status: GOOD ( 18.97 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: mpartap@gmx.net, merlijn@wizzup.org, kernel list , sre@kernel.org, nekit1000@gmail.com, linux-omap@vger.kernel.org, linux-arm-kernel Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org X-Virus-Scanned: ClamAV using ClamSMTP On Thu 2018-05-03 12:28:38, Tony Lindgren wrote: > * Pavel Machek [180503 19:27]: > > Hi! > > > > For power management experiments, I tried > > > > CONFIG_USB_OHCI_HCD=y > > CONFIG_USB_OHCI_HCD_OMAP3=m > > CONFIG_USB_OHCI_HCD_PLATFORM=y > > > > and could not find resulting .ko. > > > > Help text says: > > > > CONFIG_USB_OHCI_HCD_OMAP3: > > > > This option is deprecated now and the driver was removed, use > > USB_OHCI_HCD_PLATFORM instead. > > > > Enables support for the on-chip OHCI controller on > > OMAP3 and later chips. > > > > Which may partly explain it. But if the option no longer does > > anything, why keep it? Certainly second part is confusing if option is > > NOP... > > Yeah it's ohci-platform now, I think we decided to keep the old one > around to avoid breaking people's .config files for booting rather > than silently fail. Ok, what about this? (Should I do the same for the other drivers?) Or at least put (DEPRECATED) as other drivers do? Situation is quite confusing if you already have PLATFORM=y. OMAP=m can be selected, but nothing happens. diff --git a/drivers/usb/host/Kconfig b/drivers/usb/host/Kconfig index 5d958da..67c151a 100644 --- a/drivers/usb/host/Kconfig +++ b/drivers/usb/host/Kconfig @@ -455,7 +455,7 @@ config USB_OHCI_HCD_AT91 Atmel chips. config USB_OHCI_HCD_OMAP3 - tristate "OHCI support for OMAP3 and later chips" + tristate "dummy option for backwards compatibility" depends on (ARCH_OMAP3 || ARCH_OMAP4 || SOC_OMAP5) select USB_OHCI_HCD_PLATFORM default y @@ -463,9 +463,6 @@ config USB_OHCI_HCD_OMAP3 This option is deprecated now and the driver was removed, use USB_OHCI_HCD_PLATFORM instead. - Enables support for the on-chip OHCI controller on - OMAP3 and later chips. - config USB_OHCI_HCD_DAVINCI tristate "OHCI support for TI DaVinci DA8xx" depends on ARCH_DAVINCI_DA8XX