| Message ID | 20180508150952.24562-3-robh@kernel.org (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Tue, May 8, 2018 at 10:09 AM, Rob Herring <robh@kernel.org> wrote: > The ETF input should be connected to the funnel output, and the ETF > output should be connected to the replicator input. The labels are wrong > and these got swapped: > > Warning (graph_endpoint): /soc/funnel@821000/ports/port@8/endpoint: graph connection to node '/soc/etf@825000/ports/port@1/endpoint' is not bidirectional > Warning (graph_endpoint): /soc/replicator@824000/ports/port@2/endpoint: graph connection to node '/soc/etf@825000/ports/port@0/endpoint' is not bidirectional > > Fixes: 7c10da373698 ("arm64: dts: qcom: Add msm8916 CoreSight components") > Cc: Ivan T. Ivanov <ivan.ivanov@linaro.org> > Cc: Mathieu Poirier <mathieu.poirier@linaro.org> > Cc: Andy Gross <andy.gross@linaro.org> > Cc: David Brown <david.brown@linaro.org> > Cc: linux-arm-msm@vger.kernel.org > Signed-off-by: Rob Herring <robh@kernel.org> > --- > arch/arm64/boot/dts/qcom/msm8916.dtsi | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) Ping. Still seeing warnings in -next for these. Rob
Quoting Rob Herring (2018-05-23 23:29:29) > On Tue, May 8, 2018 at 10:09 AM, Rob Herring <robh@kernel.org> wrote: > > The ETF input should be connected to the funnel output, and the ETF > > output should be connected to the replicator input. The labels are wrong > > and these got swapped: > > > > Warning (graph_endpoint): /soc/funnel@821000/ports/port@8/endpoint: graph connection to node '/soc/etf@825000/ports/port@1/endpoint' is not bidirectional > > Warning (graph_endpoint): /soc/replicator@824000/ports/port@2/endpoint: graph connection to node '/soc/etf@825000/ports/port@0/endpoint' is not bidirectional > > > > Fixes: 7c10da373698 ("arm64: dts: qcom: Add msm8916 CoreSight components") > > Cc: Ivan T. Ivanov <ivan.ivanov@linaro.org> > > Cc: Mathieu Poirier <mathieu.poirier@linaro.org> > > Cc: Andy Gross <andy.gross@linaro.org> > > Cc: David Brown <david.brown@linaro.org> > > Cc: linux-arm-msm@vger.kernel.org > > Signed-off-by: Rob Herring <robh@kernel.org> > > --- > > arch/arm64/boot/dts/qcom/msm8916.dtsi | 4 ++-- > > 1 file changed, 2 insertions(+), 2 deletions(-) > > Ping. Still seeing warnings in -next for these. > Hi Rob, I no longer have access to this hardware and documentation. I am sure that Mathieu and friends will take care for verification of this patch :-) Regards, Ivan
On 23 May 2018 at 22:48, Ivan T. Ivanov <iivanov.xz@gmail.com> wrote: > Quoting Rob Herring (2018-05-23 23:29:29) >> On Tue, May 8, 2018 at 10:09 AM, Rob Herring <robh@kernel.org> wrote: >> > The ETF input should be connected to the funnel output, and the ETF >> > output should be connected to the replicator input. The labels are wrong >> > and these got swapped: >> > >> > Warning (graph_endpoint): /soc/funnel@821000/ports/port@8/endpoint: graph connection to node '/soc/etf@825000/ports/port@1/endpoint' is not bidirectional >> > Warning (graph_endpoint): /soc/replicator@824000/ports/port@2/endpoint: graph connection to node '/soc/etf@825000/ports/port@0/endpoint' is not bidirectional >> > >> > Fixes: 7c10da373698 ("arm64: dts: qcom: Add msm8916 CoreSight components") >> > Cc: Ivan T. Ivanov <ivan.ivanov@linaro.org> >> > Cc: Mathieu Poirier <mathieu.poirier@linaro.org> >> > Cc: Andy Gross <andy.gross@linaro.org> >> > Cc: David Brown <david.brown@linaro.org> >> > Cc: linux-arm-msm@vger.kernel.org >> > Signed-off-by: Rob Herring <robh@kernel.org> >> > --- >> > arch/arm64/boot/dts/qcom/msm8916.dtsi | 4 ++-- >> > 1 file changed, 2 insertions(+), 2 deletions(-) >> >> Ping. Still seeing warnings in -next for these. >> > > Hi Rob, > > I no longer have access to this hardware and documentation. > I am sure that Mathieu and friends will take care for verification > of this patch :-) The code triggers on the "slave-mode" property rather than the labels, so this patch has no effect on how a path is established. I've tested this on a 410c and things look good. Reviewed-by: Mathieu Poirier <mathieu.poirier@linaro.org> Tested-by: Mathieu Poirier <mathieu.poirier@linaro.org> > > Regards, > Ivan >
On Thu, May 24, 2018 at 10:32:46AM -0600, Mathieu Poirier wrote: <snip> > > > > Hi Rob, > > > > I no longer have access to this hardware and documentation. > > I am sure that Mathieu and friends will take care for verification > > of this patch :-) > > The code triggers on the "slave-mode" property rather than the labels, > so this patch has no effect on how a path is established. I've tested > this on a 410c and things look good. > > Reviewed-by: Mathieu Poirier <mathieu.poirier@linaro.org> > Tested-by: Mathieu Poirier <mathieu.poirier@linaro.org> Thanks for verifying this Matthew. I'll put this in for a fixes as I just sent out my last set for 4.18. Regards, Andy
diff --git a/arch/arm64/boot/dts/qcom/msm8916.dtsi b/arch/arm64/boot/dts/qcom/msm8916.dtsi index 66b318e1de80..aef814b2dc9e 100644 --- a/arch/arm64/boot/dts/qcom/msm8916.dtsi +++ b/arch/arm64/boot/dts/qcom/msm8916.dtsi @@ -1191,14 +1191,14 @@ port@0 { reg = <0>; - etf_out: endpoint { + etf_in: endpoint { slave-mode; remote-endpoint = <&funnel0_out>; }; }; port@1 { reg = <0>; - etf_in: endpoint { + etf_out: endpoint { remote-endpoint = <&replicator_in>; }; };
The ETF input should be connected to the funnel output, and the ETF output should be connected to the replicator input. The labels are wrong and these got swapped: Warning (graph_endpoint): /soc/funnel@821000/ports/port@8/endpoint: graph connection to node '/soc/etf@825000/ports/port@1/endpoint' is not bidirectional Warning (graph_endpoint): /soc/replicator@824000/ports/port@2/endpoint: graph connection to node '/soc/etf@825000/ports/port@0/endpoint' is not bidirectional Fixes: 7c10da373698 ("arm64: dts: qcom: Add msm8916 CoreSight components") Cc: Ivan T. Ivanov <ivan.ivanov@linaro.org> Cc: Mathieu Poirier <mathieu.poirier@linaro.org> Cc: Andy Gross <andy.gross@linaro.org> Cc: David Brown <david.brown@linaro.org> Cc: linux-arm-msm@vger.kernel.org Signed-off-by: Rob Herring <robh@kernel.org> --- arch/arm64/boot/dts/qcom/msm8916.dtsi | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)