| Message ID | 20180511162028.20616-10-brgl@bgdev.pl (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
Hi Bartosz, On Fri, May 11, 2018 at 6:20 PM, Bartosz Golaszewski <brgl@bgdev.pl> wrote: > From: Bartosz Golaszewski <bgolaszewski@baylibre.com> > > Provide a separate section in which pointers to early platform driver > structs will be stored. > > Signed-off-by: Bartosz Golaszewski <bgolaszewski@baylibre.com> Thanks for your patch! > --- a/include/asm-generic/vmlinux.lds.h > +++ b/include/asm-generic/vmlinux.lds.h > @@ -214,6 +214,16 @@ > #define CPU_METHOD_OF_TABLES() OF_TABLE(CONFIG_SMP, cpu_method) > #define CPUIDLE_METHOD_OF_TABLES() OF_TABLE(CONFIG_CPU_IDLE, cpuidle_method) > > +#ifdef CONFIG_EARLY_PLATFORM > +#define EARLY_PLATFORM_DRIVERS_TABLE() \ > + . = ALIGN(8); \ Should this use STRUCT_ALIGN() instead? > + VMLINUX_SYMBOL(__early_platform_drivers_table) = .; \ > + KEEP(*(__early_platform_drivers_table)) \ > + VMLINUX_SYMBOL(__early_platform_drivers_table_end) = .; > +#else > +#define EARLY_PLATFORM_DRIVERS_TABLE() > +#endif Gr{oetje,eeting}s, Geert
2018-05-14 23:29 GMT+02:00 Geert Uytterhoeven <geert@linux-m68k.org>: > Hi Bartosz, > > On Fri, May 11, 2018 at 6:20 PM, Bartosz Golaszewski <brgl@bgdev.pl> wrote: >> From: Bartosz Golaszewski <bgolaszewski@baylibre.com> >> >> Provide a separate section in which pointers to early platform driver >> structs will be stored. >> >> Signed-off-by: Bartosz Golaszewski <bgolaszewski@baylibre.com> > > Thanks for your patch! > >> --- a/include/asm-generic/vmlinux.lds.h >> +++ b/include/asm-generic/vmlinux.lds.h >> @@ -214,6 +214,16 @@ >> #define CPU_METHOD_OF_TABLES() OF_TABLE(CONFIG_SMP, cpu_method) >> #define CPUIDLE_METHOD_OF_TABLES() OF_TABLE(CONFIG_CPU_IDLE, cpuidle_method) >> >> +#ifdef CONFIG_EARLY_PLATFORM >> +#define EARLY_PLATFORM_DRIVERS_TABLE() \ >> + . = ALIGN(8); \ > > Should this use STRUCT_ALIGN() instead? > No, we're only using it to store pointers to structs, not the actual struct early_platform_driver objects. >> + VMLINUX_SYMBOL(__early_platform_drivers_table) = .; \ >> + KEEP(*(__early_platform_drivers_table)) \ >> + VMLINUX_SYMBOL(__early_platform_drivers_table_end) = .; >> +#else >> +#define EARLY_PLATFORM_DRIVERS_TABLE() >> +#endif > > Gr{oetje,eeting}s, > > Geert > > -- > Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org > > In personal conversations with technical people, I call myself a hacker. But > when I'm talking to journalists I just say "programmer" or something like that. > -- Linus Torvalds Thanks, Bartosz
diff --git a/include/asm-generic/vmlinux.lds.h b/include/asm-generic/vmlinux.lds.h index af240573e482..6b5205f30ef2 100644 --- a/include/asm-generic/vmlinux.lds.h +++ b/include/asm-generic/vmlinux.lds.h @@ -214,6 +214,16 @@ #define CPU_METHOD_OF_TABLES() OF_TABLE(CONFIG_SMP, cpu_method) #define CPUIDLE_METHOD_OF_TABLES() OF_TABLE(CONFIG_CPU_IDLE, cpuidle_method) +#ifdef CONFIG_EARLY_PLATFORM +#define EARLY_PLATFORM_DRIVERS_TABLE() \ + . = ALIGN(8); \ + VMLINUX_SYMBOL(__early_platform_drivers_table) = .; \ + KEEP(*(__early_platform_drivers_table)) \ + VMLINUX_SYMBOL(__early_platform_drivers_table_end) = .; +#else +#define EARLY_PLATFORM_DRIVERS_TABLE() +#endif + #ifdef CONFIG_ACPI #define ACPI_PROBE_TABLE(name) \ . = ALIGN(8); \ @@ -593,6 +603,7 @@ RESERVEDMEM_OF_TABLES() \ TIMER_OF_TABLES() \ IOMMU_OF_TABLES() \ + EARLY_PLATFORM_DRIVERS_TABLE() \ CPU_METHOD_OF_TABLES() \ CPUIDLE_METHOD_OF_TABLES() \ KERNEL_DTB() \