From patchwork Tue May 22 21:59:35 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Nathan Chancellor X-Patchwork-Id: 10419665 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 7DFE6600CC for ; Tue, 22 May 2018 21:59:44 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 695AE28E98 for ; Tue, 22 May 2018 21:59:44 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 5D84228F51; Tue, 22 May 2018 21:59:44 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.9 required=2.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED, DKIM_VALID, FREEMAIL_FROM, MAILING_LIST_MULTI autolearn=ham version=3.3.1 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id EDE8928F37 for ; Tue, 22 May 2018 21:59:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:MIME-Version:Cc:List-Subscribe: List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id:Message-Id:Date: Subject:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To: References:List-Owner; bh=7FK8q0sOw31D4vtjdRn9lyIZDgFwv4mOiy2qI7klgz0=; b=Qww BVMjj6Y4urbAC8sioNX/zSIyDcs9tEP1+kzqFCtPBS7HCthDBGzDxDE3V+4tzM6MO8ESESN4fBZid BoF4GJcKzekZJsyK0w99eEItvsnBehNpRlnyK/4ouecJRHSav/HEostZ2UM64/i4MXvQwumn7/iBl WNBypGpJusgfk48sMXXY/kVdQXID/2Z1BjtSP/iO65TFxTIcz9Wtj9fOtPvfVZjKmUjyZk5gVPF+k AIoH9JdYFxS+2NHc5noEJN91Sr6magjbhYTMHWOBO7/oi5dSUR7LAtIOcxj2RjLVv+fHzO834tnd9 qONNJaU2v9jIUAT9j3UTwVz6VKdqHjw==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1fLFJi-0001lj-KO; Tue, 22 May 2018 21:59:38 +0000 Received: from mail-wr0-x244.google.com ([2a00:1450:400c:c0c::244]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1fLFJf-0001kM-7q for linux-arm-kernel@lists.infradead.org; Tue, 22 May 2018 21:59:36 +0000 Received: by mail-wr0-x244.google.com with SMTP id x9-v6so19947866wrl.13 for ; Tue, 22 May 2018 14:59:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id; bh=2o20gFvbDC/3Hr0OwHHRITeGriw/nQ9SDxDc1l9q3MI=; b=viMFsvRnteZRaSVuIhUQH5hlV4QoHNvCqodWjnlN3BLS1zDmKbr7VjXnxQD042LMwF OM0KCOmeshm/WWbGSmZuofEUX5dJx+Nwyzrcw3fMz6VMVJhQA1Yrbgfefhn1sXcSW0BB CztfLAcLvIGgsb9GG1wKOGGNPH/1pBSkFJJZNPgDe17fmPc71iVgIV2KFkTLY9ZYNCVV DFZCeLoNkMiKlWRxNeOozOegzLlQ/X3zYpjMkgB4eapGeNt/QmZH7/BB4Vlsnmf4Seim 3w62z+V65zePeh5gdANuLHFh+wrdUmgLo8F8voAhzLvueFl4qP9kSkfjl+jd+XDcMxHf W08g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=2o20gFvbDC/3Hr0OwHHRITeGriw/nQ9SDxDc1l9q3MI=; b=Glo3oRHiDyj1oAxJ2/Dhohfy6EIkr1je4U7yxno1mYHhlUktc1uh5KC4kfdVnSPnvC TMMW/h5+QFVSNX9nw7ZfGCsvxhr6ghnwVjRtulz+bKUp81Uzht0jXKjJ6nxfWx1h4jn3 LAqfdINvUEbpK4nrh9TGbEYOpUMtzZndLSYgdAhjtl6yiXH29hSE1iEfprEFBy4MR+1X dinBgUwaOF3xyQPBmKAh7Axof6IbweUKqrCGjkwUcOSlL8iNss8SENTYqgPBGLxLNyrl PU8jvfeF2VbyQ94FmFEdBcUMZWsA4SYs23nEaNY3Rrg9/FEo0pkpZLbcFtD3pfRHLh9x 5+Sw== X-Gm-Message-State: ALKqPweFSJmXp2oXTKO5tcbhOasdDJgxzZSr8c+kkQVycx/gIiUSvbsU nOhIAZiUBLL+PDHHr/KsMng= X-Google-Smtp-Source: AB8JxZrKrEvrBlXegJ0WUtKin9PGw/6V8VKXnOG8Ne+ZzMIeZvQuVsI4wbRaTuXP7SJ963zwn2mw9Q== X-Received: by 2002:adf:e407:: with SMTP id g7-v6mr147705wrm.143.1527026363036; Tue, 22 May 2018 14:59:23 -0700 (PDT) Received: from flashbox.your-server.de ([2a01:4f8:10b:24a5::2]) by smtp.gmail.com with ESMTPSA id u35-v6sm25021913wrc.29.2018.05.22.14.59.21 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 22 May 2018 14:59:22 -0700 (PDT) From: Nathan Chancellor To: Catalin Marinas , Will Deacon , Kevin Brodsky , Mark Salyzyn , Jeremy Linton Subject: [PATCH] arm64: vdso32: Use full path to Clang instead of relying on PATH Date: Tue, 22 May 2018 14:59:35 -0700 Message-Id: <20180522215935.12029-1-natechancellor@gmail.com> X-Mailer: git-send-email 2.17.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20180522_145935_281785_F0644B74 X-CRM114-Status: GOOD ( 16.98 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Nathan Chancellor , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org MIME-Version: 1.0 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org X-Virus-Scanned: ClamAV using ClamSMTP Currently, in order to build the compat VDSO with Clang, this format has to be used: PATH=${BIN_FOLDER}:${PATH} make CC=clang Prior to the addition of this file, this format would also be acceptable: make CC=${BIN_FOLDER}/clang This is because the vdso32 Makefile uses cc-name instead of CC. After this path, CC will still evaluate to clang for the first case as expected but now the second case will use the specified Clang, rather than the host's copy, which may not be compatible as shown below. /usr/bin/as: unrecognized option '-mfloat-abi=soft' clang-6.0: error: assembler command failed with exit code 1 Signed-off-by: Nathan Chancellor --- Hi everyone, I noticed this issue when building the Pixel 2's kernel. Since this is a supplement to https://patchwork.kernel.org/patch/10186671/, I was instructed by Mark to push it here. I could not find a public git tree for this patch, I am not sure if it has been applied or not so I couldn't add a fixes tag. If there are any other issues, please let me know! Nathan arch/arm64/kernel/vdso32/Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/arm64/kernel/vdso32/Makefile b/arch/arm64/kernel/vdso32/Makefile index 6d44d972e89d..837e877a326b 100644 --- a/arch/arm64/kernel/vdso32/Makefile +++ b/arch/arm64/kernel/vdso32/Makefile @@ -5,7 +5,7 @@ # A mix between the arm64 and arm vDSO Makefiles. ifeq ($(cc-name),clang) - CC_ARM32 := $(cc-name) $(CLANG_TARGET_ARM32) -no-integrated-as + CC_ARM32 := $(CC) $(CLANG_TARGET_ARM32) -no-integrated-as else CC_ARM32 := $(CROSS_COMPILE_ARM32)$(cc-name) endif