From patchwork Fri May 25 15:50:13 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Arnd Bergmann X-Patchwork-Id: 10427851 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id C3FC8601D5 for ; Fri, 25 May 2018 15:52:46 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id B4C072975A for ; Fri, 25 May 2018 15:52:46 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id A85FE29760; Fri, 25 May 2018 15:52:46 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.9 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,MAILING_LIST_MULTI autolearn=ham version=3.3.1 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 0FB5F2975A for ; Fri, 25 May 2018 15:52:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:MIME-Version:Cc:List-Subscribe: List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id:References: In-Reply-To:Message-Id:Date:Subject:To:From:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Owner; bh=09AlQzDTGt9L0tCXTuLKB69/wVOJMrpwKAP7k8oiOB4=; b=tW01/qcKn+hdSiosxcQEaOchT8 gLIvJD0SS+iMYxNttD47gLfHQgCCsxjIIuac9qEDjpM5ja/BmMfAO+pt1DxE4a5gNBYnr+S34d5BY OglDi/RQWB3c70qNjNwOWhVhhKfeKWkhEchkP8cg11wKck84PmiHk/ZJf32fwzbQe7mOoJCJ+vjt8 d9ONoWPoz1cG9J70ndiS6HsF592cEtKATzRU8SavvX8Zk2VDD7ugg1s8dGYhF2dESiThMz3Ew9zY1 S6tonq4t4aJPltOLOlou3XQLTGmpEI5jaKyNx9V0Yd/x+T6N42HO0mQR/9NK6199I+goPO++wrrzo thYJ566g==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1fMF19-0004nS-PN; Fri, 25 May 2018 15:52:35 +0000 Received: from mout.kundenserver.de ([217.72.192.74]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1fMF16-0004m8-MM for linux-arm-kernel@lists.infradead.org; Fri, 25 May 2018 15:52:34 +0000 Received: from wuerfel.lan ([95.208.111.237]) by mrelayeu.kundenserver.de (mreue105 [212.227.15.145]) with ESMTPA (Nemesis) id 0LzJj7-1gQfMt3d5t-014UxT; Fri, 25 May 2018 17:52:15 +0200 From: Arnd Bergmann To: Inki Dae , Joonyoung Shim , Seung-Woo Kim , Kyungmin Park , David Airlie Subject: [PATCH 6/8] drm/exynos: fix scaler_task_done return type Date: Fri, 25 May 2018 17:50:13 +0200 Message-Id: <20180525155030.3667352-6-arnd@arndb.de> X-Mailer: git-send-email 2.9.0 In-Reply-To: <20180525155030.3667352-1-arnd@arndb.de> References: <20180525155030.3667352-1-arnd@arndb.de> X-Provags-ID: V03:K1:IeYDxoepEF3K07loDeAEQjFUqNru020qvDEONZYRpd19ZlaZutS rb9//WJwk8g2uox3LQpnEX8BRpy3hHbs9FxGsOVTCiSpTC33PzsggztvP3I4gIqYVUXQli/ uZHNxYxaoU01Agb5GnZ5vvrmzqGJs4DymfIwRJh9QcdS+fY1y5RPKnepu7Lfl7GkCRrjd5I 4TW84NHyhbKUjHOfcatWA== X-UI-Out-Filterresults: notjunk:1; V01:K0:OgOYizXz/tU=:J07lSl1AFFN+LE2Nr8xk8z Kl+8woDqZHTSKs4yLZbUruY3E77F2dJZkEKxH4+/XtlhB5KpKsNEow2m6ZrR0saY35e4mnBuO rtSQGtLbi9zfopX/y1Sh4NRfSbeNoceN3FD261cJnJLndAu2NBMnJHAFEqj5TZOdqLav7fQ/3 5ALAyWJAnU1iHp/df8MZagsOF/Jl3mg6OdNGr1fZkc7863Jnukfneqx6uW9WpG167q/D3RQ1S hKX+YCoArVD57wMNKAyjZMnRryw4t8y0hMNQ1bXWju3aJdH2pLNTwgge0+y0jQRP9p9WqkpS/ pKQNyfJxyBaohXzcE5LhJIvGzDcBzfmcmppb7yknmddJWvF1JhLzmbZsT3womSeQSkAV/xYL/ oEdPGmnCeDv4jlV5k+GPD/4QFyDBlhytjBHOqxsi0v63NYN0/qmuBkww+VKKr2hKDvM0n504l MXgUxoz9b1V002/m38XfFt+d4fxWmNkS9m8s1JMc4ZCzJ/VWAGubJ8GNyHnGXL/M3je1SE73V 4YnTr/IcH4C67I7G1BMd4CCO8w9Hr0LwBk2NYdxrkTlZbB4kEKn/r8HfZazWSKx0Zkj1WnDbW jgT5lkUT4yu6ojEI5/pC0GavXJ3TCtX3xfLvE2bmRhDn5KpO6dZfmA4WYmiQfjrpryx4P9u1W xdE5lYVZe7FWeuiP36QlsiWOrcTy6Xv0/znTl2T+RsLDi0fthNvg/GgiWvDYgVSEZoMk= X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20180525_085233_035354_348BF6CF X-CRM114-Status: GOOD ( 14.20 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-samsung-soc@vger.kernel.org, Arnd Bergmann , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Kukjin Kim , Krzysztof Kozlowski , Andrzej Pietrasiewicz , linux-arm-kernel@lists.infradead.org, Marek Szyprowski MIME-Version: 1.0 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org X-Virus-Scanned: ClamAV using ClamSMTP Modern gcc versions warn about returning a ternary operator with an 'int' type in a function returning type 'bool': drivers/gpu/drm/exynos/exynos_drm_scaler.c: In function 'scaler_task_done': drivers/gpu/drm/exynos/exynos_drm_scaler.c:402:47: error: ?: using integer constants in boolean context [-Werror=int-in-bool-context] return val & SCALER_INT_STATUS_FRAME_END ? 0 : -EINVAL; From context, it becomes clear that this should have been 'int', so I'm fixing it, along with parenthesizing the expression to make it clearer what is meant here (I got confused at first, after seeing the warning). Fixes: 01fb9185dc18 ("drm/exynos: Add driver for Exynos Scaler module") Signed-off-by: Arnd Bergmann --- drivers/gpu/drm/exynos/exynos_drm_scaler.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/exynos/exynos_drm_scaler.c b/drivers/gpu/drm/exynos/exynos_drm_scaler.c index 63b05b7c846a..4ad49d7782cd 100644 --- a/drivers/gpu/drm/exynos/exynos_drm_scaler.c +++ b/drivers/gpu/drm/exynos/exynos_drm_scaler.c @@ -397,9 +397,9 @@ static inline u32 scaler_get_int_status(struct scaler_context *scaler) return scaler_read(SCALER_INT_STATUS); } -static inline bool scaler_task_done(u32 val) +static inline int scaler_task_done(u32 val) { - return val & SCALER_INT_STATUS_FRAME_END ? 0 : -EINVAL; + return (val & SCALER_INT_STATUS_FRAME_END) ? 0 : -EINVAL; } static irqreturn_t scaler_irq_handler(int irq, void *arg)