From patchwork Sat May 26 02:12:38 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andrey Smirnov X-Patchwork-Id: 10428817 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id ADD1360225 for ; Sat, 26 May 2018 02:14:17 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 9CC0029874 for ; Sat, 26 May 2018 02:14:17 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 9039729877; Sat, 26 May 2018 02:14:17 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.9 required=2.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED, DKIM_VALID, FREEMAIL_FROM, MAILING_LIST_MULTI autolearn=unavailable version=3.3.1 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 2523029874 for ; Sat, 26 May 2018 02:14:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:MIME-Version:Cc:List-Subscribe: List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id:Message-Id:Date: Subject:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To: References:List-Owner; bh=fxgUF5YTftrY1+tYRaLw62JOns6JXdokt9jBoTiK1sI=; b=qEy dVASLXNSd1/eun5UGgJtNL00VLnxbqQHFXKMN/ucWdZST4aH5LMO7qtn/HSGnUT2lDNBX7W0+qCGS MLA8SNb0AE6hb8LfeVMFsN3icpr+Y/hQFeB3AZOykoN6YZZNZp5XJ3fep0d/eFl8N+5IOleQprPZ+ rfy4YcuZiQbmrwksk6Jq6+WThsBkWgaSyLZxm5RFw/A9C8EZiHDLd4PvpkusZ2BnAQ6HMGAK948vD HOmmnby24K/B2MjKw35dnEeawH6Gx+K5PuyMS/kJQYrXasmMw7xtc7ADdHQcVlkj1Uts1iH646O96 I1rjv0GPWWOEpmAFelTYN1VBQ8o+wdQ==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1fMOiZ-0004EU-Hm; Sat, 26 May 2018 02:14:03 +0000 Received: from mail-pl0-x241.google.com ([2607:f8b0:400e:c01::241]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1fMOiV-0004CW-6c for linux-arm-kernel@lists.infradead.org; Sat, 26 May 2018 02:14:00 +0000 Received: by mail-pl0-x241.google.com with SMTP id i5-v6so4110326plt.2 for ; Fri, 25 May 2018 19:13:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id; bh=xhTenzUdTpzsanFbxTwhxwtEua7CWeMgsJyjANhNTuo=; b=ipz2XwCvUEwpGolGk6AJw0/QPIBUgAoAaoGQZ4Vbw3N7S6Oe8RvjSNx5JL0C6utOAP qwE6Wqkd2F/L/W+s5shRVX8swSAntMBXJtcAfzyI6NmoDp8USJEkbFZt8QKLVOqeqj7p 1IMhLofYnjs/XGdL09h4qO+HKyHxaxmGvrEM1fchBgcsXR/5+dwfSIg1Udo4VX+EjIO2 HK3LcfPK63oux35n3IYoWyb4XNAGCyAV2WAvtfRAVuwk2CJeqLi+zAQL0JzRxBPpHa+Y Bl17k+vBMrx4nO/PUPKAM7DJHw9ZOUwjbQ+AS+p/mR0pk/tUK75kUt9IFQ6wweM5TRvD 3w6w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=xhTenzUdTpzsanFbxTwhxwtEua7CWeMgsJyjANhNTuo=; b=j8fXZ0T0sTt+gnm3tKKuphecrvUoSU2f79b3CrN61FpAdQIVQuJmI8T2BIV3eRP8xV 17uJnK5Geh2mDqNNn62cXoW3ficLPLdbfGdjVaqLTtY0WGTmztooLplQU1k0ESmvlZBZ Etit4xUkdxNY3suWurMQ1rp5ZO5IBY7RmAWXIsOmL5/aFyH94WzVxRYhrbnExgPzu3CM IFwrKO/FmIyiSxqbONWKeEAsOCY1GmgHMCqk1KHf9a563I9czaQAweX8L4Zv65N01NPN 4QAW/4HjW1Oh3exZ2YTbZoDdv9eDm1rMWEjKJgu1ZHMsD9YvI/2inXepznpd8pFsRL/9 Fnlw== X-Gm-Message-State: ALKqPwcJroKPl5MXlMBcqKkLqwlHPZZaOwLnYt5x50agk9bSrT22ktPL +F7u+ME8dJj48vn6zmPha4I= X-Google-Smtp-Source: AB8JxZqHsViEgMECnu2LPDkj86DBWrSrOygAjhxtZKTJm+nRsURr+M+7voV23yQwu6tu+M4J7rZHtw== X-Received: by 2002:a17:902:6046:: with SMTP id a6-v6mr4826624plt.59.1527300826005; Fri, 25 May 2018 19:13:46 -0700 (PDT) Received: from localhost.localdomain ([2001:5b0:2b5e:1148:b569:c043:cad0:2d4e]) by smtp.gmail.com with ESMTPSA id o88-v6sm66543347pfa.29.2018.05.25.19.12.54 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Fri, 25 May 2018 19:13:44 -0700 (PDT) From: Andrey Smirnov To: Shawn Guo Subject: [PATCH v2] ARM: dts: imx51-zii-rdu1: Make sure SD1_WP is low Date: Fri, 25 May 2018 19:12:38 -0700 Message-Id: <20180526021238.30753-1-andrew.smirnov@gmail.com> X-Mailer: git-send-email 2.17.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20180525_191359_242342_6ECF109F X-CRM114-Status: GOOD ( 14.06 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Nikita Yushchenko , devicetree@vger.kernel.org, Andrey Smirnov , linux-kernel@vger.kernel.org, Rob Herring , linux-arm-kernel@lists.infradead.org, Fabio Estevam , Chris Healy , Lucas Stach MIME-Version: 1.0 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org X-Virus-Scanned: ClamAV using ClamSMTP Make sure that MX51_PAD_GPIO1_1 does not remain configure as ALT0/SD1_WP (it is out of reset). This is needed because of external pull-up resistor attached to that pad that, when left unchanged, will drive SD1_WP high preventing eSDHC1/eMMC from working correctly. To fix that add a pinmux configuration line configureing the pad to function as a GPIO. While we are at it, add a corresponding output-high GPIO hog in an effort to minimize current consumption. Cc: Nikita Yushchenko Cc: Shawn Guo Cc: Fabio Estevam Cc: Lucas Stach Cc: Chris Healy Cc: Rob Herring Cc: linux-arm-kernel@lists.infradead.org Cc: devicetree@vger.kernel.org Cc: linux-kernel@vger.kernel.org Signed-off-by: Andrey Smirnov Tested-By: Nikita Yushchenko ; + output-high; + }; +}; + &i2c2 { pinctrl-names = "default"; pinctrl-0 = <&pinctrl_i2c2>; @@ -660,6 +671,23 @@ MX51_PAD_SD1_DATA1__SD1_DATA1 0x20d5 MX51_PAD_SD1_DATA2__SD1_DATA2 0x20d5 MX51_PAD_SD1_DATA3__SD1_DATA3 0x20d5 + /* + * GPIO1_1 is not directly used by eSDHC1 in + * any capacity, but earlier versions of RDU1 + * used that pin as WP GPIO for eSDHC3 and + * because of that that pad has an external + * pull-up resistor. This is problematic + * because out of reset the pad is configured + * as ALT0 which serves as SD1_WP, which, when + * pulled high by and external pull-up, will + * inhibit execution of any write request to + * attached eMMC device. + * + * To avoid this problem we configure the pad + * to ALT1/GPIO and avoid driving SD1_WP + * signal high. + */ + MX51_PAD_GPIO1_1__GPIO1_1 0x0000 >; };