From patchwork Tue May 29 15:46:21 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Boris Brezillon X-Patchwork-Id: 10436415 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id C72E960327 for ; Tue, 29 May 2018 16:20:34 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id AB5CD28B83 for ; Tue, 29 May 2018 16:20:34 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id A24EA289E4; Tue, 29 May 2018 16:20:34 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.9 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,MAILING_LIST_MULTI autolearn=unavailable version=3.3.1 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 45BD2289E4 for ; Tue, 29 May 2018 16:20:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=UsYZJtEq6vmgWDLK0Yg8wD7ks2qGJNRXFTyUPVPAID0=; b=ae36Mivq/wcOlt 7ozlFpJm7lcGjQf0QrjBwZZFEEAyjovLdkXvhTmUzc2lFMtXi5lk9PGBMB7ZTq2FYFSaO6wrPsR+O voflAhK5Q6QuYYnRKWzgnfvnvSFDtZViaiuX0N8DQd0F6/6JlFxGogZ1BnjUp73diCGyKy8R01Ejn goyktmNXviNtxYadlkn3PD03EWT7VVh9nXkmMatlEetRbd3CyQbRGLsCU3qdWFYIs4d0CE7YLdM/J RVcF+KQflo9jqEo2Xi+noo3Q/JS7zrZvk7AoU6dXfVHJ5bMpw7+yEUgR4H0VSrHOGQ3T7FlwXY7Z1 MUvdnUvuLEKRrikxFJlw==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1fNhLo-0007F1-KZ; Tue, 29 May 2018 16:19:56 +0000 Received: from merlin.infradead.org ([2001:8b0:10b:1231::1]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1fNh7k-0001Al-6y; Tue, 29 May 2018 16:05:24 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=merlin.20170209; h=Content-Transfer-Encoding:Content-Type: MIME-Version:References:In-Reply-To:Message-ID:Subject:Cc:To:From:Date:Sender :Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help: List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=5qSezRCBsUypJIySD3VNS6wJc58C1r0grwARsc9EmcM=; b=gr8E4zpZCho74aFkHAlM5jWs1x xdWL9XkjWj0Nu9pL4PyEGOArOC/uCVhXTj5KKZ+qcJMnLAhv6G3X0jsF6BsdI4PUgtKTrgIdhA/TP OHN29Dj0r2wmEGSpf4dY3u/WXpvq3nWjSzsaSwyyfiIb9Vf92m1ntHody/RmClbwfMIbB5MpoyEFg hu/Pd/aTVyXLjTsW3N1Kiox/CT9lF4IOfCrZb/F+mn7C0maFJsYhGzbzTZdCu2dNAz2JFuUaT/TdC 2yS9LX16eUR9FOPOklOcgl20OJnZHh46A3ggI3EKcrYeCR4BW+hxX/9gh3+ePGVOocux+xphcYf4a iD9tyHQA==; Received: from mail.bootlin.com ([62.4.15.54]) by merlin.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1fNgpf-0005aR-Sw; Tue, 29 May 2018 15:46:44 +0000 Received: by mail.bootlin.com (Postfix, from userid 110) id 82ECE2085B; Tue, 29 May 2018 17:46:32 +0200 (CEST) Received: from bbrezillon (AAubervilliers-681-1-128-71.w90-88.abo.wanadoo.fr [90.88.9.71]) by mail.bootlin.com (Postfix) with ESMTPSA id 1835E20DB0; Tue, 29 May 2018 17:46:22 +0200 (CEST) Date: Tue, 29 May 2018 17:46:21 +0200 From: Boris Brezillon To: Eugen Hristev Subject: Re: [PATCH] mtd: nand: raw: atmel: add module param to avoid using dma Message-ID: <20180529174621.50a9001a@bbrezillon> In-Reply-To: <1affd186-7f78-8bb0-050e-da82143c2982@microchip.com> References: <20180329131054.22506-1-peda@axentia.se> <20180329154416.5c1a0013@bbrezillon> <20180402142249.7e076a64@bbrezillon> <20180402212843.164d5d21@bbrezillon> <20180402222020.1d344c14@bbrezillon> <20180403091813.5fb5c18c@bbrezillon> <959d826d-1a98-ca22-acee-a4548427fcd3@microchip.com> <024079cb-77ad-9c48-e370-e6e8f2de171b@axentia.se> <9c496531-f7b6-4b9d-dd51-0bfb68ead303@axentia.se> <19d68279-072e-7646-6fdd-8649578229ea@microchip.com> <20180529164911.29820e07@bbrezillon> <20180529171555.19dd723f@bbrezillon> <1affd186-7f78-8bb0-050e-da82143c2982@microchip.com> X-Mailer: Claws Mail 3.15.0-dirty (GTK+ 2.24.31; x86_64-pc-linux-gnu) MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20180529_114644_135007_19D141ED X-CRM114-Status: GOOD ( 19.52 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Alexandre Belloni , Richard Weinberger , Tudor Ambarus , Josh Wu , linux-kernel@vger.kernel.org, Marek Vasut , Ludovic Desroches , linux-mtd@lists.infradead.org, Cyrille Pitchen , Brian Norris , David Woodhouse , Peter Rosin , linux-arm-kernel@lists.infradead.org Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org X-Virus-Scanned: ClamAV using ClamSMTP On Tue, 29 May 2018 18:21:40 +0300 Eugen Hristev wrote: > On 29.05.2018 18:15, Boris Brezillon wrote: > > On Tue, 29 May 2018 18:01:40 +0300 > > Eugen Hristev wrote: > > > >> [...] > >> > >> > >>> > >>> I think you're missing something here. We use the DMA engine in memcpy > >>> mode (SRAM -> DRAM), not in device mode (dev -> DRAM or DRAM -> dev). > >>> So there's no dmas prop defined in the DT and there should not be. > >>> > >>> Regards, > >>> > >>> Boris > >>> > >> > >> Ok, so the memcpy SRAM <-> DRAM will hog the transfer between DRAM and > >> LCD if my understanding is correct. That's the DMA that Peter wants to > >> disable with his patch ? > >> > >> Then we can then try to force NFC SRAM DMA channels to use just DDR port > >> 1 or 2 for memcpy ? > > > > You mean the dmaengine? According to "14.1.3 Master to Slave Access" > > that's already the case. > > > > Only DMAC0 can access the NFC SRAM and it's done through DMAC0:IF0, > > then access to DDR is going through port DDR port 1 (DMAC0:IF1) or 2 > > (DMAC0:IF0). > > If we can make NFC use port 1 only, then HLCDC could have two ports as > master 8 & 9, maybe a better bandwidth. Peter, can you try with the following patch? --->8--- diff --git a/drivers/dma/at_hdmac_regs.h b/drivers/dma/at_hdmac_regs.h index ef3f227ce3e6..2a48e870f292 100644 --- a/drivers/dma/at_hdmac_regs.h +++ b/drivers/dma/at_hdmac_regs.h @@ -124,8 +124,8 @@ #define ATC_SIF(i) (0x3 & (i)) /* Src tx done via AHB-Lite Interface i */ #define ATC_DIF(i) ((0x3 & (i)) << 4) /* Dst tx done via AHB-Lite Interface i */ /* Specify AHB interfaces */ -#define AT_DMA_MEM_IF 0 /* interface 0 as memory interface */ -#define AT_DMA_PER_IF 1 /* interface 1 as peripheral interface */ +#define AT_DMA_MEM_IF 1 /* interface 0 as memory interface */ +#define AT_DMA_PER_IF 0 /* interface 1 as peripheral interface */ #define ATC_SRC_PIP (0x1 << 8) /* Source Picture-in-Picture enabled */ #define ATC_DST_PIP (0x1 << 12) /* Destination Picture-in-Picture enabled */