From patchwork Wed May 30 17:34:14 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andrey Smirnov X-Patchwork-Id: 10439475 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 0F1E7601E9 for ; Wed, 30 May 2018 17:34:58 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id F09D6291A0 for ; Wed, 30 May 2018 17:34:57 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id E56C8291AE; Wed, 30 May 2018 17:34:57 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.9 required=2.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED, DKIM_VALID, FREEMAIL_FROM, MAILING_LIST_MULTI autolearn=ham version=3.3.1 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 7529B29226 for ; Wed, 30 May 2018 17:34:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:MIME-Version:Cc:List-Subscribe: List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id:Message-Id:Date: Subject:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To: References:List-Owner; bh=igwdOQdL2QwvaL6/njDgKiG5csA30gdOKW7GFsay6Jw=; b=YMY RkRPdDVSG+BQLkv2Hat7yqmupIoJilSau9w9+Ae/xV13tyATDxQfTmCBiKPMAn59a46P3tUhloLYv O6AiEKTK5M9n+/TemcrxQ7WedC3N/xnDpgRI/2BQkGDc+VcHrDBYnOQ3bgGS9MCWYUshXemmZdwGK P3W/6hCVfgzv9rqm1xEahvrQs73LujTVwsCtqBsCPjCKnIPNBU1CGBUl0u6K5IS0il838I23MODZK Lk5W0shdaHDvnwdp7IwNRV2HWY+BiRM947D7EVEOyK0NHLP2tdEf89uCUXsFEXPb2QFwTEpEuJzRf Ut209zONWUZCrlSx11kmZAnJsw+UndA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1fO4zr-0006Ub-Fa; Wed, 30 May 2018 17:34:51 +0000 Received: from mail-pl0-x241.google.com ([2607:f8b0:400e:c01::241]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1fO4zo-0006Tb-5h for linux-arm-kernel@lists.infradead.org; Wed, 30 May 2018 17:34:49 +0000 Received: by mail-pl0-x241.google.com with SMTP id c41-v6so11490975plj.10 for ; Wed, 30 May 2018 10:34:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id; bh=elJRYvUTElZnJYzFuIWV6Yo7t3oOWnQ4z+qpm+jw2j8=; b=VLefe2lpCl3l9XlIcxYXLql0cKwzLW7S3y08PQxCXQ/p9X/lNCNqguF/Qi6NGZtURN xOOafd9J++MSZafcslWvRAJvNmi1I+byRVE8i8wCORemMaDnkrsJ+v5xtk7CdAAbfBrN Lh+Ygz0HdjSY/CnfvOdlQLkvd8HC3uOBtEGnTmI35OWOjt2YGW25v059LrKt49O7RHCm BNvokBr96zmztQpWn4HoVu3B3vfNpCCj5ot+ESdW7vuL+wKji2Rp1tzxgaWs9E6rzu85 nMckVIVkoxcu+eEZZHGz7qM6yhhcBtjTXeE41t5uOquggWmcofq0stQHcUp6IhKbfhND zOGg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=elJRYvUTElZnJYzFuIWV6Yo7t3oOWnQ4z+qpm+jw2j8=; b=aChd1k9QZGe8fBixESmr0CK9jwN2urSIipGNbLhKAfC7tXC6/vb+0gfxbGHeTRcr8U BCJWIduhXDj+RlNDVkMpyvuNthvbjngn1CNxz8hRaEj9LGpJwb6oz/W4L1RYA3Vr6c50 rhzrYfrPOzHEcdeFaZiJXtzROaHNYA2E1Jy/nwkwAl/w4oZm2DfQ8XWQ3+319sRxqrt8 GspCzZaN6uCpGT3X31SBaRsktF7xwbXn37zBjw0lZFwrURtrFytlVtwzXJMAA1WtUdEW rIohHKdyou662Six0VLnq0t5rAd41jnU7aCnKkSF+OOS2XTFvrD97NYDVgX/6eOoyapF nVuQ== X-Gm-Message-State: ALKqPwcvURn/0cDoI6wpOIckoZh0Ig+n2pKg0LaELWiF/C/Xr84wJ/RG Xb23skxNBxx0cwQeU46q+DM= X-Google-Smtp-Source: ADUXVKKMF1clviDi3ZNl6/S+Xz0j0Q1cP0NPPoiBnreQ9QzarKUE+HgwyWfwK7heEkR0lZiJkQubZw== X-Received: by 2002:a17:902:7844:: with SMTP id e4-v6mr3663166pln.296.1527701676789; Wed, 30 May 2018 10:34:36 -0700 (PDT) Received: from squirtle.lan (c-24-22-235-96.hsd1.wa.comcast.net. [24.22.235.96]) by smtp.gmail.com with ESMTPSA id r5-v6sm46977466pgp.81.2018.05.30.10.34.35 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Wed, 30 May 2018 10:34:35 -0700 (PDT) From: Andrey Smirnov To: Greg Kroah-Hartman Subject: [PATCH] usb: chipidea: Fix ULPI on imx51 Date: Wed, 30 May 2018 10:34:14 -0700 Message-Id: <20180530173414.6121-1-andrew.smirnov@gmail.com> X-Mailer: git-send-email 2.17.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20180530_103448_253355_4E9DBF5F X-CRM114-Status: GOOD ( 12.89 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Nikita Yushchenko , Peter Chen , Andrey Smirnov , linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Fabio Estevam , Chris Healy , Lucas Stach MIME-Version: 1.0 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org X-Virus-Scanned: ClamAV using ClamSMTP Workaround introduced for i.MX53 in be9cae2479f48 ("usb: chipidea: imx: Fix ULPI on imx53") seems to be applicable in case of i.MX51 as well. Running latest kernel on ZII RDU1 Board (imx51-zii-rdu1.dts) exhibits a kernel frozen on PORTSC access and applying the workaround resolves the issue. Cc: Peter Chen Cc: Greg Kroah-Hartman Cc: Nikita Yushchenko Cc: Fabio Estevam Cc: Lucas Stach Cc: Chris Healy Cc: linux-arm-kernel@lists.infradead.org Cc: linux-kernel@vger.kernel.org Cc: linux-usb@vger.kernel.org Signed-off-by: Andrey Smirnov Reviewed-by: Fabio Estevam Tested-By: Nikita Yushchenko --- drivers/usb/chipidea/ci_hdrc_imx.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/usb/chipidea/ci_hdrc_imx.c b/drivers/usb/chipidea/ci_hdrc_imx.c index e431c5aafe35..19f5f5f2a48a 100644 --- a/drivers/usb/chipidea/ci_hdrc_imx.c +++ b/drivers/usb/chipidea/ci_hdrc_imx.c @@ -291,7 +291,8 @@ static int ci_hdrc_imx_probe(struct platform_device *pdev) pdata.usb_phy = data->phy; - if (of_device_is_compatible(np, "fsl,imx53-usb") && pdata.usb_phy && + if ((of_device_is_compatible(np, "fsl,imx53-usb") || + of_device_is_compatible(np, "fsl,imx51-usb")) && pdata.usb_phy && of_usb_get_phy_mode(np) == USBPHY_INTERFACE_MODE_ULPI) { pdata.flags |= CI_HDRC_OVERRIDE_PHY_CONTROL; data->override_phy_control = true;