From patchwork Fri Jun 1 22:58:22 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Srinivas Kandagatla X-Patchwork-Id: 10444407 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 360A66028F for ; Fri, 1 Jun 2018 23:00:59 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 2646528B0F for ; Fri, 1 Jun 2018 23:00:59 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 1AEBF28B1D; Fri, 1 Jun 2018 23:00:59 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.9 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,MAILING_LIST_MULTI autolearn=unavailable version=3.3.1 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id B095D28B0F for ; Fri, 1 Jun 2018 23:00:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:MIME-Version:Cc:List-Subscribe: List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id:Message-Id:Date: Subject:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To: References:List-Owner; bh=tqaBQS8Xthmy5tGWeqkxi4Uz+LjEL3AGsbJOGngjxy0=; b=Faz 9QLrLeRBbilZmbM3M4RsASwHWywn1/74R9acLcXMmdbVB3ChDukc8kbkeSOAZP/8SilMGvuRxA9v/ 4La0X58eunGKRkDgleUyBFvci1MGPyNx9pz4bWxn9488SEejrH+O49gSg+ARX3lVzOyMW4+26suo1 QXLTZhiPwMkHLQc36KYsdGvUMjXTQPwZ611YEu/dVQYBHnIEij0MZWNH5GEaQtSlno2mhC3/r8Jcr 63h17cHpucW6RN2wZNAV4Z9q2PTrDf/UqgXl0vWRDn4oijU2g7gWkBFBKLB2luEl8OWlOfVQ7HFm4 91Wj3OyZ+4aQy7G0ez/NbJyuc+wSrqA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1fOt2M-0001Io-Ii; Fri, 01 Jun 2018 23:00:46 +0000 Received: from mail-wm0-x241.google.com ([2a00:1450:400c:c09::241]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1fOt2I-0001Eg-DC for linux-arm-kernel@lists.infradead.org; Fri, 01 Jun 2018 23:00:44 +0000 Received: by mail-wm0-x241.google.com with SMTP id 18-v6so5614781wml.2 for ; Fri, 01 Jun 2018 16:00:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id; bh=IdfSceJ2k5e8GqDUG+uLK1tN1pssZ20mCW71Dtf6uaw=; b=hB7srH0puUPmQR9Pxdaf26j7Qk54keawtx/GGf5WVTjuZs5suDSHlv3vHK6Q9hsDFB dDTjVol7xrYcf7c7ZzkKV8l4xCchIOqNfHuZBrVpzUJLka7h+FQulGQ1CIyvD46eSYoJ xJez9B1ngSj4F5RCVsGyi4L8W+izMiXculvLY= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=IdfSceJ2k5e8GqDUG+uLK1tN1pssZ20mCW71Dtf6uaw=; b=KfKvxxpHkcW3fgxe2h/P0Hkk8OD4ebYky98mVcSNeTIdTpVob0c8p9vV8aeh1di/aD PN1Icj3oBhxh6pGkNsxnNK/IEUob9Cx8tqkjAptALeVaeJHluSTpFZfT7d5I+7H65GBx 86u/qgRzYH95amei4ICaV+JTaqOLkLsuQbpT17/gElpOyyZKJlDkdqWGf4b3qqJgXMaz W7g8W0UZXuZh3sSRWwwZz9zgaUG2r+my+q82gMUImm/6WjFAzWa62oz1JYpzBAwFtSI9 km1fJB5H+Ykkrzdky9qSBw+oiZ26Q2YQ+0NdjfKtuRH3PS6cfiJ/Qy9e6XOKFe6TWtR3 bprg== X-Gm-Message-State: ALKqPwe7ZdlTOvWIaBmHSN8qHmHFyKOeLe/6bnz9esCC7SKtdbTvV9V1 cryiwYn0q7AKqMfmNYl+KXNU/w== X-Google-Smtp-Source: ADUXVKLFTqqRMvG7qHfOhsxRtgLlElR5mD9dsbl6px/yREYJWr7fpfmlrlB4uSu+4v9tuGlHtnAcvg== X-Received: by 2002:a1c:e8c6:: with SMTP id f67-v6mr3555267wmi.25.1527894030695; Fri, 01 Jun 2018 16:00:30 -0700 (PDT) Received: from localhost.localdomain (cpc90716-aztw32-2-0-cust92.18-1.cable.virginm.net. [86.26.100.93]) by smtp.gmail.com with ESMTPSA id e63-v6sm347995wma.46.2018.06.01.16.00.29 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Fri, 01 Jun 2018 16:00:30 -0700 (PDT) From: Srinivas Kandagatla To: robh+dt@kernel.org, frowand.list@gmail.com Subject: [PATCH] of: platform: stop accessing invalid dev in of_platform_device_destroy Date: Fri, 1 Jun 2018 23:58:22 +0100 Message-Id: <20180601225822.23439-1-srinivas.kandagatla@linaro.org> X-Mailer: git-send-email 2.16.2 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20180601_160042_470432_EBEDC841 X-CRM114-Status: GOOD ( 12.63 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: rohkumar@qti.qualcomm.com, devicetree@vger.kernel.org, bgoswami@codeaurora.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, Srinivas Kandagatla , linux-arm-kernel@lists.infradead.org MIME-Version: 1.0 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org X-Virus-Scanned: ClamAV using ClamSMTP Immediately after the platform_device_unregister() the device will be cleaned up. Accessing the freed pointer immediately after that will crash the system. Found this bug when kernel is built with CONFIG_PAGE_POISONING and testing loading/unloading audio drivers in a loop on Qcom platforms. Fix this by removing accessing the dev pointer. Below is the carsh trace: Unable to handle kernel paging request at virtual address 6b6b6b6b6b6c03 Mem abort info: ESR = 0x96000021 Exception class = DABT (current EL), IL = 32 bits SET = 0, FnV = 0 EA = 0, S1PTW = 0 Data abort info: ISV = 0, ISS = 0x00000021 CM = 0, WnR = 0 [006b6b6b6b6b6c03] address between user and kernel address ranges Internal error: Oops: 96000021 [#1] PREEMPT SMP Modules linked in: CPU: 2 PID: 1784 Comm: sh Tainted: G W 4.17.0-rc7-02230-ge3a63a7ef641-dirty #204 Hardware name: Qualcomm Technologies, Inc. APQ 8016 SBC (DT) pstate: 80000005 (Nzcv daif -PAN -UAO) pc : clear_bit+0x18/0x2c lr : of_platform_device_destroy+0x64/0xb8 sp : ffff00000c9c3930 x29: ffff00000c9c3930 x28: ffff80003d39b200 x27: ffff000008bb1000 x26: 0000000000000040 x25: 0000000000000124 x24: ffff80003a9a3080 x23: 0000000000000060 x22: ffff00000939f518 x21: ffff80003aa79e98 x20: ffff80003aa3dae0 x19: ffff80003aa3c890 x18: ffff800009feb794 x17: 0000000000000000 x16: 0000000000000000 x15: ffff800009feb790 x14: 0000000000000000 x13: ffff80003a058778 x12: ffff80003a058728 x11: ffff80003a058750 x10: 0000000000000000 x9 : 0000000000000006 x8 : ffff80003a825988 x7 : bbbbbbbbbbbbbbbb x6 : 0000000000000001 x5 : 0000000000000000 x4 : 0000000000000001 x3 : 0000000000000008 x2 : 0000000000000001 x1 : 6b6b6b6b6b6b6c03 x0 : 0000000000000000 Process sh (pid: 1784, stack limit = 0x (ptrval)) Call trace: clear_bit+0x18/0x2c q6afe_remove+0x20/0x38 apr_device_remove+0x30/0x70 device_release_driver_internal+0x170/0x208 device_release_driver+0x14/0x20 bus_remove_device+0xcc/0x150 device_del+0x10c/0x310 device_unregister+0x1c/0x70 apr_remove_device+0xc/0x18 device_for_each_child+0x50/0x80 apr_remove+0x18/0x20 rpmsg_dev_remove+0x38/0x68 device_release_driver_internal+0x170/0x208 device_release_driver+0x14/0x20 bus_remove_device+0xcc/0x150 device_del+0x10c/0x310 device_unregister+0x1c/0x70 qcom_smd_remove_device+0xc/0x18 device_for_each_child+0x50/0x80 qcom_smd_unregister_edge+0x3c/0x70 smd_subdev_remove+0x18/0x28 rproc_stop+0x48/0xd8 rproc_shutdown+0x60/0xe8 state_store+0xbc/0xf8 dev_attr_store+0x18/0x28 sysfs_kf_write+0x3c/0x50 kernfs_fop_write+0x118/0x1e0 __vfs_write+0x18/0x110 vfs_write+0xa4/0x1a8 ksys_write+0x48/0xb0 sys_write+0xc/0x18 el0_svc_naked+0x30/0x34 Code: d2800022 8b400c21 f9800031 9ac32043 (c85f7c22) ---[ end trace 32020935775616a2 ]--- Signed-off-by: Srinivas Kandagatla --- drivers/of/platform.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/of/platform.c b/drivers/of/platform.c index c00d81dfac0b..78c32b93c0e7 100644 --- a/drivers/of/platform.c +++ b/drivers/of/platform.c @@ -544,8 +544,6 @@ int of_platform_device_destroy(struct device *dev, void *data) amba_device_unregister(to_amba_device(dev)); #endif - of_node_clear_flag(dev->of_node, OF_POPULATED); - of_node_clear_flag(dev->of_node, OF_POPULATED_BUS); return 0; } EXPORT_SYMBOL_GPL(of_platform_device_destroy);