From patchwork Tue Jun 5 11:53:19 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Arnd Bergmann X-Patchwork-Id: 10448119 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 787A460467 for ; Tue, 5 Jun 2018 11:54:11 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 6727F2901C for ; Tue, 5 Jun 2018 11:54:11 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 5BCE4290A4; Tue, 5 Jun 2018 11:54:11 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.9 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,MAILING_LIST_MULTI autolearn=ham version=3.3.1 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id E3A822901C for ; Tue, 5 Jun 2018 11:54:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:MIME-Version:Cc:List-Subscribe: List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id:Message-Id:Date: Subject:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To: References:List-Owner; bh=s1hJUnDzBMBvZ2YLBl7hwQi100E49zl/kKdVreiVrGo=; b=eG5 TWdXSCkIIeeJ30P3RpF/1oT1L2ejv/6ZFCGciMOgLcG4EAfkPjqAwTob0qZO+PQMBE3l5kN4ZTw5h CUm7D1ZiZ6j2lIbCNfg/MtAn5F4C5bzJ/MfITDh6/4Mb5/qxB2h0UTUrDDCF2DbRLCGzGY/QewOmQ D3wHZBdiXd7QnYHDQm8hFcrGSz27ayaTBVszcrqFtRmj7gsYBJ40QNjdWVJL8WNDY/gnXV8y3ZpsA bnW82Avj5Xhxe+lK/PhwGU45fXiiFnNJz9SiYU0GsNBehlib9Lgu7kclndg9mqklhR9P1tAjcOroC /LydziQhd0lozEPjyJH4Rp3Sf8Cceqw==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1fQAXE-0000nD-AP; Tue, 05 Jun 2018 11:53:56 +0000 Received: from mout.kundenserver.de ([212.227.126.187]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1fQAX3-0000jy-I2 for linux-arm-kernel@lists.infradead.org; Tue, 05 Jun 2018 11:53:51 +0000 Received: from wuerfel.lan ([95.208.111.237]) by mrelayeu.kundenserver.de (mreue007 [212.227.15.129]) with ESMTPA (Nemesis) id 0LiawD-1g0sBl02dJ-00czBI; Tue, 05 Jun 2018 13:53:32 +0200 From: Arnd Bergmann To: Russell King Subject: [PATCH] ARM: rpc: use designated initializers in ecard_default_ops Date: Tue, 5 Jun 2018 13:53:19 +0200 Message-Id: <20180605115330.1733640-1-arnd@arndb.de> X-Mailer: git-send-email 2.9.0 X-Provags-ID: V03:K1:LUjdmY3vEd2QMazkDsR1SB+EbIymrQ1Pvqv2V6QgDq9n5L/TLsz gYW9t6mszJ3U0T/cAI4msYEDm5svDnZbwrBFwYaw7SjDuf6pPWelBtyWs6ISFEN3oA9JmY8 7/FR2NM0NPwGwwICZJcBwYPkXMn/Y90/pnf6mt1kiGMTC+1lRkVliJKcbA01GgPJFPP35mo Qm9TTSM5OO71/5Y4klE8Q== X-UI-Out-Filterresults: notjunk:1; V01:K0:CONq93MxcEI=:taQMPaTJb1S5ztfAdJ1FN/ g/qRqjwZhOiDa848Ha6BoA/7Vi1/wdi14+qzbEyeXDFMwdvgawb+KVWy5hw80x8/AZ5Z30eVQ HTUDmHEVgn7beLPBEM9QwRsJtly9hha32Bbm3ObAFLkUW4WjKLCmqi9jaXklJD9OeBkaLiVHv wjaO0FGn44niRLOPPz4ZIbf6j1Gnh7jrZyIwpN/sjBcc+CIEY/CT0TWWyO3RMO11pDjPD1f/Z vtKprhZZTniiOJ8hNKOScutNC4aGgpiQa7I5YCWI2/VdTpuK4FtDpV6Ym3fpJX25ELsDEiKaj /WOZIcwsGJ2NsNxYSZ6ICoVMDkcqqO1t1ncMarrqFTMPVDbCSTtLLkB04ZiU0mjeLrF5gLtRs AspqRqSBti2UHaZsudYXR9JZyIE9YPhghWI75J2pBeN4CiEsXne9ZiLb/oIzem+f9qBsYe4RB 5pE3ey5tkZ/PIcBfm+ENqYzxtSA6c8fK672Wdm5joApDZbofA07D/WoUosTpMcC0V7vbhq+UF 4drbppOU8vmAN2RQiKUa5Db8QniF4qpMPsSyzUG9wBzqDZ22A5SRARSC3EOGWZ2JPciCAvJA1 y08GOdq+0jj62crwYJJXb/hpH0UODK6ZNnvUIQqXb6/nbwM1w4mMXBJ0oshRxyS6HWRweNHyD y2qI9O3ympkJ5w5Xo7NM69m0JyATcJ7qCFMQixClNfdHMryW+/FkuMAk1Aosuy3m5lRc= X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20180605_045345_943633_BA24DDD4 X-CRM114-Status: GOOD ( 11.30 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-arm-kernel@lists.infradead.org, Arnd Bergmann , linux-kernel@vger.kernel.org MIME-Version: 1.0 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org X-Virus-Scanned: ClamAV using ClamSMTP When the randstruct plugin is enabled, we get a warning about the use of traditional struct initializers for this structure, which results in incorrect behavior: arch/arm/mach-rpc/ecard.c:416:2: error: positional initialization of field in 'struct' declared with 'designated_init' attribute [-Werror=designated-init] ecard_def_irq_enable, ^~~~~~~~~~~~~~~~~~~~ arch/arm/mach-rpc/ecard.c:416:2: note: (near initialization for 'ecard_default_ops') arch/arm/mach-rpc/ecard.c:416:2: error: invalid initializer arch/arm/mach-rpc/ecard.c:416:2: note: (near initialization for 'ecard_default_ops.') arch/arm/mach-rpc/ecard.c:417:2: error: positional initialization of field in 'struct' declared with 'designated_init' attribute [-Werror=designated-init] ecard_def_irq_disable, ^~~~~~~~~~~~~~~~~~~~~ This changes it to use designated initializers like we do for all other structures. Signed-off-by: Arnd Bergmann --- arch/arm/mach-rpc/ecard.c | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/arch/arm/mach-rpc/ecard.c b/arch/arm/mach-rpc/ecard.c index 39aef4876ed4..d0c4e20de4f3 100644 --- a/arch/arm/mach-rpc/ecard.c +++ b/arch/arm/mach-rpc/ecard.c @@ -413,12 +413,12 @@ static int ecard_def_fiq_pending(ecard_t *ec) } static expansioncard_ops_t ecard_default_ops = { - ecard_def_irq_enable, - ecard_def_irq_disable, - ecard_def_irq_pending, - ecard_def_fiq_enable, - ecard_def_fiq_disable, - ecard_def_fiq_pending + .irqenable = ecard_def_irq_enable, + .irqdisable = ecard_def_irq_disable, + .irqpending = ecard_def_irq_pending, + .fiqenable = ecard_def_fiq_enable, + .fiqdisable = ecard_def_fiq_disable, + .fiqpending = ecard_def_fiq_pending }; /*