diff mbox

[linux-sunxi] ARM: dts: sun8i: h3: Enable dwmac-sun8i on the Beelink X2

Message ID 20180630062720.24225-1-codekipper@gmail.com (mailing list archive)
State New, archived
Headers show

Commit Message

Code Kipper June 30, 2018, 6:27 a.m. UTC 
From: Marcus Cooper <codekipper@gmail.com>

The enabling of the emac was reverted when stability issues were
discovered.

This reverts partially commit 6b0e06df5cad (Revert "ARM: dts:
sun8i: h3: Enable dwmac-sun8i on the Beelink X2")

Signed-off-by: Marcus Cooper <codekipper@gmail.com>
---
 arch/arm/boot/dts/sun8i-h3-beelink-x2.dts | 7 +++++++
 1 file changed, 7 insertions(+)

Comments

Maxime Ripard July 3, 2018, 2:50 p.m. UTC | #1 
Hi,

On Sat, Jun 30, 2018 at 08:27:20AM +0200, codekipper@gmail.com wrote:
> From: Marcus Cooper <codekipper@gmail.com>
> 
> The enabling of the emac was reverted when stability issues were
> discovered.

What stability issues exactly? Have they been fixed? If so, by which
commit?

Maxime
Code Kipper July 3, 2018, 5:19 p.m. UTC | #2 
On 3 July 2018 at 16:50, Maxime Ripard <maxime.ripard@bootlin.com> wrote:
> Hi,
>
> On Sat, Jun 30, 2018 at 08:27:20AM +0200, codekipper@gmail.com wrote:
>> From: Marcus Cooper <codekipper@gmail.com>
>>
>> The enabling of the emac was reverted when stability issues were
>> discovered.
>
> What stability issues exactly? Have they been fixed? If so, by which
> commit?

They were fixed by 4904337fe34f (ARM: dts: sunxi: Restore EMAC changes
(boards)) but this board was missed.
CK
>
> Maxime
>
> --
> Maxime Ripard, Bootlin (formerly Free Electrons)
> Embedded Linux and Kernel engineering
> https://bootlin.com
Maxime Ripard July 4, 2018, 7:44 a.m. UTC | #3 
On Tue, Jul 03, 2018 at 07:19:16PM +0200, Code Kipper wrote:
> On 3 July 2018 at 16:50, Maxime Ripard <maxime.ripard@bootlin.com> wrote:
> > Hi,
> >
> > On Sat, Jun 30, 2018 at 08:27:20AM +0200, codekipper@gmail.com wrote:
> >> From: Marcus Cooper <codekipper@gmail.com>
> >>
> >> The enabling of the emac was reverted when stability issues were
> >> discovered.
> >
> > What stability issues exactly? Have they been fixed? If so, by which
> > commit?
> 
> They were fixed by 4904337fe34f (ARM: dts: sunxi: Restore EMAC changes
> (boards)) but this board was missed.

Please add that to the commit log, and what the issue was.

Maxime
Code Kipper July 4, 2018, 8:30 a.m. UTC | #4 
On 4 July 2018 at 09:44, Maxime Ripard <maxime.ripard@bootlin.com> wrote:
> On Tue, Jul 03, 2018 at 07:19:16PM +0200, Code Kipper wrote:
>> On 3 July 2018 at 16:50, Maxime Ripard <maxime.ripard@bootlin.com> wrote:
>> > Hi,
>> >
>> > On Sat, Jun 30, 2018 at 08:27:20AM +0200, codekipper@gmail.com wrote:
>> >> From: Marcus Cooper <codekipper@gmail.com>
>> >>
>> >> The enabling of the emac was reverted when stability issues were
>> >> discovered.
>> >
>> > What stability issues exactly? Have they been fixed? If so, by which
>> > commit?
>>
>> They were fixed by 4904337fe34f (ARM: dts: sunxi: Restore EMAC changes
>> (boards)) but this board was missed.
>
> Please add that to the commit log, and what the issue was.
(A)CK
>
> Maxime
>
> --
> Maxime Ripard, Bootlin (formerly Free Electrons)
> Embedded Linux and Kernel engineering
> https://bootlin.com
diff mbox

Patch

diff --git a/arch/arm/boot/dts/sun8i-h3-beelink-x2.dts b/arch/arm/boot/dts/sun8i-h3-beelink-x2.dts
index cf1f970b0c6f..5d23667dc2d2 100644
--- a/arch/arm/boot/dts/sun8i-h3-beelink-x2.dts
+++ b/arch/arm/boot/dts/sun8i-h3-beelink-x2.dts
@@ -123,6 +123,13 @@ 
 	status = "okay";
 };
 
+&emac {
+	phy-handle = <&int_mii_phy>;
+	phy-mode = "mii";
+	allwinner,leds-active-low;
+	status = "okay";
+};
+
 &hdmi {
 	status = "okay";
 };