diff mbox

[08/10] arm64: dts: allwinner: a64: NanoPi-A64: Fix PortE voltage

Message ID 20180706085210.17952-9-andre.przywara@arm.com (mailing list archive)
State New, archived
Headers show

Commit Message

Andre Przywara July 6, 2018, 8:52 a.m. UTC
VCC-PE is driven the AXP's ALDO1 regulator, and is connected to the I2C
pins on the RPi2 header. One would expect 3.3 V there, so enable this
regulator and set it to this voltage.

Signed-off-by: Andre Przywara <andre.przywara@arm.com>
---
 arch/arm64/boot/dts/allwinner/sun50i-a64-nanopi-a64.dts | 7 +++++++
 1 file changed, 7 insertions(+)

Comments

Icenowy Zheng July 6, 2018, 9:03 a.m. UTC | #1
于 2018年7月6日 GMT+08:00 下午4:52:08, Andre Przywara <andre.przywara@arm.com> 写到:
>VCC-PE is driven the AXP's ALDO1 regulator, and is connected to the I2C
>pins on the RPi2 header. One would expect 3.3 V there, so enable this
>regulator and set it to this voltage.

However, 3.3V will break the DVP camera (although not yet
supported).

>
>Signed-off-by: Andre Przywara <andre.przywara@arm.com>
>---
> arch/arm64/boot/dts/allwinner/sun50i-a64-nanopi-a64.dts | 7 +++++++
> 1 file changed, 7 insertions(+)
>
>diff --git a/arch/arm64/boot/dts/allwinner/sun50i-a64-nanopi-a64.dts
>b/arch/arm64/boot/dts/allwinner/sun50i-a64-nanopi-a64.dts
>index bd35a093e6cd..0439cff685d6 100644
>--- a/arch/arm64/boot/dts/allwinner/sun50i-a64-nanopi-a64.dts
>+++ b/arch/arm64/boot/dts/allwinner/sun50i-a64-nanopi-a64.dts
>@@ -126,6 +126,13 @@
> 
> #include "axp803.dtsi"
> 
>+&reg_aldo1 {
>+	regulator-always-on;
>+	regulator-min-microvolt = <3300000>;
>+	regulator-max-microvolt = <3300000>;
>+	regulator-name = "vcc-pe";
>+};
>+
> &reg_aldo2 {
> 	regulator-always-on;
> 	regulator-min-microvolt = <1800000>;
Andre Przywara July 6, 2018, 9:39 a.m. UTC | #2
Hi,

On 06/07/18 10:03, Icenowy Zheng wrote:
> 
> 
> 于 2018年7月6日 GMT+08:00 下午4:52:08, Andre Przywara <andre.przywara@arm.com> 写到:
>> VCC-PE is driven the AXP's ALDO1 regulator, and is connected to the I2C
>> pins on the RPi2 header. One would expect 3.3 V there, so enable this
>> regulator and set it to this voltage.
> 
> However, 3.3V will break the DVP camera (although not yet
> supported).

Interesting, so what would the supposed voltage be here? The NanoPi-A64
schematic at least mentions 3.3V for the *supply* pins on that connector
and connects VDD_SYS_3.3V to that. Happy to put any other value for the
I/O here, but it would be problematic to see a different voltage on
those two I2C pins on the RPi2 header.

Cheers,
Andre.

>> Signed-off-by: Andre Przywara <andre.przywara@arm.com>
>> ---
>> arch/arm64/boot/dts/allwinner/sun50i-a64-nanopi-a64.dts | 7 +++++++
>> 1 file changed, 7 insertions(+)
>>
>> diff --git a/arch/arm64/boot/dts/allwinner/sun50i-a64-nanopi-a64.dts
>> b/arch/arm64/boot/dts/allwinner/sun50i-a64-nanopi-a64.dts
>> index bd35a093e6cd..0439cff685d6 100644
>> --- a/arch/arm64/boot/dts/allwinner/sun50i-a64-nanopi-a64.dts
>> +++ b/arch/arm64/boot/dts/allwinner/sun50i-a64-nanopi-a64.dts
>> @@ -126,6 +126,13 @@
>>
>> #include "axp803.dtsi"
>>
>> +&reg_aldo1 {
>> +	regulator-always-on;
>> +	regulator-min-microvolt = <3300000>;
>> +	regulator-max-microvolt = <3300000>;
>> +	regulator-name = "vcc-pe";
>> +};
>> +
>> &reg_aldo2 {
>> 	regulator-always-on;
>> 	regulator-min-microvolt = <1800000>;
Chen-Yu Tsai July 6, 2018, 9:45 a.m. UTC | #3
On Fri, Jul 6, 2018 at 5:39 PM, Andre Przywara <andre.przywara@arm.com> wrote:
> Hi,
>
> On 06/07/18 10:03, Icenowy Zheng wrote:
>>
>>
>> 于 2018年7月6日 GMT+08:00 下午4:52:08, Andre Przywara <andre.przywara@arm.com> 写到:
>>> VCC-PE is driven the AXP's ALDO1 regulator, and is connected to the I2C
>>> pins on the RPi2 header. One would expect 3.3 V there, so enable this
>>> regulator and set it to this voltage.
>>
>> However, 3.3V will break the DVP camera (although not yet
>> supported).
>
> Interesting, so what would the supposed voltage be here? The NanoPi-A64
> schematic at least mentions 3.3V for the *supply* pins on that connector
> and connects VDD_SYS_3.3V to that. Happy to put any other value for the
> I/O here, but it would be problematic to see a different voltage on
> those two I2C pins on the RPi2 header.

AFAIK a whole bunch of cameras use 2.8V as their I/O supply voltage.
This is probably separate from any other core or peripheral voltages
supplied.

ChenYu

> Cheers,
> Andre.
>
>>> Signed-off-by: Andre Przywara <andre.przywara@arm.com>
>>> ---
>>> arch/arm64/boot/dts/allwinner/sun50i-a64-nanopi-a64.dts | 7 +++++++
>>> 1 file changed, 7 insertions(+)
>>>
>>> diff --git a/arch/arm64/boot/dts/allwinner/sun50i-a64-nanopi-a64.dts
>>> b/arch/arm64/boot/dts/allwinner/sun50i-a64-nanopi-a64.dts
>>> index bd35a093e6cd..0439cff685d6 100644
>>> --- a/arch/arm64/boot/dts/allwinner/sun50i-a64-nanopi-a64.dts
>>> +++ b/arch/arm64/boot/dts/allwinner/sun50i-a64-nanopi-a64.dts
>>> @@ -126,6 +126,13 @@
>>>
>>> #include "axp803.dtsi"
>>>
>>> +&reg_aldo1 {
>>> +    regulator-always-on;
>>> +    regulator-min-microvolt = <3300000>;
>>> +    regulator-max-microvolt = <3300000>;
>>> +    regulator-name = "vcc-pe";
>>> +};
>>> +
>>> &reg_aldo2 {
>>>      regulator-always-on;
>>>      regulator-min-microvolt = <1800000>;
diff mbox

Patch

diff --git a/arch/arm64/boot/dts/allwinner/sun50i-a64-nanopi-a64.dts b/arch/arm64/boot/dts/allwinner/sun50i-a64-nanopi-a64.dts
index bd35a093e6cd..0439cff685d6 100644
--- a/arch/arm64/boot/dts/allwinner/sun50i-a64-nanopi-a64.dts
+++ b/arch/arm64/boot/dts/allwinner/sun50i-a64-nanopi-a64.dts
@@ -126,6 +126,13 @@ 
 
 #include "axp803.dtsi"
 
+&reg_aldo1 {
+	regulator-always-on;
+	regulator-min-microvolt = <3300000>;
+	regulator-max-microvolt = <3300000>;
+	regulator-name = "vcc-pe";
+};
+
 &reg_aldo2 {
 	regulator-always-on;
 	regulator-min-microvolt = <1800000>;