From patchwork Fri Jul 6 12:48:47 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Arnd Bergmann X-Patchwork-Id: 10511625 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 4D6A060325 for ; Fri, 6 Jul 2018 12:49:23 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 3D88E285FB for ; Fri, 6 Jul 2018 12:49:23 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 31D4428600; Fri, 6 Jul 2018 12:49:23 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.9 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,MAILING_LIST_MULTI autolearn=ham version=3.3.1 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id E204428618 for ; Fri, 6 Jul 2018 12:49:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:MIME-Version:Cc:List-Subscribe: List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id:Message-Id:Date: Subject:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To: References:List-Owner; bh=KheICf57QTyZ/bTInk2eHOco01HHQspeO/V8JO7toAw=; b=SaN o5V8qu0HSPElphpYAkYyWHxeyMWR9i/s32CkfqjKOBHRsCnXBcVwttCf51GwQ94wUp4AI3FEfehQd 5HzghzlTd+Nv8WtwOu98K7gb83pNdo3bLePnOXPMGbtF1/O4Xbm8wwcM+/gIHLI826luF9mYF+yWv q3SkqB14y1476kBkgasQXK3fBrQaLqaHsB9VaS8ZtPnj2YTfd7l/jg/ml81LObhBG1RD6j6IBVm7j NL+njfGRmpxsHaO4cI4+j1ueg+yp2omEhFAqfJJmjyEllpF6IEfseZuHnb90JsT8ahEbT/VLUErPV d8HZ+NhTKtUqaR3yxqz1C6ibXJ8Pj+g==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1fbQAp-0007XU-Ak; Fri, 06 Jul 2018 12:49:19 +0000 Received: from mout.kundenserver.de ([212.227.17.24]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1fbQAm-0007WU-3s for linux-arm-kernel@lists.infradead.org; Fri, 06 Jul 2018 12:49:18 +0000 Received: from wuerfel.lan ([46.223.138.35]) by mrelayeu.kundenserver.de (mreue104 [212.227.15.145]) with ESMTPA (Nemesis) id 0M1XmT-1gPota1r45-00tPRZ; Fri, 06 Jul 2018 14:49:03 +0200 From: Arnd Bergmann To: Jessica Yu , Russell King Subject: [PATCH] ARM: module: fix modsign build error Date: Fri, 6 Jul 2018 14:48:47 +0200 Message-Id: <20180706124900.3294525-1-arnd@arndb.de> X-Mailer: git-send-email 2.9.0 X-Provags-ID: V03:K1:xOGyPsidIog15L88nfSJv2PQVsq3aWtSU/GyaHNoNTFoyuZxc+x E9SpBcFCYUr2qngnvoVPwlYhL8OqLdjzKNnBZvSeMIShFaBKHYaelUFBqapkaC0d0mmB5p+ yzlQARcnBN4nPHK3BLSlkTiDJB0/7P/x1PqrItvxUfTCu8ZIN20fzvugm9RBYfCo4PZYLCd /EMzcm4lTIgPF4wdi6rKg== X-UI-Out-Filterresults: notjunk:1; V01:K0:ac1ydgGFRw0=:lFr7Hfj7f+1mYNkJDUzpmE iW98jm3xCPVV4OnkWjsfZiGUgrHx3iEa2LwunmT47OLSMNZWnhTNH3ECxd/2PVL0ANw2cqidn 1FY0M+OBM0FblMIw8vmVaFCVL85+Ws5tEnAcCgOwyQjPcgAZeCJzFgQ9HZxpMlIb4Upapz1Pz PsJV/5Jtlpsx/lZPaQr18FLGG1XFh/ky4dgbGnA/8Pc6zyaFAMZsSx9KDYxrxb0PPp9wAMbBs Hz84JKuO6CnO9YRixrUIR2tkuT/ewO8r8dDh7d5gRMD6Tp3Aw1vm5gp9qqrrgZMfv9gC8H+Zv XDNTyjy+ZyVYq5mGRSLNOaofUnFYU0sUzPQRZDFGwQsjywwToQucjebiU6xRCig8SLEZTNOXk mcFtouz2xa+hC9ifb4dRp4s0TefojBP9V4Ri5WrvFJEx+MsM39JYHeOU+wpBg+CZq0NfgiDsT sapKx7/KStMqowc8uEKnIkTBDSPE6If1U6xwOLigIWh5ThRmJ9iNeG4mpZQB3qBEd+KVENaUO 4/gaDw7zcXT15DqNtiqONcn3PUGa90YLnsjSYVdFr7veZKXBbuJJRu32AqP3tiJDSWUQ+q57H vVCjU4hFS2kmxCNUzc+nsqqNCO3m12ZAL75b+8g9Wq8DQ3Rj7nPaNSBLmSf1kn5j1aPbDsHC+ tcykvKFHXQSFjcBFPV/9SfsqDPzXXpBghgVs503LSiYw6RYlBdpe6RtNzgYwyQNIwYhY= X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20180706_054916_457529_5931EDC7 X-CRM114-Status: GOOD ( 13.39 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-arm-kernel@lists.infradead.org, Arnd Bergmann , linux-kernel@vger.kernel.org MIME-Version: 1.0 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org X-Virus-Scanned: ClamAV using ClamSMTP The asm/module.h header file can not be included standalone, which breaks the module signing code after a recent change: In file included from kernel/module-internal.h:13, from kernel/module_signing.c:17: arch/arm/include/asm/module.h:37:27: error: 'struct module' declared inside parameter list will not be visible outside of this definition or declaration [-Werror] u32 get_module_plt(struct module *mod, unsigned long loc, Elf32_Addr val); This adds a forward declaration of struct module to make it all work. Fixes: f314dfea16a0 ("modsign: log module name in the event of an error") Signed-off-by: Arnd Bergmann Acked-by: Russell King --- I guess it would be useful if Jessica can pick this change up in her tree that introduced the warning. --- arch/arm/include/asm/module.h | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/arm/include/asm/module.h b/arch/arm/include/asm/module.h index 89ad0596033a..9e81b7c498d8 100644 --- a/arch/arm/include/asm/module.h +++ b/arch/arm/include/asm/module.h @@ -34,6 +34,7 @@ struct mod_arch_specific { #endif }; +struct module; u32 get_module_plt(struct module *mod, unsigned long loc, Elf32_Addr val); /*