From patchwork Fri Jul 6 13:58:10 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Arnd Bergmann X-Patchwork-Id: 10511833 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 84FDA60325 for ; Fri, 6 Jul 2018 13:59:19 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 75E8428712 for ; Fri, 6 Jul 2018 13:59:19 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 6A70828721; Fri, 6 Jul 2018 13:59:19 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.9 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,MAILING_LIST_MULTI autolearn=ham version=3.3.1 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 2595228712 for ; Fri, 6 Jul 2018 13:59:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:MIME-Version:Cc:List-Subscribe: List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id:Message-Id:Date: Subject:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To: References:List-Owner; bh=/E1ag1QmTniWnBHAEBK+r5VCajSbMISCw56q8Ch5rSQ=; b=hNw jQqqkkUYipqDhVd5tY4gyhopw6yXsMgbvV9uDgoDcO6Rk0vFb0RLVkkW16EBYPfXY5PkSjcgifMqI Kf17SFCr5/eeivkd7F20OyAui+r/ha/NG9PUtJMM2LyvzrEwPuMuknmDf9eqTlR3o007ekHYRV8TG 5foOizC0INEBTGUsX5beKGfVXQh2FqGMXkcKMHxRHpg51tk5OJLAn9Ns81DVCxE/UWgDaYCd7gTqi CTIWPzj8Br4NXEqIjm0cy3TZGwJJIUycL2wAZqYIpzHZe9Q/Soqdw7Jilt9PfX/baDwb3QPYXnwR0 KXlVMXmB78OYUFP5tzVEXdILueKAL6A==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1fbRGV-0008IA-B3; Fri, 06 Jul 2018 13:59:15 +0000 Received: from mout.kundenserver.de ([212.227.17.13]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1fbRGK-0008Fc-Cv for linux-arm-kernel@lists.infradead.org; Fri, 06 Jul 2018 13:59:06 +0000 Received: from wuerfel.lan ([46.223.138.35]) by mrelayeu.kundenserver.de (mreue102 [212.227.15.145]) with ESMTPA (Nemesis) id 0LiCiR-1fwhOB1WLb-00nMs9; Fri, 06 Jul 2018 15:58:44 +0200 From: Arnd Bergmann To: Greg Kroah-Hartman Subject: [PATCH] [RESEND] usb/gadget: aspeed-vhub: add USB_LIBCOMPOSITE dependency Date: Fri, 6 Jul 2018 15:58:10 +0200 Message-Id: <20180706135840.908258-1-arnd@arndb.de> X-Mailer: git-send-email 2.9.0 X-Provags-ID: V03:K1:KvyuPYuai9obFLh/kvDcrI47KRwgDKX2E3Ry6HQ2dBsIhVuX7dQ GnQEqLXHO4OTJCdZsiz9niTIbGA6HxqeaiLlGNj7WbvO1eV9QwGmS86ME/ilzENDBPcv9qf 5eHbSD4fna0aFduZOtcZIrlNyv/WnMKDXHamac0CZXu076nSZOUwH7SpS/+/C3/py44no3H Ys9WDG19Q+CazmLKpqCaA== X-UI-Out-Filterresults: notjunk:1; V01:K0:RHZXWbbCw6w=:HH4P/kPioplMCd43E+1gh6 8aBlwc8xAXNPXlK4QjVgk81BogOtpXyVKXd83iq4Yk82pfVpRtUVSE8L5tJqvnY+JBCkMLge7 sqqcb8toYFqz2/7fbhkmmGi6WwKo6E5ycvoFOklOquBMLeDDwRfAGWIKE61N3/OFX9K66+1FG P0m29BVD5INqsDcLn58g+XL8Q7ioGSZu8BYCB+2ntN6+XD8qoFEnveHfF1lOgm8kZHVrBxmJO Wp1pnIB+xNTUTuC9DGux+mAoCAKkZMmRCG6ARAjI4mAW2ODnXOcQHgs3iV3GkA2FI0VTimzsw 0NY1Pp6eymH9GNv/I9F4bb9PhwYaENeYcwyV7lT0PZYOrlFNFns29sOi2SMDX9agfffFt1R0p KnTd/DFtZbtj09liWPxX2II7imuuHvbJa54Q7DW5M5ffnAFBMSS4uH4/6DIF2lL4pvISIyt6h EeGokJvWd3q6zspGCBcHSwjcTMGlRk5m4WoXRFp9YfjhffdxKv7Eee0T3m+O2WY5Nv0Y9zpm5 eBrxVTWtWa7qSBX9+O711azYSy1T/+7Q6D3Y0U3q4q/qBDUuc682my63qQ8kPI5B0xjAQde5s jvfd81vSwl+e6UG0Uzm9eHZ8yfl//KA/oYk709YZP/DX8kM2qB6KufK2VDMPsH0xLju2lj9qS JCw8cwEbP+qDlU74B3M8ErlHMfjWCmQXAsyUEGhUrgKEBtNt5hSKXxMCaqgM3nBx6yzQ= X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20180706_065904_741243_C47831FF X-CRM114-Status: UNSURE ( 9.88 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Felipe Balbi , linux-aspeed@lists.ozlabs.org, Arnd Bergmann , Andrew Jeffery , Benjamin Herrenschmidt , linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, Joel Stanley , linux-arm-kernel@lists.infradead.org MIME-Version: 1.0 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org X-Virus-Scanned: ClamAV using ClamSMTP Without that option, we run into a link failure: drivers/usb/gadget/udc/aspeed-vhub/hub.o: In function `ast_vhub_std_hub_request': hub.c:(.text+0x5b0): undefined reference to `usb_gadget_get_string' Fixes: 7ecca2a4080c ("usb/gadget: Add driver for Aspeed SoC virtual hub") Acked-by: Felipe Balbi Signed-off-by: Arnd Bergmann --- Greg, as discussed in https://patchwork.kernel.org/patch/10427921/, please apply this as a bugfix for 4.18. Arnd --- drivers/usb/gadget/udc/aspeed-vhub/Kconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/usb/gadget/udc/aspeed-vhub/Kconfig b/drivers/usb/gadget/udc/aspeed-vhub/Kconfig index f0cdf89b8503..83ba8a2eb6af 100644 --- a/drivers/usb/gadget/udc/aspeed-vhub/Kconfig +++ b/drivers/usb/gadget/udc/aspeed-vhub/Kconfig @@ -2,6 +2,7 @@ config USB_ASPEED_VHUB tristate "Aspeed vHub UDC driver" depends on ARCH_ASPEED || COMPILE_TEST + depends on USB_LIBCOMPOSITE help USB peripheral controller for the Aspeed AST2500 family SoCs supporting the "vHub" functionality and USB2.0