From patchwork Sun Jul 8 13:34:59 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Javier Martinez Canillas X-Patchwork-Id: 10513153 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 57D716024A for ; Sun, 8 Jul 2018 13:35:29 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 46E6226E47 for ; Sun, 8 Jul 2018 13:35:29 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 3AEB328989; Sun, 8 Jul 2018 13:35:29 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.9 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,MAILING_LIST_MULTI autolearn=unavailable version=3.3.1 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id D814B26E47 for ; Sun, 8 Jul 2018 13:35:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:MIME-Version:Cc:List-Subscribe: List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id:Message-Id:Date: Subject:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To: References:List-Owner; bh=KfxcRvV1RTCazzDJNrwhFO7D0eaO/cYLZTxosSjayUM=; b=Tmf pf1Z4jUukJjGYPb4PyvNQkwYqUUFrmZupQwyJzkNFSnqTavcbkBOH02Di9ra+hhgHVF/z17JGfgQf 0KLCUVy4apgJlqGkeP0qrGvh05D2vfOM9vd9rCu8MLzG2Tbcby583+wbCMYhiSyhmPzBvbUcAk6UF deBtkWIz8F6v0sOVA6BwRl2Hu1PjNhEoWhR/1zHTL/K0PdxJI0EfbdIUZRUg0Kz1QLnKLc5SSANU/ Myl3xpcU/fPkTxLhm1RxUUsWGQCksZ0GS6PEuKcXMA05/ZpDID9iaHed9dbe2/fqlfNTp23oL9S+o /bmAxhNJE5QV7FR0ehvXr76+MVfi9qg==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1fc9qW-00083D-6w; Sun, 08 Jul 2018 13:35:24 +0000 Received: from mail-wm0-f68.google.com ([74.125.82.68]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1fc9qT-00081i-JJ for linux-arm-kernel@lists.infradead.org; Sun, 08 Jul 2018 13:35:23 +0000 Received: by mail-wm0-f68.google.com with SMTP id s13-v6so7903970wmc.1 for ; Sun, 08 Jul 2018 06:35:11 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=pN04fejRgMTBwWfZiwOZz6ZhygZUxMPjZ0VEZ6LF0EA=; b=HkeptB+C6129699izn0LHxBiNLW4QlgVj6NVwM2UvKSc6Yjk1+Ru4223QplPALvNJ+ rwUtqh8f5WyXhXtmT9YlqYSiSDmjvD/d7FDaRoPyC7SSkYSEDVRK2vPSsPc0HhYOZrD/ 9S/nEw0rvgS8LOuPL6o62y4rdKgFbgiWNQVmI7n3nIxrqkpY+2Hed/UKj1V5V+edRd0V RPS/BUk7yX1Avp8w2slMAUMq+an/8/ZICfzl2lEILboUq1H94b/Tcio/TOfjH4j9ZCOq hW27ChUnXp3aML8xS2pXLFzrTXVgtlJcZEfCG6Ew8L86jIWdBuVz4sH1VsONzJpzGRnq OCoQ== X-Gm-Message-State: APt69E2L4h9BHSIYVCS3BOZplUaAw/K396HL/X0XF9zxFhcQjGjO337s DewFAi/NfY/wx1+m9HlOrq/KHQ== X-Google-Smtp-Source: AAOMgpeEcVLOwNSO+VI1SOa79iq8xOPlNxsOrejHaSoF2+IlhUsjFF9UgNoyY9E+fYqY//M230GrmQ== X-Received: by 2002:a1c:e041:: with SMTP id x62-v6mr9502540wmg.155.1531056909907; Sun, 08 Jul 2018 06:35:09 -0700 (PDT) Received: from minerva.ual.es (nat-wifi-invi.ual.es. [150.214.223.90]) by smtp.gmail.com with ESMTPSA id 24-v6sm33815043wrz.94.2018.07.08.06.35.08 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Sun, 08 Jul 2018 06:35:09 -0700 (PDT) From: Javier Martinez Canillas To: linux-kernel@vger.kernel.org Subject: [PATCH v4] driver core: add a debugfs entry to show deferred devices Date: Sun, 8 Jul 2018 15:34:59 +0200 Message-Id: <20180708133459.24883-1-javierm@redhat.com> X-Mailer: git-send-email 2.17.1 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20180708_063521_632724_634A20BE X-CRM114-Status: GOOD ( 19.14 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Rob Herring , Tomeu Vizoso , Greg Kroah-Hartman , Javier Martinez Canillas , Andy Shevchenko , Mark Brown , Peter Robinson , linux-arm-kernel@lists.infradead.org MIME-Version: 1.0 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org X-Virus-Scanned: ClamAV using ClamSMTP With Device Trees (DT), the dependencies of the devices are defined in the DT, then the drivers parse that information to lookup the needed resources that have as dependencies. Since drivers and devices are registered in a non-deterministic way, it is possible that a device that is a dependency has not been registered yet by the time that is looked up. In this case the driver that requires this dependency cannot probe and has to defer it. So the driver core adds it to a list of deferred devices that is iterated again every time that a new driver is probed successfully. For debugging purposes it may be useful to know what are the devices whose probe function was deferred. Add a debugfs entry showing that information. $ cat /sys/kernel/debug/devices_deferred 48070000.i2c:twl@48:bci musb-hdrc.0.auto omapdrm.0 This information could be obtained partially by enabling debugging, but it means that the kernel log has to be parsed and the probe deferral balanced with the successes. This can be error probe and has to be done in a ad-hoc manner by everyone who needs to debug these kind of issues. Since the information is already known by the kernel, just show it to make it easier to debug. Signed-off-by: Javier Martinez Canillas Reviewed-by: Andy Shevchenko Reviewed-by: Mark Brown Reviewed-by: Sebastian Reichel Tested-by: Pavel Machek --- Changes since RFC v1: - Remove unneeded ret variable from deferred_devs_show() Changes since RFC v2: - Use DEFINE_SHOW_ATTRIBUTE() macro. - Don't propagate debugfs_create_file() error. - Remove IS_ENABLED(CONFIG_DEBUG_FS) guards. - Drop RFC prefix. Changes since v1: - Better explain in the commit message why this patch is useful. - Rename deferred_devices entry to devices_deferred. - Add an exit function and remove the debugfs entry. Changes since v2: - Add Andy Shevchenko and Mark Brown Reviewed-by tag. - Rebase on top of Greg's driver-core-next branch. Changes since v3: - Fixed a build warning caused by a wrong conflict resolution on v3. drivers/base/dd.c | 29 +++++++++++++++++++++++++++++ 1 file changed, 29 insertions(+) diff --git a/drivers/base/dd.c b/drivers/base/dd.c index 6ea9c5cece7..e85705e8440 100644 --- a/drivers/base/dd.c +++ b/drivers/base/dd.c @@ -16,6 +16,7 @@ * Copyright (c) 2007-2009 Novell Inc. */ +#include #include #include #include @@ -53,6 +54,7 @@ static DEFINE_MUTEX(deferred_probe_mutex); static LIST_HEAD(deferred_probe_pending_list); static LIST_HEAD(deferred_probe_active_list); static atomic_t deferred_trigger_count = ATOMIC_INIT(0); +static struct dentry *deferred_devices; /* * In some cases, like suspend to RAM or hibernation, It might be reasonable @@ -199,6 +201,24 @@ void device_unblock_probing(void) driver_deferred_probe_trigger(); } +/* + * deferred_devs_show() - Show the devices in the deferred probe pending list. + */ +static int deferred_devs_show(struct seq_file *s, void *data) +{ + struct device_private *curr; + + mutex_lock(&deferred_probe_mutex); + + list_for_each_entry(curr, &deferred_probe_pending_list, deferred_probe) + seq_printf(s, "%s\n", dev_name(curr->device)); + + mutex_unlock(&deferred_probe_mutex); + + return 0; +} +DEFINE_SHOW_ATTRIBUTE(deferred_devs); + /** * deferred_probe_initcall() - Enable probing of deferred devices * @@ -208,6 +228,9 @@ void device_unblock_probing(void) */ static int deferred_probe_initcall(void) { + deferred_devices = debugfs_create_file("devices_deferred", 0444, NULL, + NULL, &deferred_devs_fops); + driver_deferred_probe_enable = true; driver_deferred_probe_trigger(); /* Sort as many dependencies as possible before exiting initcalls */ @@ -216,6 +239,12 @@ static int deferred_probe_initcall(void) } late_initcall(deferred_probe_initcall); +static void __exit deferred_probe_exit(void) +{ + debugfs_remove_recursive(deferred_devices); +} +__exitcall(deferred_probe_exit); + /** * device_is_bound() - Check if device is bound to a driver * @dev: device to check