From patchwork Mon Jul 9 14:56:03 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Arnd Bergmann X-Patchwork-Id: 10514821 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id F3ED66032A for ; Mon, 9 Jul 2018 14:56:55 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id E408B28AB3 for ; Mon, 9 Jul 2018 14:56:55 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id D895928AD9; Mon, 9 Jul 2018 14:56:55 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.9 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,MAILING_LIST_MULTI autolearn=ham version=3.3.1 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 6845128AD0 for ; Mon, 9 Jul 2018 14:56:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:MIME-Version:Cc:List-Subscribe: List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id:Message-Id:Date: Subject:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To: References:List-Owner; bh=ztgQixvc6q/gLIer9cOcsV5aU4hGTW8sD5bD5cBtquo=; b=fi2 3sOmLDMzJve/+Bx2E9Z+VeCZSIuB8vUkEex8IwvRaOh3Euc1DPBpShQLUWAfHT4kOJ6deoZp9Pw+V Ryrz8dp26PdQdccHz2qTmIUXz0o24/OPAwMni116WG2YrxjWnYIR9T8vTk/uSU2Ffruh07nfhJ9iH nNzpXbxsdREXA/88r/LRhCkgabkCwdSJc3RmecPA4ZRbJPuYED1cuv5jAEduUxYVTPy8HO9ZyBaBZ h7fgjfoGhPazMa3+mxkKp3I2Y/lkCMmIQlJCYQdA0zvMlS6BsnyuKIVqgPyd46Lh5XsIo1IHnKi60 HQFP61WHBpi/merRNjc9IP//bB5OqkQ==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1fcXat-0003du-9R; Mon, 09 Jul 2018 14:56:51 +0000 Received: from mout.kundenserver.de ([217.72.192.75]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1fcXap-0003c8-GE for linux-arm-kernel@lists.infradead.org; Mon, 09 Jul 2018 14:56:49 +0000 Received: from wuerfel.lan ([46.223.138.35]) by mrelayeu.kundenserver.de (mreue104 [212.227.15.145]) with ESMTPA (Nemesis) id 0MRDId-1fW7A61fmp-00UYtD; Mon, 09 Jul 2018 16:56:17 +0200 From: Arnd Bergmann To: Linus Walleij , Joel Stanley Subject: [PATCH] gpio: aspeed: fix compile testing warning Date: Mon, 9 Jul 2018 16:56:03 +0200 Message-Id: <20180709145612.4166409-1-arnd@arndb.de> X-Mailer: git-send-email 2.9.0 X-Provags-ID: V03:K1:pGGVIkWKmgTZ58vQUuEMi7fAMZyR4xNewyY/2y6+GsArhO5zYvR wtXKXFmf5Fl77JYQofh5LFvwdd2LtspuCLvzuL8ZbRDB680jczOGrhMQQuj+3i2m7tVwi6o cAtzki0ltHG3HKwZw0mgA/BksuzLDm9Ypo8+rAVq0G6W7c4UjgHzlTA6kOM+kEvTauB9U67 A4tiB9QegXob24ruoiflg== X-UI-Out-Filterresults: notjunk:1; V01:K0:2HSErx1C5PM=:83xsIO9CQ4pdykahu20FqB /5qsMZjB0YjdPiCjBPhJ4KK8WJmK29QxxiZVh+1PH6rTjrqhuTpBOV6APAukrPQ4wYmI2vstP /501gPCtaOQQcEMTNDiI95dbfrmlvFi4FYlh6xojGC5kRkZXp3Amzg+E26sY288Q+yEMd/Hjc 0IK2YFSaFhYNtyHzVQmIWV0fS8FBtRSLsEUdmE3q6Zvmc1zdZXg1rKfudH+r1leeQGeNtxCEZ MiA2TaI4zJVlIrd1pU+BHDvzU786WjeBxsyZ7s5HqTXBwXdEfaDKnqmrG1nEvSWUqpElcQexb AURhCg3qyM3JK7SYTbruKV+VNfkyo+1oG9l1oIP4e8Ln4jr50W55bPoYjg8RT65oYepgMh7hN uEvyjHdKiE+tFmsF9LndfIzvr9YmhtZmAES2mc4xI81ls5lBTU2352W5iODkfWgThLOyp4ojI Hd3jcUWGeGP6E7dgMcwuQBfZRrOV3+WTdGz2367r3gYPqicdM3E29kQVdQ3fRm5PnHxL175qK B0TdeuZLi/LW3cnySQlgKvzB/xFSJKjhWhqNVGYk0fXRcuiUiVz1HB3GUyjO9KcwlP6apdbN8 NrNpX+J6nnJXN5s8+B8HfkVrfJK4UJqBxz+ytwDROPB24OKaPCweUnEgmEdgPO3iRaEUHAhju 8ylHcKJdIsZj56Svqd+Z2NBmgh03OShn5G3btcq15zc9RXKN1JGXdFESy1BMwcpZuSA0= X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20180709_075647_835749_9C1F76D7 X-CRM114-Status: GOOD ( 12.43 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-aspeed@lists.ozlabs.org, Arnd Bergmann , Andrew Jeffery , Benjamin Herrenschmidt , linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org, Thierry Reding , linux-arm-kernel@lists.infradead.org MIME-Version: 1.0 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org X-Virus-Scanned: ClamAV using ClamSMTP Gcc cannot always see that BUG_ON(1) is guaranteed to not return, so we get a warning message in some configurations: drivers/gpio/gpio-aspeed.c: In function 'bank_reg': drivers/gpio/gpio-aspeed.c:244:1: error: control reaches end of non-void function [-Werror=return-type] Using a plain BUG() is easier here and avoids the problem. Fixes: 44ddf559d579 ("gpio: aspeed: Rework register type accessors") Signed-off-by: Arnd Bergmann Acked-by: Benjamin Herrenschmidt --- drivers/gpio/gpio-aspeed.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpio/gpio-aspeed.c b/drivers/gpio/gpio-aspeed.c index 1e00f4045f9d..2342e154029b 100644 --- a/drivers/gpio/gpio-aspeed.c +++ b/drivers/gpio/gpio-aspeed.c @@ -240,7 +240,7 @@ static inline void __iomem *bank_reg(struct aspeed_gpio *gpio, case reg_cmdsrc1: return gpio->base + bank->cmdsrc_regs + GPIO_CMDSRC_1; } - BUG_ON(1); + BUG(); } #define GPIO_BANK(x) ((x) >> 5)