From patchwork Mon Jul 9 15:57:04 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Arnd Bergmann X-Patchwork-Id: 10515139 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id CF37C6032A for ; Mon, 9 Jul 2018 15:59:35 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id BCBFB28C81 for ; Mon, 9 Jul 2018 15:59:35 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id B0BD828CA2; Mon, 9 Jul 2018 15:59:35 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.9 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,MAILING_LIST_MULTI autolearn=ham version=3.3.1 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 4A1CD28C81 for ; Mon, 9 Jul 2018 15:59:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:MIME-Version:Cc:List-Subscribe: List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id:References: In-Reply-To:Message-Id:Date:Subject:To:From:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Owner; bh=StwQda2AJX/ZgH2+iXK+75DDJRVqWQi5qDGuFrcxY9A=; b=lkugYuk0G85yJJV7SPEfFgfHDA qkEcBk4txB7MKOOwWmg8zWW2tEoqS6z4t75eSsFyxABCxbH7D6xUd0JzyoFsrvMvRLBdPF6ZkBKsw vG7jsAqcLsZ4vkXberaW7GcUlwR9Gf16xnqxFRLK9s3fTgt+hNv9ZSNyOJNBOEqjA5muIqotlD6eE a0zbvgWa5sevg/A5F8+dxAjScWDaBamw+KqSqbvm50CDUz0SPc3exGZuuAiJhZi/0kroyfB+B1jLK yaGM70gq946oP+NKzuKRGxkCiqy4oZyQXoFuwVPWHh4gWM0DlE0snx14bqqAh5v+NsxA5+feKISZ8 j8Q3Gzeg==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1fcYZX-0008Ug-Er; Mon, 09 Jul 2018 15:59:31 +0000 Received: from mout.kundenserver.de ([212.227.17.24]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1fcYYw-0007NU-JS; Mon, 09 Jul 2018 15:59:26 +0000 Received: from wuerfel.lan ([46.223.138.35]) by mrelayeu.kundenserver.de (mreue105 [212.227.15.145]) with ESMTPA (Nemesis) id 0MFKbs-1fqu1w2NG8-00EMEx; Mon, 09 Jul 2018 17:58:20 +0200 From: Arnd Bergmann To: Boris Brezillon Subject: [PATCH 3/3] mtd: sunxi_nand: fix build warning Date: Mon, 9 Jul 2018 17:57:04 +0200 Message-Id: <20180709155730.2422841-3-arnd@arndb.de> X-Mailer: git-send-email 2.9.0 In-Reply-To: <20180709155730.2422841-1-arnd@arndb.de> References: <20180709155730.2422841-1-arnd@arndb.de> X-Provags-ID: V03:K1:rs37fhogpXsDddcc/Tg/tg9RyRGZES2mpCS2k8fM/bageXDxj0G Uvplqtd0sa94pn4FviKHPFaKDCplZ8MGTjZdvi0I5ZvbZ1kruA299+TzpLQUTycdWKCBQ0x YmGgJhg6fq071b4+gp32U+1sfQw3DXWQ1ly2+4WYMvgK3kvicleQ0ANI9iCGQDlKBTisw3h TmIR5xdtwbnbFkFJJZ46A== X-UI-Out-Filterresults: notjunk:1; V01:K0:j+AbLGmx0kQ=:Gz4zVvVpyB1kYk+nRQlNCB clCz+JHxRzHCtuFEwEoROzXKQ3GMC9e6WYVmg40CqBuTnPV0ogLlCghP4ZxBO0MXv4QiFfzPH 2UwPrKGLzDLewq6QlDQ9fPNfI+CvHivZ99OzYIoTQ2IH+xw31DV/UcS4BDy0aUqNxNPo/+rfa cTBOAymHEW5YzfTujnFlKTjULkIzv1vSCxTZw3RTgqE6vCtTec5av+zW9R4OPeXQ1kmvnPjoz 6khRakSrMmxAqWvyoKZbcTY4rvm+wbBvDhTaTUm2D+a1LVT6EyuVk5drRAyFc1mcCnQh4ZtWj 8cfFAei+KiJxMNibi1nHdooF5McC284JEejNJXAS+S5HF1un6PkdtUwjmhhf4NovoT03xXwGJ WAnAEVuk2EH9lqQCUwlraJqQ3CVrx4P06JG8Ca/YAwV7d98YSOKAx/n9BHcmus8tFnTk2h5YT yAT6c8DWprWrEAemKGUxs05owlJlDUItciTpXsdbvffXxzegdSL2GtEylcpABMR78IpGE/Op5 bqGnaRiN3WV2RNYEhN8xGVTONsq/6Fd9rnBs0YS9HxuSSdOlWDmnF8u5mw7V2IuN8W1pIvtX3 hIX1r6sCbhZcMoAzvszLTTNlV4dyDpFoDDWWE63bFLb5QT745I7B0Y6Cs1IFvt2dllajRJnVn wfpkuY48s9Lh3rK9iipgpOAoaxcb2xBi/2nKYdj2em2pFiylVX9YEkvxZHLxosWnYx+A= X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20180709_085855_093221_7BF28F26 X-CRM114-Status: GOOD ( 13.44 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Arnd Bergmann , Masahiro Yamada , Maxime Ripard , Richard Weinberger , linux-kernel@vger.kernel.org, Vladimir Zapolskiy , Marek Vasut , Chen-Yu Tsai , linux-mtd@lists.infradead.org, H Hartley Sweeten , Philipp Zabel , Miquel Raynal , Bryan O'Donoghue , Brian Norris , David Woodhouse , linux-arm-kernel@lists.infradead.org MIME-Version: 1.0 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org X-Virus-Scanned: ClamAV using ClamSMTP build-testing this driver on x86 shows a new warning: Fixes: b3d926a3d6e0 ("mtd: rawnand: sunxi: Allow selection of this driver when COMPILE_TEST=y") drivers/mtd/nand/raw/sunxi_nand.c: In function 'sunxi_nfc_hw_ecc_read_chunks_dma': drivers/mtd/nand/raw/sunxi_nand.c:130:22: error: conversion from 'long unsigned int' to 'unsigned int' changes value from '18446744071631273984' to '2216689664' [-Werror=overflow] #define NFC_PAGE_OP (2 << 30) drivers/mtd/nand/raw/sunxi_nand.c:1040:9: note: in expansion of macro 'NFC_PAGE_OP' writel(NFC_PAGE_OP | NFC_DATA_SWAP_METHOD | NFC_DATA_TRANS, ^~~~~~~~~~~ drivers/mtd/nand/raw/sunxi_nand.c: In function 'sunxi_nfc_hw_ecc_write_page_dma': drivers/mtd/nand/raw/sunxi_nand.c:130:22: error: conversion from 'long unsigned int' to 'unsigned int' changes value from '18446744071632322560' to '2217738240' [-Werror=overflow] #define NFC_PAGE_OP (2 << 30) drivers/mtd/nand/raw/sunxi_nand.c:1406:9: note: in expansion of macro 'NFC_PAGE_OP' writel(NFC_PAGE_OP | NFC_DATA_SWAP_METHOD | This is easy to avoid by ensuring that the constants are 'unsigned'. Fixes: b3d926a3d6e0 ("mtd: rawnand: sunxi: Allow selection of this driver when COMPILE_TEST=y") Signed-off-by: Arnd Bergmann --- drivers/mtd/nand/raw/sunxi_nand.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/mtd/nand/raw/sunxi_nand.c b/drivers/mtd/nand/raw/sunxi_nand.c index d831a141a196..fa5c48502fa8 100644 --- a/drivers/mtd/nand/raw/sunxi_nand.c +++ b/drivers/mtd/nand/raw/sunxi_nand.c @@ -125,9 +125,9 @@ #define NFC_SEND_CMD3 BIT(28) #define NFC_SEND_CMD4 BIT(29) #define NFC_CMD_TYPE_MSK GENMASK(31, 30) -#define NFC_NORMAL_OP (0 << 30) -#define NFC_ECC_OP (1 << 30) -#define NFC_PAGE_OP (2 << 30) +#define NFC_NORMAL_OP (0u << 30) +#define NFC_ECC_OP (1u << 30) +#define NFC_PAGE_OP (2u << 30) /* define bit use in NFC_RCMD_SET */ #define NFC_READ_CMD_MSK GENMASK(7, 0)