From patchwork Wed Jul 18 16:10:33 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Bartosz Golaszewski X-Patchwork-Id: 10532805 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 8106B600F4 for ; Wed, 18 Jul 2018 16:12:13 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 710D4251F9 for ; Wed, 18 Jul 2018 16:12:13 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 63F2F28459; Wed, 18 Jul 2018 16:12:13 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.9 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,MAILING_LIST_MULTI autolearn=ham version=3.3.1 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 170C9251F9 for ; Wed, 18 Jul 2018 16:12:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:MIME-Version:Cc:List-Subscribe: List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id:References: In-Reply-To:Message-Id:Date:Subject:To:From:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Owner; bh=D9FwbBa4mksWBreq0691GpTyZbBbsnSBn24pjpM58Jg=; b=U2bcdvRNgJlQ38YeCQavdmYIkN PzgL5Ct8lK5KiTPonG9ykv+VzsZpxqjARf1BQpeSaTt0l+3AN/46XzD4Sd0kyOzsfs4d5apt1m+hY TqN+ivUKGFCE+2lj96HnWMeRQ8JDD+ja5gUEddkdpw2mY+tapSZw7gncOdKIeFh6gup/q4b836TNQ b4klYoXSZr4W7UevJm3b8jvrKy/kSDMssV+kzzk0V9HW4ocpFBmpnd45A69qS9lf1uQHGI3B6aDDo lEnVPO0PnoNbiHJVKbVFYueUEUOBGjp1id50poJ/7dVuEjKtNSiIChiGxB/g6o9Ggd5FMCABH9OXO DbF3zHgQ==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1ffp3Z-00046k-3p; Wed, 18 Jul 2018 16:12:01 +0000 Received: from mail-wm0-x244.google.com ([2a00:1450:400c:c09::244]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1ffp2Z-0002m5-PE for linux-arm-kernel@lists.infradead.org; Wed, 18 Jul 2018 16:11:08 +0000 Received: by mail-wm0-x244.google.com with SMTP id c14-v6so3350460wmb.4 for ; Wed, 18 Jul 2018 09:10:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bgdev-pl.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=EirWCWel/w1jaSio88cM+pYKnpg1qeQaHBKU4yixNfc=; b=EHtJuWoO8ddLvvPcVimKtHq6H8FCzhnH+7pzF5jw6GaqcXYVULCbQvQoyIn5ASUyEm f7zDWC1QrVN92CcoQW57/gEo0uIRrlNSgjl6n0hRexuov7WOocKC1Fsi4g+s+ZOL5n9T x1FeKQIU2dJuVrK86D0Gf+TK6S3Kpq2bWh4NpwmZDQV5+5d1FzUiLYZo83fVWqi1Oaf0 zqmmGgn7yTu/xMdApC0AIDaBQn8k+pSar5skAgB4lzqTgdlFxQLdNLfldfINYhgp/ZWZ WhuqQUdLp5TRmP+6JAOU/I6o2o+NfvgObBZVHLDVsc4URiyW8BtTsdT7rfDrKzcsKdj4 NTJg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=EirWCWel/w1jaSio88cM+pYKnpg1qeQaHBKU4yixNfc=; b=Sq671kNaDAW1VerRD5DGyLMipZkmBVxSYDo9pgSmRi6FqTPt1iWsTPPJn4RSRwGwCd KFNdaIl60FYwJfMGndRZZXtYcnBctxSLo6V0bj4Y/Nn/PRavqh3RzcC6zsAg0o2cb5/E c4d+swLQM+o2Q8xeQzgbZb8p5FJiK8JRQX/Jd64t0Y4Fn4mEBj97ss5rixvjHrNsmys3 i4Zd+HJKrHcKoO0aqR5+QDlJ3Or6XNGK1et8Vja1y1fa/Gf1IQiMit8iE2FfUdDwiM0o ctY8BRcLdP3VpIs9SeOUEYwtyZFN86L6eY9F5m78D0hBCGcmrJYt9lQRFO1nTUK6c2Ch sdfg== X-Gm-Message-State: AOUpUlEbXVE6T7ohT2ejo4SsP7cdXPDJHycwyT6NbIHLtGhw0VSvmkxl Q5bbD67BhzbvauhMtp1QTuIaDw== X-Google-Smtp-Source: AAOMgpewbp5hFl5y/IcWNm7naKQjwy1bkB0Rq1kdgYVfhvYPX6gC55U0SsVOv5KPlyS0WjNzpFYBDQ== X-Received: by 2002:a1c:369c:: with SMTP id y28-v6mr1923561wmh.34.1531930246398; Wed, 18 Jul 2018 09:10:46 -0700 (PDT) Received: from brgl-bgdev.home ([2a01:cb1d:af:5b00:e837:b8d5:48c1:571b]) by smtp.gmail.com with ESMTPSA id v185-v6sm2847803wme.30.2018.07.18.09.10.44 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 18 Jul 2018 09:10:45 -0700 (PDT) From: Bartosz Golaszewski To: Sekhar Nori , Kevin Hilman , Russell King , Grygorii Strashko , "David S . Miller" , Srinivas Kandagatla , Lukas Wunner , Rob Herring , Florian Fainelli , Dan Carpenter , Ivan Khoronzhuk , David Lechner , Greg Kroah-Hartman , Andrew Lunn Subject: [PATCH 3/5] net: fortify eth_platform_get_mac_address() Date: Wed, 18 Jul 2018 18:10:33 +0200 Message-Id: <20180718161035.7005-4-brgl@bgdev.pl> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20180718161035.7005-1-brgl@bgdev.pl> References: <20180718161035.7005-1-brgl@bgdev.pl> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20180718_091100_184894_4BB90C51 X-CRM114-Status: GOOD ( 12.76 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: netdev@vger.kernel.org, linux-omap@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Bartosz Golaszewski MIME-Version: 1.0 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org X-Virus-Scanned: ClamAV using ClamSMTP From: Bartosz Golaszewski We'll soon have more sources from which to read the MAC address in this routine. Make sure the address is correct before returning it. Signed-off-by: Bartosz Golaszewski Reviewed-by: Andrew Lunn --- net/ethernet/eth.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/ethernet/eth.c b/net/ethernet/eth.c index 2a2173324d9e..6b64586fd2af 100644 --- a/net/ethernet/eth.c +++ b/net/ethernet/eth.c @@ -544,7 +544,7 @@ int eth_platform_get_mac_address(struct device *dev, u8 *mac_addr) from = "arch callback"; } - if (!addr) + if (!addr || !is_valid_ether_addr(addr)) return -ENODEV; dev_info(dev, "read MAC address from %s\n", from);