From patchwork Fri Jul 20 05:08:38 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jisheng Zhang X-Patchwork-Id: 10535971 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 2B7E6602CA for ; Fri, 20 Jul 2018 05:11:17 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 1F8592977C for ; Fri, 20 Jul 2018 05:11:17 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 0FAE029777; Fri, 20 Jul 2018 05:11:17 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.9 required=2.0 tests=BAD_ENC_HEADER,BAYES_00, DKIM_SIGNED, DKIM_VALID, MAILING_LIST_MULTI autolearn=ham version=3.3.1 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 810A929777 for ; Fri, 20 Jul 2018 05:11:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-ID:Subject:To:From :Date:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References: List-Owner; bh=3MA11ieJK7P6Lw8BC43i0Y+chypAwktyAAMY48js+Bc=; b=bkLqAM8zVXD3yn rGCaX4XU6w2NZjyj5ZhhFIqUOmL0xhwhccDZz1VEPlNAnaRv7RNKzUUnxu7n7gRaoraUtwjVir5jP Fo3QlUulAi42madX8VLiQ1kddABBe/MOpOS+P1KOQZbd9hVWfm9Y2F2o7JEp1TUFZdomVGlBNp8uu 5NVL9GXGk9wgnPgG8ubESFMAdIDd9vT2/ZvkNeNT05TZRMbKRQtE4Of5+1aFzd2/gUwXc9K+pVx1S hhYag4zjSZdT0eqKf4oXdsCTRaTExqJOgLLeoZYoxV3G6zxubHOjFm9CGoAYDTB8S4cnnaUmYV5Qz qyxjHh7Rt1uXVBCfW87g==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1fgNh8-0004YW-SF; Fri, 20 Jul 2018 05:11:10 +0000 Received: from mail-eopbgr720069.outbound.protection.outlook.com ([40.107.72.69] helo=NAM05-CO1-obe.outbound.protection.outlook.com) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1fgNh4-0004Xo-Vy for linux-arm-kernel@lists.infradead.org; Fri, 20 Jul 2018 05:11:09 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Synaptics.onmicrosoft.com; s=selector1-synaptics-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=+ITB9YTFZz74dRXwtjhUTkc/5arnSJvm8g/XJXIXzmY=; b=VyMZZ9m8bNN7PbOriGL1fnKQwPjhe4OADMc5KK7VRyp8okc+BH2L7HikIx7bJKCTpEhSg86T20uPFyUpNrX/mixBKXTwHfj1hIz5eXnwRtJ9mOFFJXQXTNMifBdtqYmQGbufvguqhRjKxRZRXqe8cKpBNIxTOeWGVHNatgy3qwI= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=Jisheng.Zhang@synaptics.com; Received: from xhacker.debian (124.74.246.114) by SN1PR0301MB1584.namprd03.prod.outlook.com (2a01:111:e400:5232::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.952.18; Fri, 20 Jul 2018 05:10:52 +0000 Date: Fri, 20 Jul 2018 13:08:38 +0800 From: Jisheng Zhang To: Olof Johansson , Arnd Bergmann , arm@kernel.org Subject: [PATCH] ARM: dts: berlin: Add missing OPP properties for CPUs Message-ID: <20180720130838.187becb9@xhacker.debian> X-Mailer: Claws Mail 3.16.0 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 X-Originating-IP: [124.74.246.114] X-ClientProxiedBy: HK0PR03CA0087.apcprd03.prod.outlook.com (2603:1096:203:72::27) To SN1PR0301MB1584.namprd03.prod.outlook.com (2a01:111:e400:5232::18) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: cdc1cbad-a9b8-42b5-a438-08d5edff2b5d X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(7020095)(4652040)(8989117)(5600053)(711020)(4534165)(4627221)(201703031133081)(201702281549075)(8990107)(2017052603328)(7153060)(7193020); SRVR:SN1PR0301MB1584; X-Microsoft-Exchange-Diagnostics: 1; SN1PR0301MB1584; 3:Lub6xC8VY8j39DGRB4w6MmADB7lXip+xxrW+Dnf3LUVm5im2AyybJgzKLN28NbXz+Wyoq5ylmZkzIvntM0zzdm0OHbMiRz2XLXklAMnjxMGzMHJV+c9cfztFx0KU7a0xb9k4D3SQFfbU6z4HpCP0uEu6/rme+nP4FWlf5qBn9ZOxH8xGjp5X8sTMs2QnyccaMRJXD7naRH4KkHfvgt/+N1s8HybgM80EFjt23v6j4CUBCYspQ8nKnPXJk6iF8p1P; 25:iMGgw/UI6pTelfX2aSL1bvJQ38HngPFI/PVmIQodYPTsSEeD0CTRvtHLVTQIvkw1NaDLLjltDQboyudciYMolspQQmXvwKApwGSBq/jxzKkImHWgF/XH6s7c2FiCzGZSzT+fiXMiBy3b9X+cAOoNtFWLQ6G5X2MOkONIlj5D9tfA7CQopWQqBq34T5wQpCtof5JcJFlC0+r0BU7wuWrEnrV6LEy6aC4+v/2oFBWC3rAK0nWGtd+d9jMhrseUcEm1GxkPFQkod7NQfwHaXg88ISsgulkr+B/o5MU0OUg/MY+YXk3+yvpIHD27Fmp2Wd8az1JVbr9UyZoHAEaKAAIIdQ==; 31:sIabA5Me/ij0g3iYHki26arJsEUWpeP3l9tZfNkr57Vmy2fsPM7SH4OtegrV+TWEFr13LKl+sFzm8VacGwyDCFJm3hvLCov5yvcaAE55xWgs3f3gL5Y3+9wJAvYYPsHgN0mfZsaz13sEmq/exCc7bvcSWxXCqepXw4e3QeNFqaqkZtrF5WuhZ4gsvog8VV7QYM8EDUeZUUA59DGZZ4+RdtMgD+eACSd9areVAXdVAN0= X-MS-TrafficTypeDiagnostic: SN1PR0301MB1584: X-Microsoft-Exchange-Diagnostics: 1; SN1PR0301MB1584; 20:j6xCkdtsE0pfCCSi5A2p+wNEX2TKaG1jNRbpOqvfLXgJd/iRAMvvWQ4bJ3D7uU6JBdMK/IHgGLcDFyYmnPsiq/9O699BWVQ2izjqcbKdAGvzwAcr572vRnp0lp4dplIbkRNMhkfz0execbZ9N7BWsrtZre4CDsUBAtqli30fyCS0X51v+ORlIeGhwynZhGZ/6Gp9PbxbFekc04w3BoVvYdLow60zTM8M0NJ+JfNbaUqp2QgW/DJM9rX8M4y13SQG1RAJMIubUwwfPKEgC0q2mM8zGW2uhazSuh4sizyAR8jMntZUtpZ5SBiYaWbaZcA0G2B3o7N9b8WJDONUGpSmlXBAUUVw+jLchJ5XNm+f97P+nD9VBK4CpxhugXdpUkpCCnQd1nAqgnIE0vkheM8Gy2X+6gyzQ6ybYsqvP92wsoJCgrTdsRmdc6j6d+3pPiJ1QCwyfjz0BmzIdNQLyyBKZC3gIAJoxM5cjrc/n/H8/TY3syNaB2uKM9XQA/sXB6My; 4:cqZTRcA2dMlQcjw3PfbU7K7HNz1kFL/jVk4wxrQxnCDE7JNWfkd9cl6dl9hGJNDvy4QUaMwLml2LCXydgO3c5prRX16b+Pzbhty7pTktOycFNUelCR+BNoHyhA4+DWTKCuWPdxml5Wus4fyMYRxldLRaciz9PavwZsXF8qJiiNlT3wCD6TqOksjTW69QnGH/9uLnqjG345x228X2wfOcSClfiltqMMrZ89s66o2yLS9QpnyNYSfYl7/aYlwiyLojeyWSwBTFxEO4zIlvM6paotyeIeIxGo1wQFUxAbo2Gc2ZZEN/fiTLHY9Af49+W2OJ X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(209352067349851); X-MS-Exchange-SenderADCheck: 1 X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(6040522)(2401047)(8121501046)(5005006)(10201501046)(3231311)(944501410)(52105095)(3002001)(93006095)(93001095)(149027)(150027)(6041310)(20161123560045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123564045)(20161123558120)(20161123562045)(6072148)(201708071742011)(7699016); SRVR:SN1PR0301MB1584; BCL:0; PCL:0; RULEID:; SRVR:SN1PR0301MB1584; X-Forefront-PRVS: 073966E86B X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(136003)(396003)(366004)(39860400002)(346002)(376002)(189003)(199004)(478600001)(55016002)(186003)(23726003)(97736004)(50226002)(68736007)(1076002)(6116002)(53936002)(16526019)(956004)(26005)(3846002)(105586002)(72206003)(476003)(230700001)(86362001)(1857600001)(7736002)(106356001)(305945005)(9686003)(14444005)(50466002)(33896004)(8936002)(25786009)(7696005)(316002)(52116002)(386003)(6506007)(2906002)(66066001)(5660300001)(110136005)(47776003)(54906003)(4326008)(39060400002)(486006)(81166006)(81156014)(8676002)(6666003)(39210200001); DIR:OUT; SFP:1101; SCL:1; SRVR:SN1PR0301MB1584; H:xhacker.debian; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; Received-SPF: None (protection.outlook.com: synaptics.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; SN1PR0301MB1584; 23:z9FuO67intJVFb7tqF0rUtITI0lZXRy0vlQR7FM?= =?us-ascii?Q?Yemf+fQlSnzcwGZz3d96iOYRBfZbyoufFv7ffcjO23jguKSfYhb15LhG1BGt?= =?us-ascii?Q?9q5V/XECsDI1wOJNp2HoyZWfDAmDzJL3NYmIiW/o/wyNkoGMOm/CL4ekJxx+?= =?us-ascii?Q?54JQebRRSbrFUc2LkLdjw5rCakggUV5fl+CytqpgEmU4zNyHXtEBjHGGJVQ9?= =?us-ascii?Q?jflIPGZdOp/CpDbE4FYJalZVUi1ougAY4jOIgtFAuyFgk2ovx9vphg2+SjJZ?= =?us-ascii?Q?X74BFAtiF6r7tSvImvNRo4bPp1gCAupCTOm8MQK1E/PWspRRXKDHorlJzOuA?= =?us-ascii?Q?Soxt8ThJM6n08mXzJVGiZceekGpD1vl7igglgJrbdOOTgTGlxlIFDDoAms+A?= =?us-ascii?Q?hOB7QrtmcVMg1Gn5sZObiAjtIr2WSi5qUvcQWDWsoee6gz86UMPWLmUKfLD6?= =?us-ascii?Q?/z4DLI2D/c4QayAtyI+GHnyafQG7EKJdLLFu5IdJUM2GVouFYa0SSN+7RtS9?= =?us-ascii?Q?B1z3XjqrIcF434UBYzNpQpWe2moLNP1OkiY0qJO8FyjC4AD66YbZVSnWd1fP?= =?us-ascii?Q?2l3flu1SdL/e3mQutCmVFipcXuwahxHCkfuSnt/ukctP/Op9ZUMmV8Mpivco?= =?us-ascii?Q?IhmGL/NUEPWN6TjsXDgcKT8v2VX4V0a29RGKcm/5VuJkD+ANSOZ48UHYKL2w?= =?us-ascii?Q?+DJkqU6IIEEQ+zU32Ux3aiJrtOOh6j3HqcL+zJrgSwkMngt0dhVMEqEqfkMV?= =?us-ascii?Q?TcEVO1rlLYMNigWet3VmH1sOtR5GZzIMNICD65ohLOoFVmqf20YnBNttLZME?= =?us-ascii?Q?OPArV953pcE+shyZSzYzUpIaJ4Ab9OiLVT2JfEvT/dUs4EmAbEQ0JRby6Tc6?= =?us-ascii?Q?aHv7tRfucw5vYAcag3vUjetmMyLvlirTsavH0jJ4m2h9CbH0n7qlPlTht0Xq?= =?us-ascii?Q?gIywhyYUUpQKnhH0wsWAMIMl/tAG4z0iGpEbehTr5eda/2uTUzojDBik1B2B?= =?us-ascii?Q?HDJksYwcOYHxzaRTIcEglUHqjnjBSYdKoFoTk957w4ajG/gzc3BYi6cTl0D0?= =?us-ascii?Q?+nJOXvq54JinjX5J082BhrZ5EC5BatLU7zTtTtFwT1qTTkxAVU9hR5Fm53Cx?= =?us-ascii?Q?lhr8B8MREe0lUHExilsJOhDbqIy5bt99w5GuHI1d+OzEAWIdE3qz4zvPIRl3?= =?us-ascii?Q?dij1DIDXn2njMUgxp2II71jPnuapQ8B6yT0ds7pjPvU/MDgEciBVZhFtiR2s?= =?us-ascii?Q?LZKxck3shkT9nilqD26c=3D?= X-Microsoft-Antispam-Message-Info: EErD/LtCRLO3HDPiMK4XNZXUzQ0AdzFrznVgmh7zBZ/nneQVutfQ94gxsPeg0mC+RRSOt6eISLi52qonsRcmQbzmhN66Ku7e5tMZsOyJ3x3ycETzeC8YKTkOhn4Vbz83g4IuVP+YYq8N9S02F2MhfCqC8/4OPr8b4rLQzpngZc6NABJ03NGsBcUu9msJijbvLzSifdhLf+bPxmVuK/sYXL7T0MCIAnkwAjPKo+6ZZXp2sn1kJF8mtcTsG2xnZC8eitUK5pY9gm7xhwXG6rG6Dn/WhsDqC05VeMbXdRv2vybQb0IB1yERso2OEyj2WQS1L6qIaZMutmrphiB9VhTTk7ar7kiEMYe6Hvk5c59A0NM= X-Microsoft-Exchange-Diagnostics: 1; SN1PR0301MB1584; 6:6XAxQgSpPPZihHSnJqU/TNCBA5QmTwJmxLoxtxL0aB4T5SfvkzcTkXmUObuY//3AvhlFMNLvHHkGbvOwu0jqrrkYPdPfkOGaEF+ho47kFjxxXqXbn1sM/vOvqxTldgzSSlVIJZvNuoj8BUgi2xhIPOPyk25DVlgO04jQkdvE2V/B7YV8G8zVARXvfGjrDKYafkssbMEcjY4oJ1hVMRkj3Dq98fW8qqvIdfjJcTUlJno1yyVbwNHb407ph3mBMxnnU2/crxHIf3qHQGWsH84VXElhl/Pyv9C5X9iQWyW8bkcD8VpVGDpSL02HlXHsUDWw+mezHgToFuXDf2c3fDrpZT04ccoyJGjxwhntf/rEpJu63y9TYMMjYpFTCfoEAiOVpwfnn3yf5rtJ4vbNnc6ip6ZSJxliIGrgynXGFGTtKIZ6phVKK+1I6GaYmU4il0ATzGaAEnXoMC3R7YtiCRe4Mg==; 5:B10gQ0gUOpKmsHMPw/q+iUMKtjaYmt+OA1oU/dFsim6tF5mXYM924+dD4thEcChfot4Gm4uYSCAau8PHObAKAoM/NvGojsrYidtHUyHYt7l/JLbnF6VlrbLdpBYVCOJxzI2DEUrtG1FmSrJL5zrAPuqogCow7r+7O+1d/qItnoo=; 24:H12CSTQBTnhrVQeCZXGU4ERWzCz39ix6jo0mDJooJ/tOhwkj89Hy7N0DFoQw77SRLG/Te+GU5iSkibwNJ9Ipa5n8LdNBmamQHrSUBbpbpuo= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1; SN1PR0301MB1584; 7:CFfmXPzxOhMtD/YrfXY68l1hUSlA8NnB2upaEdgKY8ViZe9F0IVj5Gx7/mrwCiERzhhNtDlqCAz6Xi5U5SEoH/gOo+oJUphtcFngZeP8nYcGjEtIxVV0N/+QshSYBzA1cI8TdcrnHu8/L2BBolbRJzaEHtUtQihf6Zr2bhJr11bsXa8q4QE+za1hRMDS+KDP8s71u0Y13Xie1hutb2GfW/5auGdnvqCFCaMI0cylrVlo5C8lXBUvCfdLQMHH+2K7 X-OriginatorOrg: synaptics.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 Jul 2018 05:10:52.6500 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: cdc1cbad-a9b8-42b5-a438-08d5edff2b5d X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335d1fbc-2124-4173-9863-17e7051a2a0e X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN1PR0301MB1584 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20180719_221107_352200_C3713433 X-CRM114-Status: GOOD ( 10.31 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Viresh Kumar , linux-arm-kernel@lists.infradead.org, Sebastian Hesselbarth Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org X-Virus-Scanned: ClamAV using ClamSMTP The OPP properties, like "operating-points", should either be present for all the CPUs of a cluster or none. If these are present only for a subset of CPUs of a cluster then things will start falling apart as soon as the CPUs are brought online in a different order. For example, this will happen because the operating system looks for such properties in the CPU node it is trying to bring up, so that it can create an OPP table. Add such missing properties. Fix other missing properties (clocks, clock latency) as well to make it all work. Signed-off-by: Viresh Kumar Signed-off-by: Jisheng Zhang --- Hi Olof, Arnd, This is a single patch from berlin-dt for 4.19, so I send it directly to you, could you please kindly merge it? Thanks arch/arm/boot/dts/berlin2.dtsi | 10 ++++++++++ arch/arm/boot/dts/berlin2q.dtsi | 33 +++++++++++++++++++++++++++++++++ 2 files changed, 43 insertions(+) diff --git a/arch/arm/boot/dts/berlin2.dtsi b/arch/arm/boot/dts/berlin2.dtsi index db67377af266..d2f7d984bba5 100644 --- a/arch/arm/boot/dts/berlin2.dtsi +++ b/arch/arm/boot/dts/berlin2.dtsi @@ -50,6 +50,16 @@ device_type = "cpu"; next-level-cache = <&l2>; reg = <1>; + + clocks = <&chip_clk CLKID_CPU>; + clock-latency = <100000>; + operating-points = < + /* kHz uV */ + 1200000 1200000 + 1000000 1200000 + 800000 1200000 + 600000 1200000 + >; }; }; diff --git a/arch/arm/boot/dts/berlin2q.dtsi b/arch/arm/boot/dts/berlin2q.dtsi index 516a7ce25791..99d6872a6dfc 100644 --- a/arch/arm/boot/dts/berlin2q.dtsi +++ b/arch/arm/boot/dts/berlin2q.dtsi @@ -45,6 +45,17 @@ device_type = "cpu"; next-level-cache = <&l2>; reg = <1>; + + clocks = <&chip_clk CLKID_CPU>; + clock-latency = <100000>; + /* Can be modified by the bootloader */ + operating-points = < + /* kHz uV */ + 1200000 1200000 + 1000000 1200000 + 800000 1200000 + 600000 1200000 + >; }; cpu2: cpu@2 { @@ -52,6 +63,17 @@ device_type = "cpu"; next-level-cache = <&l2>; reg = <2>; + + clocks = <&chip_clk CLKID_CPU>; + clock-latency = <100000>; + /* Can be modified by the bootloader */ + operating-points = < + /* kHz uV */ + 1200000 1200000 + 1000000 1200000 + 800000 1200000 + 600000 1200000 + >; }; cpu3: cpu@3 { @@ -59,6 +81,17 @@ device_type = "cpu"; next-level-cache = <&l2>; reg = <3>; + + clocks = <&chip_clk CLKID_CPU>; + clock-latency = <100000>; + /* Can be modified by the bootloader */ + operating-points = < + /* kHz uV */ + 1200000 1200000 + 1000000 1200000 + 800000 1200000 + 600000 1200000 + >; }; };