From patchwork Fri Jul 20 10:11:50 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jisheng Zhang X-Patchwork-Id: 10536403 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 085F86053F for ; Fri, 20 Jul 2018 10:14:25 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id E58A329229 for ; Fri, 20 Jul 2018 10:14:24 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id D8A7E2922E; Fri, 20 Jul 2018 10:14:24 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.9 required=2.0 tests=BAD_ENC_HEADER,BAYES_00, DKIM_SIGNED, DKIM_VALID, MAILING_LIST_MULTI autolearn=ham version=3.3.1 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id C8ED129229 for ; Fri, 20 Jul 2018 10:14:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=pj02JqZEbsu9iQ+zau6CTCZ6lJl5sYiRQWtwtRoCaYQ=; b=hZqukBWKOuViH0 HZAMC1638XDc3SoMDnHYm3LPTvoQAOE1eDCscZLN6Zbq4DP+B/On2aajRLXB4hC8tzDwgrL0FSS3n yMZW7mVTl2HCDiVTJyBg+12c039Iyi0zhuLjwdmCq5ihjOaM14gC0t/WQT3fZMxsV3QmPcVCwP/Ow XqI0l2ybug8Vi5aef+uN24mdS7PcCyobkzOL7tI0Msfm60OTur7nfeRDRsyTnNjiFgQz5JpZ0+yq5 YGNzHO7LleYsh0egzuDF8FmqtKXggbax/yUG8KRysnPEFaOQwOUM++pr162RP2uAgcr2GkhYz4CTK yYc+wgZdeOLyfuUP+hSQ==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1fgSQX-0005Ay-0Q; Fri, 20 Jul 2018 10:14:21 +0000 Received: from mail-bl2nam02on0082.outbound.protection.outlook.com ([104.47.38.82] helo=NAM02-BL2-obe.outbound.protection.outlook.com) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1fgSQT-00058l-D3 for linux-arm-kernel@lists.infradead.org; Fri, 20 Jul 2018 10:14:19 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Synaptics.onmicrosoft.com; s=selector1-synaptics-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Ah7YvpG+R1EVjSSaYc92wvZTkblAZDPec/UJ/jIYGrs=; b=J+GG5eIRhPY+ZaCHtNlX44I7ojNetAe+U8lWHUHHyTX8zcgan8Kci8DYQKlvO3bm76eqm125KduxuCi1fiLa06DfFqVOuPSk93qizxQdmddcIoYCwux3cXGtVPiA9Ky+HBxF/9VT5sRLkq9zyUnoAFFxL2JlVIbhKUk/MhG5Wtg= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=Jisheng.Zhang@synaptics.com; Received: from xhacker.debian (124.74.246.114) by BLUPR0301MB1571.namprd03.prod.outlook.com (2a01:111:e400:52a9::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.973.16; Fri, 20 Jul 2018 10:14:03 +0000 Date: Fri, 20 Jul 2018 18:11:50 +0800 From: Jisheng Zhang To: Olof Johansson , Arnd Bergmann , arm@kernel.org Subject: [PATCH v2] ARM: dts: berlin: Add missing OPP properties for CPUs Message-ID: <20180720181150.15a2aa71@xhacker.debian> In-Reply-To: <20180720130838.187becb9@xhacker.debian> References: <20180720130838.187becb9@xhacker.debian> X-Mailer: Claws Mail 3.16.0 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 X-Originating-IP: [124.74.246.114] X-ClientProxiedBy: TY2PR02CA0013.apcprd02.prod.outlook.com (2603:1096:404:56::25) To BLUPR0301MB1571.namprd03.prod.outlook.com (2a01:111:e400:52a9::17) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: ff53903a-61f2-4909-41ed-08d5ee298617 X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(7020095)(4652040)(8989117)(5600053)(711020)(4534165)(4627221)(201703031133081)(201702281549075)(8990107)(2017052603328)(7153060)(7193020); SRVR:BLUPR0301MB1571; X-Microsoft-Exchange-Diagnostics: 1; BLUPR0301MB1571; 3:wAELfhFLi44hezrzW0VR4YH5krcSro7yjF9XFBycUGD8sp6nzOukil8J+yaqWD133bK335pgFmvL//qMPKHW63O0NNyqC4zau8rvNFztwvUUdw/IMDZMvhKmhDNT59OmzSaOQw93bRHt4g/Qx8GHbfxsrb12OtOLP2L8GH43IG2P4htHXD9/UEh3Oa3TBrrUVigkGpNJnS2b6UvKsgaBRrV9uIihxHsaNC5SykkHqmQ44mB+iKe+cxytodThcaOS; 25:MDntPAfY26LyreyJHILk19JSRwLkD1JKNhuiaNEoxkuM82oq4Fq67xBev57O7jG1uIISO7hUDEX9kCVYjAKU8UO01/vkSwjxBsNBmoh/rzqx9+t228zTjpYvZjczrR5I50oqPJLt6YELNyeQC50/QNM7YubHrg16m6AbU0SbuMoS0fvnVUOUhb6qlBubxOuoazUFud2PBiOPRl+YDAY746D+J7KSj7wzWid0hGnE/IGBlb6gmyaE9YoYeUbuVIJhivKOL6GWFEel1Z/MckDpOuo8rabSE/r5RbLYBrhMUHrw6s07QVbae098E2xHr0cBufBSuGutXIKYIa/AH8U8q0Jv4weE67DORLCjqRMS9v8=; 31:cfuOT0OI7RMuYNhx+hDaK23CfElafwRSxQdrvxAQD4xSPRWgydlM19YttDZJbxMZ4LYO2UBcCkaZbT376A9RBUQuNbwqKSxpPZp0sCuloG6iy1zwty6801XO5+/lA77sQSsgu2AbnVEJPlHkn6Ld8Uyl9ojy5GIFCU5Ogs0oRm7rw8MeINoRcI83yBpyk/BgIFIDuZ4weYYKfkN6WuN0+Zbu6QDMtnZ97cLLl6mT9Lc= X-MS-TrafficTypeDiagnostic: BLUPR0301MB1571: X-Microsoft-Exchange-Diagnostics: 1; BLUPR0301MB1571; 20:v2IZJqLtUqF3ucX4oLDAFuLZO924TEMFix84KVW/nIdaYSF1SjwnSu5+bro+7Tr1vva4/7hT/a95kSnffypjPVOnptXPP6pmLwQVkD7kMAyWzRqnXNKT5vPDPf7p7lhJDf8bTC19/YxscByp+7VdZWyUaPEAYODJ7FDY0zkgqNLH9jgIkgn/oqHrf9qKGQXPwKbLQHkvfS6+XHJzsQBpUzk4cE93bN1Go40lQBrPOuti4zlQYYVuqOmkoO2gBkDKHKE8IWUM2pCb4LSt1IFUyXx4hFQ9srxY73Vgdfd3h4RvePIibhezF4R5bUa+EWjQHcwlQT4QqlXXjNKBrw1MPYhOcrbdUvPhlca81MSkCWtda6kOPMCUzr09/oRUjo79KxMXeBQM1mLtgOxIoj8CgS/iTlwCP/rtwpPoR34ezWafaAIOU7x+Ehu4/S5kdSFC/rRJAO69OuEAMu6YWS2Gvc7fMaNF+Jo76hPGcO2oN8NVRTTP2lBsi9XfIF6olRv0; 4:PpxlzLRG27GsYTHf9NDNdL0glYezWForp7juSKkodM9od6kV6hzYI/96xST2UnMG7tiE4DavEzutkmnAuUSM7XQg64H74dIs5TqCyeTPPFM9g4S6kPyubFMTNuejjH9GYcHJWdOCpkUiqzioLe/2xbfp7R00KXdUWkMeQj9gZcmq21ru+9h/N8k1c5PNqkxZuTYC/q7o6orKezUz0rYMg8ywWxjbxn09RvHlzJ/zQ3xO/CsvrAJ21r1bSXweYzaCvkm6HLp456XAiQviON1973ja0FbT5evk/Bq6Togv3Voz3zMEZJXZ6PAr1KVY+nfP X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(209352067349851); X-MS-Exchange-SenderADCheck: 1 X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(6040522)(2401047)(8121501046)(5005006)(3231311)(944501410)(52105095)(3002001)(93006095)(93001095)(10201501046)(149027)(150027)(6041310)(20161123564045)(20161123558120)(20161123562045)(20161123560045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(6072148)(201708071742011)(7699016); SRVR:BLUPR0301MB1571; BCL:0; PCL:0; RULEID:; SRVR:BLUPR0301MB1571; X-Forefront-PRVS: 073966E86B X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(346002)(376002)(396003)(39860400002)(366004)(136003)(189003)(199004)(3846002)(23726003)(1076002)(6116002)(97736004)(230700001)(106356001)(105586002)(25786009)(5660300001)(6666003)(54906003)(476003)(53936002)(55016002)(9686003)(50466002)(50226002)(39060400002)(52116002)(8676002)(7696005)(81166006)(956004)(4326008)(110136005)(6506007)(386003)(76176011)(16526019)(186003)(26005)(33896004)(2906002)(8936002)(72206003)(446003)(47776003)(14444005)(305945005)(68736007)(7736002)(11346002)(486006)(81156014)(316002)(86362001)(66066001)(478600001)(39210200001); DIR:OUT; SFP:1101; SCL:1; SRVR:BLUPR0301MB1571; H:xhacker.debian; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; Received-SPF: None (protection.outlook.com: synaptics.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; BLUPR0301MB1571; 23:tAfsItf6sGXm7WFBy5zlg9Xoz4qBfplYuFRRWiI?= =?us-ascii?Q?GbnjKQO3zqlwHH1WCoT8Nwtf6RXIDL8U2AULoJczhGInblGaIZS5PbsbBxYt?= =?us-ascii?Q?yBybJ+bSJIIILTPf2LGOiU+PKS1RhvaDdcKernAHL22sfjJ+B37ys+0MOxEN?= =?us-ascii?Q?zZpfl9kbAh4EKx3S6yEOQGwE6oXzAIxwAi3ccuCOOnZVBOrh9A3NlMSMrMHz?= =?us-ascii?Q?3nfi38xpkRR06Ym57qBfI0N3kDLq6CJlci8GRXI8SYJD+DvAyQuJNrojjdtS?= =?us-ascii?Q?Dqep87vCui6Tra7TJTqQVXRGiFTHpnKlPKJISHXGno+Ofg4avf75LOWdgWa9?= =?us-ascii?Q?2akoWD0UoJidMLmVhfYvz6cZR9IiENpaKr3nOU9TjdZFa3xNa9HmQl7erGaD?= =?us-ascii?Q?lfYWaDk8nku1PvT6gwckJJ3EOd+tSjPLveZH0AKCS2q9k8SWa8Nq62yj4Q3q?= =?us-ascii?Q?+BNphoKKTZl7f96QpJoPh9Rq3C20f413S+GKErjar62JBpiDcanYE+DzrxZm?= =?us-ascii?Q?gV/zbLM2EComBf8gdTuX0gcT6EkZLqox7Uo8Eve35bC3I70a/tMpY7Nvqc1/?= =?us-ascii?Q?A40MwvXqYnBr8Kaa9uBWavRc0myS+kAz4lhSllP+opPxqiuE78cwIvNc2TBT?= =?us-ascii?Q?wN/0TffZvF3qLkpw3klErvC5SWMI31FqfeyMKTbNYWJ0bXojdDcaIiX+u4af?= =?us-ascii?Q?2i9mOpq6X31SPyr9s314iNW2Er7VN9viESguORVGX3JtgdBP+xCIbi3ng4gJ?= =?us-ascii?Q?yWtF8L2g9YnzHR6/JwsZpXE8Aj++eVN27ft3Bo+9hIREETZkhD0c8Ht/2TTo?= =?us-ascii?Q?LbDfNmzPJ6wWZUQ1xETUNbXriOSzKAxsVOz+My0Ok+G6fHbsIRH/uWTPHZFK?= =?us-ascii?Q?kg4oSOd1Oxb9e7EFc/w6T4pE56XKtzRH0LdFZeo8+NnL39XxCT4pSxidxYN6?= =?us-ascii?Q?Tj2zYuLjFyCB+8sAMACUdctmD5WHwjmOqnxlT3uaKn6NbeAQ1khLcppL118W?= =?us-ascii?Q?Z+sul93UBGdpa7iERzy4jNZyp+dbVoYa/9d/hsbhawvvKrRi+6QF6ym1VL9v?= =?us-ascii?Q?IP1OOA7YXv/76Nxi92SyMWbMlzyWObC97r7CtXHnKKjwhM7CbX4ighsIViFe?= =?us-ascii?Q?4Sxtoj6z+UGMHO+a3srnyyafJTpi4mbzhXh462YKu3Wj3C0ms2YULgsstWFC?= =?us-ascii?Q?zGdWrRXBqVBzQp710iuIR0qGocGcmNuK/2VA+gD+feozGur5eBpv+mnYW6PW?= =?us-ascii?Q?S3SQgYOybOA2curUa/XoUBIo4LQCWbGwzSC84Jidlpr4aIOi5owZhFh795B9?= =?us-ascii?Q?Sfg=3D=3D?= X-Microsoft-Antispam-Message-Info: maYO42EMgEuyL89ZvNDpyMFexlcgYwqKDhv76pezLsjSLDrfgYnP4yZe3PLFETHO3fQ34gYLG25xe1gtbC78kJIxQDe5GqmqNnjyuhapIOquS9j32G87KJzaABNY5dycxM4HBvS3R2KV67Zkpmx+dmZyjfodGw/bmzON7/bSKWZG1JSKf/9HnL4aXY+UD194sd9ZYgjIecOHeF/hPIhLXI+Ee4ySmv4R4vE+jBpFDTGW8iUZZ2uhDhaNkr2nAEvCATikZJx3Il3WSbeQx0wPPnKEEvgoFrqKw0FR/700yAmJ8gGDiE9NPxwM1gSUEsM4rqVo0gdDy3uewYuXAslW1QQzogqITV5TE17j4VDAXcE= X-Microsoft-Exchange-Diagnostics: 1; BLUPR0301MB1571; 6:QN4CYqOYAEeZYQNONHi9SY6jKXQB5Ys3xCWEN0z+rHQ5OpTqJhy/dizW1Mp/GFfA3o2/YAIE97RF7NyAkPEW7hdIsxA9rtjlq5/1kuJZVCWTMcrR3kXghUWaV9jwmuAXfbA1WIQbTGjA9B2+qyldtrvwlkdRqUIBiCzj8+JbVEg1Ds3WyRMdakOidMLx/oEQTrvQjqchS6l5SYAIq5PE2QcnanG0iUREXJe7ugmthRDqdKyLY4BbB94egnhqkNTip2xMr452LpjlTELJanYokAh8OeVjkbDxAUM09cCiOsGe8iLONQuYidmP+aZoLQnEVn6xDdIVfB4IKI+XLi2nmY7whDXOIm4eD3Wy72kgsHjGFeieAXF5ow8QmsJqluRgVm6Hqi0nj0R/97jgFycRZyiD6SxlQpOzuh4bITZUim2CEAjEdsU3imBwZtSm4tG4BFEOinNMi4yTgR+tZjbgRA==; 5:qmi7sbA+3xu4aSVlh7nPS12XMVDNuyVghQMLgxDgFcjoJh9kVYF2/gsfmoGWiz1ZpLbzeFE+s7QVCN7fVbWSHrPCX6Dq0OMDuxl6lCqCTNFN9YUnoOqNMyB6XpRDxj2o8hbpec6rLOtpYabQ321X1aoMCvGjf/wLB5/t89FeiEk=; 7:CuGKgiZ3qGpMPNKHaKlCyECRmJYS6YW195+Bq5nxlwN45HltDklzH4/C6LCGzVp7TxEEJsxzk4Z64eXF3U8riVF8Amb1heYfnUpF+MgDl4F/wMuSQIDKtMqkOxQb1tamPFA9GNzkP3Sdh9m6Y8DO5yeYuBWzCEGSUds/oDrBgzh53pmubyMvnWrlEyworKrJdxi9owjY/mBS4OiMrXY5VIH2RBJoNvZFgYdbPxiNrev74mlqHbOsgbWcLyblY5o3 SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: synaptics.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 Jul 2018 10:14:03.4783 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: ff53903a-61f2-4909-41ed-08d5ee298617 X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335d1fbc-2124-4173-9863-17e7051a2a0e X-MS-Exchange-Transport-CrossTenantHeadersStamped: BLUPR0301MB1571 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20180720_031417_551319_45396384 X-CRM114-Status: UNSURE ( 9.44 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Viresh Kumar , linux-arm-kernel@lists.infradead.org, Sebastian Hesselbarth Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org X-Virus-Scanned: ClamAV using ClamSMTP From: Viresh Kumar The OPP properties, like "operating-points", should either be present for all the CPUs of a cluster or none. If these are present only for a subset of CPUs of a cluster then things will start falling apart as soon as the CPUs are brought online in a different order. For example, this will happen because the operating system looks for such properties in the CPU node it is trying to bring up, so that it can create an OPP table. Add such missing properties. Fix other missing properties (clocks, clock latency) as well to make it all work. Signed-off-by: Viresh Kumar Signed-off-by: Jisheng Zhang --- Since v1: - fix author, it's from Viresh. Sorry for making this mistake arch/arm/boot/dts/berlin2.dtsi | 10 ++++++++++ arch/arm/boot/dts/berlin2q.dtsi | 33 +++++++++++++++++++++++++++++++++ 2 files changed, 43 insertions(+) diff --git a/arch/arm/boot/dts/berlin2.dtsi b/arch/arm/boot/dts/berlin2.dtsi index db67377af266..d2f7d984bba5 100644 --- a/arch/arm/boot/dts/berlin2.dtsi +++ b/arch/arm/boot/dts/berlin2.dtsi @@ -50,6 +50,16 @@ device_type = "cpu"; next-level-cache = <&l2>; reg = <1>; + + clocks = <&chip_clk CLKID_CPU>; + clock-latency = <100000>; + operating-points = < + /* kHz uV */ + 1200000 1200000 + 1000000 1200000 + 800000 1200000 + 600000 1200000 + >; }; }; diff --git a/arch/arm/boot/dts/berlin2q.dtsi b/arch/arm/boot/dts/berlin2q.dtsi index 516a7ce25791..99d6872a6dfc 100644 --- a/arch/arm/boot/dts/berlin2q.dtsi +++ b/arch/arm/boot/dts/berlin2q.dtsi @@ -45,6 +45,17 @@ device_type = "cpu"; next-level-cache = <&l2>; reg = <1>; + + clocks = <&chip_clk CLKID_CPU>; + clock-latency = <100000>; + /* Can be modified by the bootloader */ + operating-points = < + /* kHz uV */ + 1200000 1200000 + 1000000 1200000 + 800000 1200000 + 600000 1200000 + >; }; cpu2: cpu@2 { @@ -52,6 +63,17 @@ device_type = "cpu"; next-level-cache = <&l2>; reg = <2>; + + clocks = <&chip_clk CLKID_CPU>; + clock-latency = <100000>; + /* Can be modified by the bootloader */ + operating-points = < + /* kHz uV */ + 1200000 1200000 + 1000000 1200000 + 800000 1200000 + 600000 1200000 + >; }; cpu3: cpu@3 { @@ -59,6 +81,17 @@ device_type = "cpu"; next-level-cache = <&l2>; reg = <3>; + + clocks = <&chip_clk CLKID_CPU>; + clock-latency = <100000>; + /* Can be modified by the bootloader */ + operating-points = < + /* kHz uV */ + 1200000 1200000 + 1000000 1200000 + 800000 1200000 + 600000 1200000 + >; }; };