diff mbox series

[5/5] arm64: dts: actions: Add pinctrl node for Actions Semi S700

Message ID 20180722163601.28346-6-sravanhome@gmail.com (mailing list archive)
State New, archived
Headers show
Series Add Actions Semi S700 pinctrl support | expand

Commit Message

saravanan sekar July 22, 2018, 4:36 p.m. UTC
Add pinctrl nodes for Actions Semi S700 SoC

Signed-off-by: Parthiban Nallathambi <pn@denx.de>
Signed-off-by: Saravanan Sekar <sravanhome@gmail.com>
---
 arch/arm64/boot/dts/actions/s700.dtsi | 6 ++++++
 1 file changed, 6 insertions(+)

Comments

Manivannan Sadhasivam July 26, 2018, 6:40 p.m. UTC | #1
Hi,

On Sun, Jul 22, 2018 at 06:36:01PM +0200, Saravanan Sekar wrote:
> Add pinctrl nodes for Actions Semi S700 SoC
> 
> Signed-off-by: Parthiban Nallathambi <pn@denx.de>
> Signed-off-by: Saravanan Sekar <sravanhome@gmail.com>
> ---
>  arch/arm64/boot/dts/actions/s700.dtsi | 6 ++++++
>  1 file changed, 6 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/actions/s700.dtsi b/arch/arm64/boot/dts/actions/s700.dtsi
> index 59d29e4ca404..88edac21e03f 100644
> --- a/arch/arm64/boot/dts/actions/s700.dtsi
> +++ b/arch/arm64/boot/dts/actions/s700.dtsi
> @@ -179,5 +179,11 @@
>  			interrupts = <GIC_SPI 11 IRQ_TYPE_LEVEL_HIGH>;
>  			interrupt-names = "timer1";
>  		};
> +
> +		pinctrl: pinctrl@e01b0000 {
> +			compatible = "actions,s700-pinctrl";
> +			reg = <0x0 0xe01b0000 0x0 0x1000>;
> +			clocks = <&cmu CLK_GPIO>;
> +		};

Driver/binding/dts are inconsistent. Driver seems to support pinctrl +
gpio + irq but there is no gpio/irq property in dts patch.

Please correct it.

Thanks,
Mani

>  	};
>  };
> -- 
> 2.18.0
>
diff mbox series

Patch

diff --git a/arch/arm64/boot/dts/actions/s700.dtsi b/arch/arm64/boot/dts/actions/s700.dtsi
index 59d29e4ca404..88edac21e03f 100644
--- a/arch/arm64/boot/dts/actions/s700.dtsi
+++ b/arch/arm64/boot/dts/actions/s700.dtsi
@@ -179,5 +179,11 @@ 
 			interrupts = <GIC_SPI 11 IRQ_TYPE_LEVEL_HIGH>;
 			interrupt-names = "timer1";
 		};
+
+		pinctrl: pinctrl@e01b0000 {
+			compatible = "actions,s700-pinctrl";
+			reg = <0x0 0xe01b0000 0x0 0x1000>;
+			clocks = <&cmu CLK_GPIO>;
+		};
 	};
 };